Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: libconsensus: add missing error code description, fix NBitcoin link #20577

Merged

Conversation

theStack
Copy link
Contributor

@theStack theStack commented Dec 5, 2020

This PR improves the libbitcoinconsensus description in shared-libraries.md in two ways:

@fanquake fanquake added the Docs label Dec 5, 2020
@DrahtBot
Copy link
Contributor

DrahtBot commented Dec 6, 2020

🕵️ @harding has been requested to review this pull request as specified in the REVIEWERS file.

@maflcko
Copy link
Member

maflcko commented Dec 6, 2020

cr ACK cb0b712

@harding
Copy link
Contributor

harding commented Dec 6, 2020

Code (documentation) review ACK cb0b712. Text is clear and seems accurate, and the link checks out.

@fanquake fanquake merged commit cef2efa into bitcoin:master Dec 7, 2020
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
@theStack theStack deleted the 201212-doc-libbitcoinconsensus-fixes branch January 10, 2023 13:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants