No description provided.
P2P: do not return addresses older than 7 days in "addr" messages
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/bd011eafb3b4caf470ac2def2ea321e772267dec for binaries and test log.
Good idea. Maybe make the 7 day window a command line flag?
My default setting on command line flags tends to be "avoid, unless necessary"
Is there a case where we would need a flag? Ideally the default should just make sense, and users should not need to change anything.
I don't think it should be a flag, but maybe a 7-day strict boundary between relay / norelay is too deterministic. I don't think we really want to make the network forget everything that's more than a week ago - except for crawlers, node connections are just not tried frequently enough to know that "not seen in a week" means "gone".
I prefer something that just favors relaying recently-seen addresses.
What are the value of old addresses, versus cost?
Most other P2P networks and DHTs have a far shorter lifespan for addresses. As my testing showed, the large majority of addresses we pass to other peers are 100% useless.
Just saying there is a difference between "not having seen in the last week" and "having tried the last week and failed". IIRC there are more timestamps available to make a good decision.
Closing. Not much interest, and comments suggest a desire for something else.