Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

OptionsModel now has MapPortUPnP=false if UPNP is not supported #2094

wants to merge 3 commits into


None yet
2 participants

al42and commented Dec 12, 2012

When compiled with "USE_UPNP=-", in "Options/Network" tab the "Map port using UPNP" checkbox is set up and disabled, which creates the impression that UPNP is always on.

This patch makes OptionModel to always return false is UPNP is disabled, which solves this checkbox problem and, IMHO, is much more intuitive behaviour overall.

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/333df361162c6440257edf59a907d5d5e8b91e49 for binaries and test log.

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/8672bd3ba22664c8ee061f2876c174120bf27f56 for binaries and test log.

@al42and al42and closed this Dec 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment