Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

OptionsModel now has MapPortUPnP=false if UPNP is not supported #2095

Merged
merged 1 commit into from Dec 12, 2012

Conversation

Projects
None yet
5 participants
Contributor

al42and commented Dec 12, 2012

When compiled with USE_UPNP=-, in "Options/Network" tab the "Map port using UPNP" checkbox is set up and disabled, which creates the impression that UPnP is always on.

This patch makes OptionModel to always return false if UPnP is disabled, which solves this checkbox problem and, IMHO, is much more intuitive behaviour overall. Please review.

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/6a3aef39e70e6da81cbd2484c1721d44f9b02d9a for binaries and test log.

Owner

laanwj commented Dec 12, 2012

Yes good idea, ACK

Diapolo commented Dec 12, 2012

Yeah, good idea, ACK.

@gavinandresen gavinandresen added a commit that referenced this pull request Dec 12, 2012

@gavinandresen gavinandresen Merge pull request #2095 from al42and/upnp
OptionsModel now has MapPortUPnP=false if UPNP is not supported
278a09a

@gavinandresen gavinandresen merged commit 278a09a into bitcoin:master Dec 12, 2012

@laudney laudney pushed a commit to reddcoin-project/reddcoin that referenced this pull request Mar 19, 2014

@gavinandresen gavinandresen Merge pull request #2095 from al42and/upnp
OptionsModel now has MapPortUPnP=false if UPNP is not supported
e13b67f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment