Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Bitcoin-Qt: upgrade to Qt 4.8.4 for Windows builds #2108

Closed
wants to merge 1 commit into from

3 participants

@BitcoinPullTester

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/e8c120cfeb81acd538bc10ae8834d136c55d2c8b for binaries and test log.

@Diapolo

Any reason not to switch to latest Qt version?

@gavinandresen

Yes, it is time-consuming to rebuild dependencies for gitian, so when we do, I would rather we upgrade QT and boost and openssl any other dependencies (and maybe the OS we build on and the version of the compiler we use) all at once. The pain of changing dependencies is, I think, the reason we have so few people gitian-building releases, and that's a real problem.

I don't see any "must have" fixes in the QT 4.8.4 release notes.

@Diapolo

@gavinandresen If you prefer batch dependency upgrades perhaps I should just include the latest Boost version also. I'm fine with creating that pulls, because at least in the Win-world it is (most of the time) essential to stay up-to-date (security and performance wise).

I took a look at Gitian also, but the howto setup was a real pain for me and I came to the conclusion that I currently don't want to spend too much time with it.

@BitcoinPullTester

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/e8c120cfeb81acd538bc10ae8834d136c55d2c8b for binaries and test log.

@Diapolo

@gavinandresen So just to understand, when I create a patch to use Qt 4.8.4 does this require any manual or additional work for the core-devs who create the Gitian builds or does it just increase the compile-time once?

@gavinandresen

It requires manual/additional work. We have to rebuild our dependencies, and if the rebuilt dependencies have some non-determinism we have to spend time figuring out which of the dependencies is a problem and either fix it or just throw in the towel and trust one person's dependency to be correct.

@Diapolo

Closed in favor of #2414

@Diapolo Diapolo closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 18, 2013
  1. @Diapolo
This page is out of date. Refresh to see the latest.
View
2  contrib/gitian-descriptors/README
@@ -31,7 +31,7 @@ Once you've got the right hardware and software:
wget 'http://download.oracle.com/berkeley-db/db-4.8.30.NC.tar.gz'
wget 'https://downloads.sourceforge.net/project/libpng/zlib/1.2.6/zlib-1.2.6.tar.gz'
wget 'https://downloads.sourceforge.net/project/libpng/libpng15/older-releases/1.5.9/libpng-1.5.9.tar.gz'
- wget 'http://releases.qt-project.org/qt4/source/qt-everywhere-opensource-src-4.8.3.tar.gz'
+ wget 'http://releases.qt-project.org/qt4/source/qt-everywhere-opensource-src-4.8.4.tar.gz'
cd ../..
cd gitian-builder
View
2  contrib/gitian-descriptors/boost-win32.yml
@@ -4,7 +4,7 @@ suites:
- "lucid"
architectures:
- "i386"
-packages:
+packages:
- "mingw32"
- "faketime"
- "zip"
View
4 contrib/gitian-descriptors/gitian-win32.yml
@@ -15,14 +15,14 @@ remotes:
- "url": "https://github.com/bitcoin/bitcoin.git"
"dir": "bitcoin"
files:
-- "qt-win32-4.8.3-gitian-r1.zip"
+- "qt-win32-4.8.4-gitian-r1.zip"
- "boost-win32-1.50.0-gitian2.zip"
- "bitcoin-deps-0.0.5.zip"
script: |
#
mkdir $HOME/qt
cd $HOME/qt
- unzip ../build/qt-win32-4.8.3-gitian-r1.zip
+ unzip ../build/qt-win32-4.8.4-gitian-r1.zip
cd $HOME/build/
export PATH=$HOME/qt/bin/:$PATH
#
View
8 contrib/gitian-descriptors/qt-win32.yml
@@ -11,15 +11,15 @@ packages:
reference_datetime: "2011-01-30 00:00:00"
remotes: []
files:
-- "qt-everywhere-opensource-src-4.8.3.tar.gz"
+- "qt-everywhere-opensource-src-4.8.4.tar.gz"
script: |
INSTDIR="$HOME/qt/"
mkdir $INSTDIR
SRCDIR="$INSTDIR/src/"
mkdir $SRCDIR
#
- tar xzf qt-everywhere-opensource-src-4.8.3.tar.gz
- cd qt-everywhere-opensource-src-4.8.3
+ tar xzf qt-everywhere-opensource-src-4.8.4.tar.gz
+ cd qt-everywhere-opensource-src-4.8.4
sed 's/$TODAY/2011-01-30/' -i configure
sed 's/i686-pc-mingw32-/i586-mingw32msvc-/' -i mkspecs/unsupported/win32-g++-cross/qmake.conf
sed --posix 's|QMAKE_CFLAGS\t\t= -pipe|QMAKE_CFLAGS\t\t= -pipe -isystem /usr/i586-mingw32msvc/include/ -frandom-seed=qtbuild|' -i mkspecs/unsupported/win32-g++-cross/qmake.conf
@@ -51,4 +51,4 @@ script: |
# as zip stores file timestamps, use faketime to intercept stat calls to set dates for all files to reference date
export LD_PRELOAD=/usr/lib/faketime/libfaketime.so.1
- zip -r $OUTDIR/qt-win32-4.8.3-gitian-r1.zip *
+ zip -r $OUTDIR/qt-win32-4.8.4-gitian-r1.zip *
View
4 doc/release-process.txt
@@ -31,12 +31,12 @@
wget 'ftp://ftp.simplesystems.org/pub/libpng/png/src/libpng-1.5.9.tar.gz'
wget 'http://fukuchi.org/works/qrencode/qrencode-3.2.0.tar.bz2'
wget 'http://downloads.sourceforge.net/project/boost/boost/1.50.0/boost_1_50_0.tar.bz2'
- wget 'http://releases.qt-project.org/qt4/source/qt-everywhere-opensource-src-4.8.3.tar.gz'
+ wget 'http://releases.qt-project.org/qt4/source/qt-everywhere-opensource-src-4.8.4.tar.gz'
cd ..
./bin/gbuild ../bitcoin/contrib/gitian-descriptors/boost-win32.yml
mv build/out/boost-win32-1.50.0-gitian2.zip inputs/
./bin/gbuild ../bitcoin/contrib/gitian-descriptors/qt-win32.yml
- mv build/out/qt-win32-4.8.3-gitian-r1.zip inputs/
+ mv build/out/qt-win32-4.8.4-gitian-r1.zip inputs/
./bin/gbuild ../bitcoin/contrib/gitian-descriptors/deps-win32.yml
mv build/out/bitcoin-deps-0.0.5.zip inputs/
Something went wrong with that request. Please try again.