Bitcoin-Qt: ensure all Windows scopes use win32 as identifier #2109

Merged
merged 1 commit into from Jan 19, 2013

Conversation

Projects
None yet
3 participants
@Diapolo

Diapolo commented Dec 15, 2012

Philip Kaufmann
Bitcoin-Qt: ensure all Windows scopes use win32 as identifier
- currently we sometimes use "windows" or "win32", but as per
  http://doc.qt.digia.com/qt/qmake-advanced-usage.html, windows seems to
  be not officially supported (only win32 is mentioned there)
@BitcoinPullTester

This comment has been minimized.

Show comment Hide comment
@BitcoinPullTester

BitcoinPullTester Dec 16, 2012

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/7601152ce24b6c9a67335e641a242a0be6888dfe for binaries and test log.

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/7601152ce24b6c9a67335e641a242a0be6888dfe for binaries and test log.

@Diapolo

This comment has been minimized.

Show comment Hide comment
@Diapolo

Diapolo Jan 19, 2013

I consider this a cleanup, which doesn't break a thing, I tried the resulting exe, which is working fine. We shouldn't use 2 different scopes, if win32 is sufficient IMHO!

Diapolo commented Jan 19, 2013

I consider this a cleanup, which doesn't break a thing, I tried the resulting exe, which is working fine. We shouldn't use 2 different scopes, if win32 is sufficient IMHO!

laanwj added a commit that referenced this pull request Jan 19, 2013

Merge pull request #2109 from Diapolo/qt-pro-file-win32
Bitcoin-Qt: ensure all Windows scopes use win32 as identifier

@laanwj laanwj merged commit ac3907b into bitcoin:master Jan 19, 2013

laudney pushed a commit to reddcoin-project/reddcoin that referenced this pull request Mar 19, 2014

Merge pull request #2109 from Diapolo/qt-pro-file-win32
Bitcoin-Qt: ensure all Windows scopes use win32 as identifier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment