break after ProcessMessage() to give other peers a chance. #2125

Closed
wants to merge 1 commit into
from

4 participants

@rebroad

This is to help with nodes becoming unresponsive in the eyes of other nodes. Also, in combination with my other pulls, this helps to reduce the number of duplicate blocks received.

@BitcoinPullTester

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/7f49bfde58ddf53611229ae2e0215fbea3b1425b for binaries and test log.

@BitcoinPullTester

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/7f49bfde58ddf53611229ae2e0215fbea3b1425b for binaries and test log.

@sipa
Bitcoin member

Can you test whether this is still needed, after the recent network changes?

@jgarzik
Bitcoin member

It seems unneeded, AFAICS

@sipa
Bitcoin member

Yes, I also don't see what this should help with, but rebroad seems to have unusual network problems of some sort, so I still wonder whether perhaps those improved because of the recent network changes.

@rebroad

@sipa yes, this still is useful after your network changes. This patch is still providing me with valuable functionality - especially when combined with #1382

@sipa
Bitcoin member

Can you explain what exact difference in behaviour you notice?

@jgarzik
Bitcoin member

@rebroad Agree w/ @sipa. Please explain precisely what behavior differences and problems are being seen.

"still useful" is insufficient :)

@jgarzik
Bitcoin member

Closing. Happy to reopen, if behavior differences can be specifically quantified.

@jgarzik jgarzik closed this Jun 19, 2013
@rebroad rebroad deleted the rebroad:BreakAfterProcessMessage branch Feb 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment