This is to help with nodes becoming unresponsive in the eyes of other nodes. Also, in combination with my other pulls, this helps to reduce the number of duplicate blocks received.
break after ProcessMessages() to give other peers a chance.
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/7f49bfde58ddf53611229ae2e0215fbea3b1425b for binaries and test log.
Can you test whether this is still needed, after the recent network changes?
It seems unneeded, AFAICS
Yes, I also don't see what this should help with, but rebroad seems to have unusual network problems of some sort, so I still wonder whether perhaps those improved because of the recent network changes.
@sipa yes, this still is useful after your network changes. This patch is still providing me with valuable functionality - especially when combined with #1382
Can you explain what exact difference in behaviour you notice?
@rebroad Agree w/ @sipa. Please explain precisely what behavior differences and problems are being seen.
"still useful" is insufficient :)
Closing. Happy to reopen, if behavior differences can be specifically quantified.