Skip to content

[0.21] Introduce DeferredSignatureChecker and have SignatureExtractorClass subclass it #21640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2021
Merged

[0.21] Introduce DeferredSignatureChecker and have SignatureExtractorClass subclass it #21640

merged 2 commits into from
Apr 12, 2021

Conversation

achow101
Copy link
Member

@achow101 achow101 commented Apr 8, 2021

Backport of #21166

achow101 added 2 commits April 8, 2021 18:18
@achow101
Introduce DeferringSignatureChecker and inherit with SignatureExtractor
7de019b 
Introduces a DeferringSignatureChecker which simply takes a
BaseSignatureChecker and passes through everything.
SignatureExtractorChecker now subclasses DeferringSignatureChecker. This
allows for all BaseSignatureChecker functions to be implemented for
SignatureExtractorChecker, while allowing for future signature checkers
which opreate similarly to SignatureExtractorChecker.

Github-Pull: bitcoin#21166
Rebased-From: 6965456
@achow101
Test that signrawtx works when a signed CSV and CLTV inputs are present
f79189c 
Github-Pull: bitcoin#21166
Rebased-From: a97a929
@achow101 achow101 mentioned this pull request Apr 8, 2021
Merged
@fanquake fanquake added this to the 0.21.1 milestone Apr 8, 2021
@maflcko
Copy link
Member

maflcko commented Apr 9, 2021 •
edited
Loading

checked this is a clean cherry-pick did not review ACK f79189c 🐖

Show signature and timestamp

Signature:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

checked this is a clean cherry-pick did not review ACK f79189ca54524881d52b91679eb9035d6718ce01 🐖
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUhRWAv9ERGSxYEqH7POd+OTvHKZUkcwliybNR3w9C4ausjLhOuAGAx5JCKpFpOm
E1OtdbkTqwtmbprauz+h2FJpED5z7wNg+jWb9GEAE4CImgi76qoWvTcwD7L9rNTi
PqglbeoNfyfeSSEEcumNKrcR1TNR7V5wewGiexQsvrsWh9+/wyX8yWUBl8ymsGVR
tz5CFn58GRVAVpCZmzQ7aHPQAorDMXt1xLvAdmlM4VG70mN7F8Y4WhOzpMtzDelo
n9hf2y9RogdaKW3Jt2681sLkTWmcX7zSQjZgCM7I+NGHIUUzV7wZ7vkBBqboJrWo
Nom/xsFqMCFd71fvokboKIcU8r7okIbcZJ89l8gfyAD1e6oOfofIU9Ct96QHCzCg
BIZWroZM/3/6xqZcWvukLTWLDJ0GrYHx+hGBn57t3DM7bhWLigQrP8Acv1mBWeTx
ZeFIqvgFCP1Wq/9QkX8ZVlZq0Ld65gzIaagWx0xgNUtl9TIn6aCCLSBoTH/yEcQL
II/vxIuw
=K+0J
-----END PGP SIGNATURE-----

Timestamp of file with hash e7ba304a85b944cadba0e04ee2a28cc21f95216aebcef175aa42c97cc0e2ad55 -

@fanquake fanquake requested a review from instagibbs April 11, 2021 02:13
instagibbs
instagibbs approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@instagibbs instagibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f79189c

@fanquake fanquake merged commit e358b43 into bitcoin:0.21 Apr 12, 2021
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@instagibbs instagibbs instagibbs approved these changes

@RonSherfey RonSherfey RonSherfey approved these changes

Assignees
No one assigned
Labels
Backport Wallet
Projects
None yet
Milestone
0.21.1
Development

Successfully merging this pull request may close these issues.
5 participants
@achow101 @maflcko @instagibbs @RonSherfey @fanquake