ACK if pulltester & gitian are happy with this.
Ahh.. without this non-default cflags break the build. Where'd pulltester go?
@TheBlueMatt can you force a pulltester run on this pullreq?
Although I think leveldb/libleveldb.a should probably depend on FORCE, so if bug-fixes are made to leveldb source files we don't have to make clean to pick up the changes.
@gavinandresen That sounds like a good idea to me. Shall I add it to this pullreq?
Amended to fix gitian spec to use standard CXXFLAGS for -frandom-seed
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/2effd4162b45a8e99529797e403efc05bf341864 for binaries and test log.
Testing this... doesn't fix the problem, the -Qt build is non-deterministic.
Also, I don't like the extensive changes to the leveldb/Makefile, it will make merging upstream changes harder.
I'm testing an alternative that cherry-picks some of the changes here, but doesn't touch anything in leveldb/ (passes CXXFLAGS in OPT; LDFLAGS is irrelevant, because we're building leveldb .a's).
Closing, mostly superceded by #2311
Bugfix: makefile.linux-mingw: Fix so passed CXXFLAGS/LDFLAGS work cor…
Reopening with one remaining fix that wasn't in #2311
Bugfix: makefile.unix: Honour BOOST_LIB_SUFFIX on boost_unit_test_fra…
Automatic sanity-testing: WARNING, see http://jenkins.bluematt.me/pull-tester/3a9c2d51e12fcf321daa78303e38c725b6477b66 for binaries and test log.
This pull decreases total test coverage, please add unit tests to test all new code and help us add test cases for existing code.
Coverage report can be found at http://jenkins.bluematt.me/pull-tester/3a9c2d51e12fcf321daa78303e38c725b6477b66/bitcoin/src/total.coverage/