LevelDB build bugfix #2243

Merged
merged 2 commits into from Apr 9, 2013

Projects

None yet

6 participants

@luke-jr
Member
luke-jr commented Jan 30, 2013
  • Bugfix: LevelDB: Use "xCXXFLAGS" variable to avoid user-defined CXXFLAGS from clobbering necessary compiler options
@sipa
Member
sipa commented Jan 30, 2013

ACK if pulltester & gitian are happy with this.

@gmaxwell
Member
gmaxwell commented Feb 5, 2013

Ahh.. without this non-default cflags break the build. Where'd pulltester go?

@sipa
Member
sipa commented Feb 5, 2013

@TheBlueMatt can you force a pulltester run on this pullreq?

@gavinandresen
Member

ACK.

Although I think leveldb/libleveldb.a should probably depend on FORCE, so if bug-fixes are made to leveldb source files we don't have to make clean to pick up the changes.

@luke-jr
Member
luke-jr commented Feb 5, 2013

@gavinandresen That sounds like a good idea to me. Shall I add it to this pullreq?

@luke-jr
Member
luke-jr commented Feb 9, 2013

Amended to fix gitian spec to use standard CXXFLAGS for -frandom-seed

@BitcoinPullTester

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/2effd4162b45a8e99529797e403efc05bf341864 for binaries and test log.

@gavinandresen
Member

Testing this... doesn't fix the problem, the -Qt build is non-deterministic.

Also, I don't like the extensive changes to the leveldb/Makefile, it will make merging upstream changes harder.

I'm testing an alternative that cherry-picks some of the changes here, but doesn't touch anything in leveldb/ (passes CXXFLAGS in OPT; LDFLAGS is irrelevant, because we're building leveldb .a's).

@luke-jr
Member
luke-jr commented Feb 16, 2013

Closing, mostly superceded by #2311

@luke-jr luke-jr closed this Feb 16, 2013
@luke-jr
Member
luke-jr commented Feb 19, 2013

Reopening with one remaining fix that wasn't in #2311

@luke-jr luke-jr reopened this Feb 19, 2013
@BitcoinPullTester

Automatic sanity-testing: WARNING, see http://jenkins.bluematt.me/pull-tester/3a9c2d51e12fcf321daa78303e38c725b6477b66 for binaries and test log.

This pull decreases total test coverage, please add unit tests to test all new code and help us add test cases for existing code.
Coverage report can be found at http://jenkins.bluematt.me/pull-tester/3a9c2d51e12fcf321daa78303e38c725b6477b66/bitcoin/src/total.coverage/

@jgarzik
Member
jgarzik commented Apr 9, 2013

ACK

@gavinandresen gavinandresen merged commit f49992d into bitcoin:master Apr 9, 2013
@luke-jr luke-jr deleted the luke-jr:bugfix_leveldb branch Oct 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment