consensus: move amount.h into consensus #22951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Sep 11, 2021
|
Concept ACK. I think this is organizationally the right thing to do. Nearly everything in
Even |
fanquake
force-pushed
the
move_amount_h_consensus
branch
from
166ed04
to
3cc3e89
Compare
This was referenced Sep 18, 2021
fanquake
force-pushed
the
move_amount_h_consensus
branch
from
3cc3e89
to
2c1554a
Compare
|
Concept ACK. |
hebasto
approved these changes
Sep 25, 2021
There was a problem hiding this comment.
ACK 2c1554a.
I see the last two commits as a way to modernize amount.h. Here are some additional suggestions:
- use type alias instead of
typedef - use separators for integer literals
- s/
nValue/value/ to follow our name convention - pass
CAmountas a non-reference parameter: s/const CAmount&/CAmount/. Also refactor: pass CTxMemPool and CFeeRate in-param objects by const reference #23076 (comment).
|
Concept ACK |
Move amount.h to consensus/amount.h. Renames, adds missing and removes uneeded includes.
fanquake
force-pushed
the
move_amount_h_consensus
branch
from
2c1554a
to
9d0379c
Compare
This was referenced Sep 30, 2021
|
concept ACK 9d0379c 🏝 Show signature and timestampSignature: Timestamp of file with hash |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 5, 2021
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 10, 2022
Summary: Move amount.h to consensus/amount.h. Renames, adds missing and removes uneeded includes. Also make MAX_MONEY constexpr This is a backport of [[bitcoin/bitcoin#22951 | core#22951]] Test Plan: `ninja all check-all bitcoin-fuzzers bench-bitcoin` `grep -r "<amount.h>" src/` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D12164
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first step (of a few) towards some source code reorganization, as well as making libbitcoinconsensus slightly more self contained.
Related to #15732.