Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use {Read,Write}BE32 helpers for BIP32 nChild (de)serialization #23199

Conversation

theStack
Copy link
Contributor

@theStack theStack commented Oct 5, 2021

This small refactoring PR replaces manual bit-fiddling (de)serialization of the BIP32 child number (nChild) by the helpers ReadBE32/WriteBE32. Note that those were first introduced in #4100, almost one year after the BIP32 derivation implementation has been merged (#2829, eb2c999).

@sipa
Copy link
Member

sipa commented Oct 5, 2021

utACK 7fc487a

@practicalswift
Copy link
Contributor

Concept ACK

@laanwj
Copy link
Member

laanwj commented Oct 7, 2021

Code review ACK 7fc487a
Checked that all changed sequences match big-endian behavior.

@fanquake fanquake merged commit 829d3e0 into bitcoin:master Oct 11, 2021
@theStack theStack deleted the 202110-refactor-use_be32_helpers_for_bip32_nchild branch October 11, 2021 06:30
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Oct 11, 2021
…32 nChild (de)serialization

7fc487a refactor: use `{Read,Write}BE32` helpers for BIP32 nChild (de)serialization (Sebastian Falbesoner)

Pull request description:

  This small refactoring PR replaces manual bit-fiddling (de)serialization of the BIP32 child number (nChild) by the helpers `ReadBE32`/`WriteBE32`. Note that those were first introduced in bitcoin#4100, almost one year _after_ the BIP32 derivation implementation has been merged (bitcoin#2829, eb2c999).

ACKs for top commit:
  sipa:
    utACK 7fc487a
  laanwj:
    Code review ACK 7fc487a

Tree-SHA512: bbe3e411fb0429fa74c8a5705a91f4d6ed704dac9d6623ecb633563f22acf8e21f3189a16f1d0cf1aeedfc56a5b695df54ae51e9577e34eb6d7dc335de2da6de
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Mar 13, 2022
…32 nChild (de)serialization

7fc487a refactor: use `{Read,Write}BE32` helpers for BIP32 nChild (de)serialization (Sebastian Falbesoner)

Pull request description:

  This small refactoring PR replaces manual bit-fiddling (de)serialization of the BIP32 child number (nChild) by the helpers `ReadBE32`/`WriteBE32`. Note that those were first introduced in dashpay#4100, almost one year _after_ the BIP32 derivation implementation has been merged (dashpay#2829, eb2c999).

ACKs for top commit:
  sipa:
    utACK 7fc487a
  laanwj:
    Code review ACK 7fc487a

Tree-SHA512: bbe3e411fb0429fa74c8a5705a91f4d6ed704dac9d6623ecb633563f22acf8e21f3189a16f1d0cf1aeedfc56a5b695df54ae51e9577e34eb6d7dc335de2da6de
@bitcoin bitcoin locked and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants