Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: Differential fuzzing for ChaCha20Forward4064-Poly1305@bitcoin cipher suite #23441

Closed
wants to merge 4 commits into from

Conversation

stratospher
Copy link
Contributor

This PR does an alternate implementation of the ChaCha20Forward4064-Poly1305@bitcoin cipher suite according to the new specification proposed in BIP 324. It performs differential fuzzing in order to ensure that the outputs obtained from #20962 and the alternate implementation are consistent.

The alternate implementation was successfully tested with the ChaCha20Poly1305@Bitcoin AEAD's test vectors in this branch. The first two commits in this PR are from #20962.

@DrahtBot
Copy link
Contributor

DrahtBot commented Nov 5, 2021

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #24203 (doc: Fix typos pointed out by lint-spelling by brunoerg)
  • #23233 (BIP324: Add encrypted p2p transport {de}serializer by dhruv)
  • #20962 (Alter the ChaCha20Poly1305@Bitcoin AEAD to the new specification by jonasschnelli)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot
Copy link
Contributor

🐙 This pull request conflicts with the target branch and needs rebase.

Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".

@DrahtBot
Copy link
Contributor

There hasn't been much activity lately and the patch still needs rebase. What is the status here?
  • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
  • Is it no longer relevant? ➡️ Please close.
  • Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

@achow101
Copy link
Member

Are you still working on this?

@stratospher
Copy link
Contributor Author

Closing this PR since this has been replaced with a better AEAD with formal security analysis in BIP 324.

And if anyone's interested in differential fuzzing(feel free to reach out!), I am working on fuzz testing python and cpp implementations of cryptography used in BIP 324 outside this repository. This would be a stronger test compared to the one in the PR since different programming languages are involved. See #23915.

@sipa sipa mentioned this pull request Sep 8, 2023
43 tasks
@bitcoin bitcoin locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

6 participants