Add getdeploymentinfo RPC #23508

ajtowns · 2021-11-14T01:29:59Z

The aim of this PR is to improve the ability to monitor soft fork status. It first moves the softfork section from getblockchaininfo into a new RPC named getdeploymentinfo, which is then also able to query the status of forks at an arbitrary block rather than only at the tip. In addition, bip9 status is changed to indicate the status of the given block, rather than just for the next block, and an additional field is included to indicate whether each block in the signalling period signaled.

ajtowns · 2021-11-14T01:39:43Z

Example output:

$ ./bitcoin-cli getdeploymentinfo 000000000000000000013712fc242ee6dd28476d0e9c931c75f83e6974c6bccc | jq .hash,.height,.deployments.taproot
"000000000000000000013712fc242ee6dd28476d0e9c931c75f83e6974c6bccc"
709631
{
  "type": "bip9",
  "height": 709632,
  "active": true,
  "bip9": {
    "bit": 2,
    "start_time": 1619222400,
    "timeout": 1628640000,
    "since": 687456,
    "min_activation_height": 709632,
    "status": "locked_in",
    "status-next": "active",
    "statistics": {
      "period": 2016,
      "elapsed": 2016,
      "count": 1891
    },
    "signalling": "#########-######-######################################-####################-###################################-##################################################-##################-############################################-#######-#####################-#########-#######################################-########-#######-##################-######-#################-####################-###########-#########################-##########-######################################-#####-###########-####-###############################-##-###-#############-###-########-###########-#######-#-##################--########################-############-#####-###########-###-################-####################################-###-#####-###############-#######################-######################-###########################################################-#-#-#######################-######-########################-##########-####################-####################-################--##-#######################-#########-############-#####-#######################-#############-#####################-##################-##########-####-####-############-#######-#########-##################################################-#############################-###############-######################-#####-###########################-##-##-######-########################-#########-##-##################-######################-########################################-####-########################-#########################################################################-####-########-#####-#######################-##########-##########-########################-#-######################################-#############-####-#####-##############-#-############-#############-###-######-##################-############################-########-#########-########-#######-############################################-#-#######################################-#-###########-########-##########-############-##########-#########"
  }
}
$ ./bitcoin-cli getdeploymentinfo $(./bitcoin-cli getblockhash 683423) | jq '.deployments.taproot'
{
  "type": "bip9",
  "active": false,
  "bip9": {
    "bit": 2,
    "start_time": 1619222400,
    "timeout": 1628640000,
    "since": 681408,
    "min_activation_height": 709632,
    "status": "started",
    "status-next": "started",
    "statistics": {
      "period": 2016,
      "elapsed": 2016,
      "count": 823,
      "threshold": 1815,
      "possible": false
    },
    "signalling": 
        "--------------------------------------------------#------------------------------------------------------#------------------#----------#------##
         ----#-----#---#--#-----#-------#----#------#---###----##----#---#--------#---#-#--------#----##-#----#------------------###--####-----------#---
         #-#----##-------#----#-----#-#-#--##---#-#---##-#-#-##---#---------#-----#---------------##---#---#---##--#----#--#---#--##-#--#----#------#-#--
         ##-##-----#---#--#-##--#-#####---#-#--##---#-#-#----#-----#----#---#-#-#-##--###----#-#----####--###--#-----#-####--####--##-#-##----#----#----#
         #-#--#####---#-#-#--##-#--###-###-##--#-#---###-#----#-###-#----####--#---############---#--#-####-----####------#-#--###--##-#-#---########-#--
         #-#-#--###--###-----#--#--##-----#-###-###-####----#-#--#-##-#----#---#-######----#####-#---#---###-##--###-##----##-#####-#--#-###-#----###-##-
         ##--##---#-#-#-##-##-#-#--#--#-##--#-##-#-#####--#-#---#########----##-###-#-#-#-----###--#-##-#---##--#-###-----##-----#-##--###--#-##-###---#-
         ###-###-----##-#---#------#-###-##-#-##---#--#---#--#-##--###-##-##---#-#-#----#--#--#-#-##--#--#-###--###--#--#---#####----#--#---#####---#-##-
         ----###--##---#--##-#---##-#-------#---#--#-#---##-##---###----#-#-#---#-#---##---#-#-##--#-###--##--#------#-###--#-#---##----#####-#-----#-###
         #-#------###-##-###-------###----#----##-#--#--##----####-##--#-#-#-#-##--##----#--##-#-##--#--#-#-###-###---------####-#####--#--#--##-------##
         ---##--#--#-##-##---##-###-#----#----##-#-#---###-#--##--#---#-----#-#-#-----###-##-------#-#-####--##-####--####-#---#-#--##-#---#-##------#-#-
         -#--#-####-#------#-#-###-----##--##-##-#####-##-####--#----#---#---#-##-###-###-######------###--##---#----####-#------###-###-#------#####-##-
         ###-#-###-#--#--###--#####---##-#-#-#-#---#######-#-#---#-#----###-##----##-#-#-#-#-##-#-#--###-#-#-#####---#--#--##-----#----#-#-#----#-##-----
         -##---##--###---###--#-##--#--###-#-##-##--##-----#-#-##-#-#--#-#-#--#-##-##-##-#--######--#--##-#-#-#---##-##---#---###-#--#----##--#-#-#-#-##-"
  }
}

(signalling results split into sections of 144 blocks by hand so it's easier to see on github; 683423 is the last block in taproot's first signalling period)

DrahtBot · 2021-11-14T03:05:48Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#24032 (Refactor vDeployments setup to avoid uninitialized variables by ajtowns)
#22016 (rpc: add period_start to version bits statistics by Sjors)
#21702 (Implement BIP-119 Validation (CheckTemplateVerify) by JeremyRubin)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

maflcko · 2021-11-14T09:14:41Z

My first thought was that getchaintips already reports all chain "forks", so this won't be needed. Maybe this could be named deploymentinfo or so to avoid confusion with cutlery?

ajtowns · 2021-11-14T13:11:11Z

Changed from getforkinfo to getdeploymentinfo, since it seemed like a knife idea.

benthecarman · 2021-11-14T23:06:08Z

Concept ACK

this is really cool!

brunoerg

tACK 684821c (MacOS 11.3)

➜  bitcoin git:(ajtowns) ✗ ./src/bitcoin-cli getdeploymentinfo
{
  "*": {
    "hash": "00000000000001f0c73d20c4843c1eac8658b5f49e2d80032ff1feaeb543fe35",
    "height": 207120
  },
  "bip34": {
    "type": "buried",
    "active": false,
    "height": 227931
  },
  "bip66": {
    "type": "buried",
    "active": false,
    "height": 363725
  },
  "bip65": {
    "type": "buried",
    "active": false,
    "height": 388381
  },
  "csv": {
    "type": "buried",
    "active": false,
    "height": 419328
  },
  "segwit": {
    "type": "buried",
    "active": false,
    "height": 481824
  },
  "taproot": {
    "type": "bip9",
    "active": false,
    "bip9": {
      "start_time": 1619222400,
      "timeout": 1628640000,
      "since": 0,
      "min_activation_height": 709632,
      "status": "defined",
      "status-next": "defined"
    }
  }
}
➜  bitcoin git:(ajtowns) ✗ ./src/bitcoin-cli getdeploymentinfo | jq '."*", .taproot'
{
  "hash": "0000000000000228e53941db17bc6eb44079f4e1677f39eb8afc73335842da68",
  "height": 210280
}
{
  "type": "bip9",
  "active": false,
  "bip9": {
    "start_time": 1619222400,
    "timeout": 1628640000,
    "since": 0,
    "min_activation_height": 709632,
    "status": "defined",
    "status-next": "defined"
  }
}

Functional tests:

Outputs

➜  bitcoin git:(ajtowns) ✗ ./test/functional/feature_cltv.py
2021-11-15T10:58:34.803000Z TestFramework (INFO): Initializing test directory /var/folders/7j/m0yjzmhj4ys9jgl353v2mqph0000gn/T/bitcoin_func_test_0ijd3ade
2021-11-15T10:58:35.463000Z TestFramework (INFO): Mining 109 blocks
2021-11-15T10:58:35.536000Z TestFramework (INFO): Test that invalid-according-to-CLTV transactions can still appear in a block
2021-11-15T10:58:35.595000Z TestFramework (INFO): Test that blocks must now be at least version 4
2021-11-15T10:58:35.706000Z TestFramework (INFO): Test that invalid-according-to-CLTV transactions cannot appear in a block
2021-11-15T10:58:36.268000Z TestFramework (INFO): Test that a version 4 block with a valid-according-to-CLTV transaction is accepted
2021-11-15T10:58:36.384000Z TestFramework (INFO): Stopping nodes
2021-11-15T10:58:36.606000Z TestFramework (INFO): Cleaning up /var/folders/7j/m0yjzmhj4ys9jgl353v2mqph0000gn/T/bitcoin_func_test_0ijd3ade on exit
2021-11-15T10:58:36.606000Z TestFramework (INFO): Tests successful
➜  bitcoin git:(ajtowns) ✗ ./test/functional/feature_dersig.py
2021-11-15T10:58:43.438000Z TestFramework (INFO): Initializing test directory /var/folders/7j/m0yjzmhj4ys9jgl353v2mqph0000gn/T/bitcoin_func_test_83lf0cfx
2021-11-15T10:58:44.087000Z TestFramework (INFO): Mining 100 blocks
2021-11-15T10:58:44.185000Z TestFramework (INFO): Test that a transaction with non-DER signature can still appear in a block
2021-11-15T10:58:44.251000Z TestFramework (INFO): Test that blocks must now be at least version 3
2021-11-15T10:58:44.362000Z TestFramework (INFO): Test that transactions with non-DER signatures cannot appear in a block
2021-11-15T10:58:44.478000Z TestFramework (INFO): Test that a block with a DERSIG-compliant transaction is accepted
2021-11-15T10:58:44.590000Z TestFramework (INFO): Stopping nodes
2021-11-15T10:58:44.915000Z TestFramework (INFO): Cleaning up /var/folders/7j/m0yjzmhj4ys9jgl353v2mqph0000gn/T/bitcoin_func_test_83lf0cfx on exit
2021-11-15T10:58:44.915000Z TestFramework (INFO): Tests successful
➜  bitcoin git:(ajtowns) ✗ ./test/functional/rpc_blockchain.py
2021-11-15T10:58:52.598000Z TestFramework (INFO): Initializing test directory /var/folders/7j/m0yjzmhj4ys9jgl353v2mqph0000gn/T/bitcoin_func_test_x6_f3kdy
2021-11-15T10:58:53.138000Z TestFramework (INFO): Generate 200 blocks after the genesis block in ten-minute steps
2021-11-15T10:58:54.405000Z TestFramework (INFO): Test getblockchaininfo
2021-11-15T10:58:56.405000Z TestFramework (INFO): Test getdeploymentinfo
2021-11-15T10:58:56.406000Z TestFramework (INFO): Test getchaintxstats
2021-11-15T10:58:56.468000Z TestFramework (INFO): Test gettxoutsetinfo works for blockchain with just the genesis block
2021-11-15T10:58:56.642000Z TestFramework (INFO): Test gettxoutsetinfo returns the same result after invalidate/reconsider block
2021-11-15T10:58:56.741000Z TestFramework (INFO): Test gettxoutsetinfo hash_type option
2021-11-15T10:58:56.948000Z TestFramework (INFO): Test getblockheader
2021-11-15T10:58:56.952000Z TestFramework (INFO): Test getdifficulty
2021-11-15T10:58:56.952000Z TestFramework (INFO): Test getnetworkhashps
2021-11-15T10:58:56.953000Z TestFramework (INFO): Test stopping at height
2021-11-15T10:59:00.749000Z TestFramework (INFO): Test waitforblockheight
2021-11-15T10:59:00.991000Z TestFramework (INFO): Test that getblock with verbosity 1 doesn't include fee
2021-11-15T10:59:00.992000Z TestFramework (INFO): Test that getblock with verbosity 2 and 3 includes expected fee
2021-11-15T10:59:00.995000Z TestFramework (INFO): Test that getblock with verbosity 1 and 2 does not include prevout
2021-11-15T10:59:00.997000Z TestFramework (INFO): Test that getblock with verbosity 3 includes prevout
2021-11-15T10:59:00.998000Z TestFramework (INFO): Test that getblock with verbosity 2 and 3 still works with pruned Undo data
2021-11-15T10:59:00.998000Z TestFramework (INFO): Test getblock with invalid verbosity type returns proper error message
2021-11-15T10:59:01.154000Z TestFramework (INFO): Stopping nodes
2021-11-15T10:59:01.426000Z TestFramework (INFO): Cleaning up /var/folders/7j/m0yjzmhj4ys9jgl353v2mqph0000gn/T/bitcoin_func_test_x6_f3kdy on exit
2021-11-15T10:59:01.426000Z TestFramework (INFO): Tests successful
➜  bitcoin git:(ajtowns) ✗ ./test/functional/rpc_signrawtransaction.py
2021-11-15T10:59:13.712000Z TestFramework (INFO): Initializing test directory /var/folders/7j/m0yjzmhj4ys9jgl353v2mqph0000gn/T/bitcoin_func_test_k4wwnsd2
2021-11-15T10:59:16.139000Z TestFramework (INFO): Test valid raw transaction with one input
2021-11-15T10:59:16.140000Z TestFramework (INFO): Test script verification errors
2021-11-15T10:59:16.142000Z TestFramework (INFO): Test signing transaction to P2SH-P2WSH addresses without wallet
2021-11-15T10:59:17.743000Z TestFramework (INFO): Test with a P2PKH script as the witnessScript
2021-11-15T10:59:18.321000Z TestFramework (INFO): Test with a P2PK script as the witnessScript
2021-11-15T10:59:18.881000Z TestFramework (INFO): Test OP_1NEGATE (0x4f) satisfies BIP62 minimal push standardness rule
2021-11-15T10:59:18.882000Z TestFramework (INFO): Test correct error reporting when trying to sign a locked output
2021-11-15T10:59:19.810000Z TestFramework (INFO): Test signing a fully signed transaction does nothing
2021-11-15T10:59:20.496000Z TestFramework (INFO): Test signing a transaction containing a fully signed CSV input
2021-11-15T10:59:21.050000Z TestFramework (INFO): Test signing a transaction containing a fully signed CLTV input
2021-11-15T10:59:21.736000Z TestFramework (INFO): Stopping nodes
2021-11-15T10:59:22.606000Z TestFramework (INFO): Cleaning up /var/folders/7j/m0yjzmhj4ys9jgl353v2mqph0000gn/T/bitcoin_func_test_k4wwnsd2 on exit
2021-11-15T10:59:22.606000Z TestFramework (INFO): Tests successful

w0xlt

tACK 684821c on Ubuntu 21.10.

luke-jr

Should remain in getblockchaininfo, at least as deprecated, for now

ajtowns · 2021-12-02T05:31:50Z

Updated. -deprecatedrpc=softforks will retain the softforks info in getblockchaininfo. Also tweaked the getdeploymentinfo output.

laanwj · 2021-12-08T17:44:05Z

Concept ACK. I was first skeptical about moving this to a new RPC, but being able to pass in a block hash to evaluate the status as of an arbitrary block is a great idea.

src/rpc/blockchain.cpp

ajtowns · 2021-12-09T12:33:00Z

Rebased past #23703 and tweaked the commit descriptions slightly.

For testing on mainnet, the following little shell snippet shows some interesting block heights:

EARLY="0 1"
BURIED="227930 363724 388380 419327 481823"
TAPROOT="681406 681407 681408 681409 683423 685439 687455 689471 691487 693503 695519 697535 699551 701567 703583 705599 707615 709631 711647"
for a in $EARLY $BURIED $TAPROOT; do ./bitcoin-cli getdeploymentinfo $(./bitcoin-cli getblockhash $a); done | less

Note that "active": true indicates a soft fork is being applied as of the next block, hence the blocks above are 1 below the actual activation heights.

laanwj · 2021-12-09T17:25:53Z

Needs release note wrt deprecation.

src/versionbits.h

ajtowns · 2022-01-14T18:46:04Z

@Sjors okay, done that, and also deduplicated the help text between getblockchaininfo and getdeploymentinfo.

Sjors

tACK a380922

Small steps to making this stuff less confusing... (see also btcsuite/btcd#1700 (comment))

Sjors · 2022-01-14T20:41:47Z

src/rpc/blockchain.cpp

@@ -1605,8 +1607,18 @@ static RPCHelpMan getdeploymentinfo()
            LOCK(cs_main);
            CChainState& active_chainstate = chainman.ActiveChainstate();

-            const CBlockIndex* tip = active_chainstate.m_chain.Tip();
-            CHECK_NONFATAL(tip);
+            const CBlockIndex* tip;


7f15c18: this variable should probably be called block. I suggest also renaming the tip parameter of DeploymentInfo( and the active_chain_tip parameter of SoftForkDescPushBack to block

Agree, but leaving this for later

src/rpc/blockchain.cpp

fjahr

tACK a380922

Reviewed code and tested many historical statistics around the Taproot deployment.

src/versionbits.cpp

src/rpc/blockchain.cpp

laanwj · 2022-01-27T17:39:29Z

Code review and lightly tested ACK a380922

jonatack

WIP, reviewed the first 3 commits and the release note. A few minor comments to pick/choose.

jonatack · 2022-01-27T16:43:31Z

src/rpc/blockchain.cpp

@@ -2716,6 +2807,7 @@ static const CRPCCommand commands[] =
    { "blockchain",         &getblockheader,                     },
    { "blockchain",         &getchaintips,                       },
    { "blockchain",         &getdifficulty,                      },
+    { "blockchain",         &getdeploymentinfo,                  },


fd82613 this line should perhaps be before getdifficulty, not sure, feel free to ignore

These aren't in alphabetical order, and I don't think it quite fits in with any of the other categories of functions (info about the tip, mempool stuff, stats, queries about a particular block; and the functions aren't really grouped by category anyway), so not seeing much benefit to moving it.

src/rpc/blockchain.cpp

jonatack · 2022-01-27T17:12:41Z

src/rpc/blockchain.cpp

+    return RPCHelpMan{"getdeploymentinfo",
+        "Returns an object containing various state info regarding soft-forks.",
+        {
+            {"blockhash", RPCArg::Type::STR_HEX, RPCArg::Default{"chain tip"}, "The block hash at which to query fork state"},


7f15c18 current naming style for new rpc arguments, and a default description that (maybe) looks a little less like "chain tip" could be a value

Arguments: 1. blockhash (string, optional, default="chain tip") The block hash at which to query fork state

Suggested change

{"blockhash", RPCArg::Type::STR_HEX, RPCArg::Default{"chain tip"}, "The block hash at which to query fork state"},

{"block_hash", RPCArg::Type::STR_HEX, RPCArg::Default{"value of chain tip"}, "The block hash at which to query fork state"},

It would be good to have tests for invoking getdeploymentinfo with a valid and an invalid block hash.

This code is reused in the deprecated getblockchaininfo part, so let's not rename these things. Except for new items.

~~Oh that's true; the functionality is nicely reused.~~ Correcting myself, the argument is only in the new RPC, so it could follow current naming style.

Ugh, why are we introducing new naming styles that are incompatible with the existing names, especially where they're part of an API? 🤮

doc/release-notes-23508.md

src/rpc/blockchain.cpp

ajtowns · 2022-01-28T07:36:30Z

Opened #24187 for non-code-changing followups.

e5f0356 rpc/blockchain: rename getdeploymentinfo tip/active_chain_tip to blockindex (Anthony Towns) fbab43f rpc/blockchain: a constant craving (Anthony Towns) 5179656 trivial: comment tweaks (Anthony Towns) 32f04e6 rpc documentation improvements (Anthony Towns) 555eafa doc: getdeploymentinfo release notes tweaks (Anthony Towns) Pull request description: Documentation, comments and trivial code changes to followup bitcoin#23508. ACKs for top commit: Sjors: utACK e5f0356 Tree-SHA512: 4e854a8453588901edb887504f7bfa100cc32df2e99654a5e5970032a0bd63259ba0582479e15bc09ef4792c6672715007f89eb1a7b2d7e229433a678cde9f44

…haininfo a01b92a doc: add release notes about removal of the `deprecatedrpc=softforks` flag (Sebastian Falbesoner) 8c5533c rpc: remove deprecated "softforks" field from getblockchaininfo (Sebastian Falbesoner) Pull request description: Information on soft fork status has been moved from the `getblockchaininfo` RPC to the `getdeploymentinfo` RPC in #23508. The "softfork" result in `getblockchaininfo` was still available for 23.0 with the `-deprecatedrpc=softforks` configuration option, but this can be fully removed now for the next release (24.0). ACKs for top commit: shaavan: ACK a01b92a ajtowns: ACK a01b92a Tree-SHA512: 692d9d02fdf0b3c18376644a85b24b57efebf612738084c01ef47d47e41861e773688613a808e81f10ab6eec340de00eef96987a1e34d612aaf7f0a0b134d89e

…tblockchaininfo a01b92a doc: add release notes about removal of the `deprecatedrpc=softforks` flag (Sebastian Falbesoner) 8c5533c rpc: remove deprecated "softforks" field from getblockchaininfo (Sebastian Falbesoner) Pull request description: Information on soft fork status has been moved from the `getblockchaininfo` RPC to the `getdeploymentinfo` RPC in bitcoin#23508. The "softfork" result in `getblockchaininfo` was still available for 23.0 with the `-deprecatedrpc=softforks` configuration option, but this can be fully removed now for the next release (24.0). ACKs for top commit: shaavan: ACK a01b92a ajtowns: ACK a01b92a Tree-SHA512: 692d9d02fdf0b3c18376644a85b24b57efebf612738084c01ef47d47e41861e773688613a808e81f10ab6eec340de00eef96987a1e34d612aaf7f0a0b134d89e

In this commit, we add a check during normal node construction to see if the backend node supports Taproot. If it doesn't, then we want to shutdown and force the user to take note. To check if the node supports Taproot, we'll first try the normal getblockchaininfo call. If this works, cool, then we can rely on the value. If it doesn't, then we'll fall back to the getdeploymentinfo call which was added in a recent version of bitcoind [1]. Newer versions of bitcoind might also have this call, and the getblockchaininfo call, but not actually populate the softforks field [2]. In this case, we'll fall back, and we also account for the case when the getblockchaininfo RPC is removed all together. [1]: bitcoin/bitcoin#23508 [2]: bitcoin/bitcoin#25114 Fixes lightningnetwork#6773

a8250e3 doc: add release note about `/rest/deploymentinfo` (brunoerg) 5c96020 doc: add `/deploymentinfo` in REST-interface (brunoerg) 3e44bee test: add coverage for `/rest/deploymentinfo` (brunoerg) 9149703 rest: add `/deploymentinfo` (brunoerg) Pull request description: #23508 added a new RPC named `getdeploymentinfo`, it moved the softfork section from `getblockchaininfo` into this new one. In the REST interface, we have an endpoint named`/rest/chaininfo.json` (which refers to `getblockchaininfo`), so, this PR adds a new REST endpoint named `/deploymentinfo` which refers to `getdeploymentinfo`. You can use it by passing a block hash, e.g: '/rest/deploymentinfo/<BLOCKHASH>.json' or you can use it without passing a block hash to get the 'deploymentinfo' for the last block. ACKs for top commit: jonatack: re-ACK a8250e3 rebase-only since my last review at c65f82b achow101: ACK a8250e3 stickies-v: re-ACK a8250e3 Tree-SHA512: 0735183b6828d51a72ed0e2be5a09b314ac4693f548982c6e9adaa0ef07a55aa428d3b2d1b1de70b83169811a663a8624b686166e5797f624dcc00178b9796e6

a8250e3 doc: add release note about `/rest/deploymentinfo` (brunoerg) 5c96020 doc: add `/deploymentinfo` in REST-interface (brunoerg) 3e44bee test: add coverage for `/rest/deploymentinfo` (brunoerg) 9149703 rest: add `/deploymentinfo` (brunoerg) Pull request description: bitcoin#23508 added a new RPC named `getdeploymentinfo`, it moved the softfork section from `getblockchaininfo` into this new one. In the REST interface, we have an endpoint named`/rest/chaininfo.json` (which refers to `getblockchaininfo`), so, this PR adds a new REST endpoint named `/deploymentinfo` which refers to `getdeploymentinfo`. You can use it by passing a block hash, e.g: '/rest/deploymentinfo/<BLOCKHASH>.json' or you can use it without passing a block hash to get the 'deploymentinfo' for the last block. ACKs for top commit: jonatack: re-ACK a8250e3 rebase-only since my last review at c65f82b achow101: ACK a8250e3 stickies-v: re-ACK bitcoin@a8250e3 Tree-SHA512: 0735183b6828d51a72ed0e2be5a09b314ac4693f548982c6e9adaa0ef07a55aa428d3b2d1b1de70b83169811a663a8624b686166e5797f624dcc00178b9796e6

fanquake added the RPC/REST/ZMQ label Nov 14, 2021

ajtowns force-pushed the 202111-getforkinfo branch from 8202c88 to 9f5a6fd Compare November 14, 2021 01:41

DrahtBot mentioned this pull request Nov 14, 2021

Bury taproot deployment #23505

Closed

ajtowns force-pushed the 202111-getforkinfo branch 2 times, most recently from 4469411 to 8a48fe4 Compare November 14, 2021 05:05

This was referenced Nov 14, 2021

rpc: add period_start to version bits statistics #22016

Closed

Implement BIP-119 Validation (CheckTemplateVerify) #21702

Closed

ajtowns force-pushed the 202111-getforkinfo branch from 8a48fe4 to 684821c Compare November 14, 2021 13:02

ajtowns changed the title ~~Add getforkinfo RPC~~ Add getdeploymentinfo RPC Nov 14, 2021

brunoerg approved these changes Nov 15, 2021

View reviewed changes

w0xlt approved these changes Nov 18, 2021

View reviewed changes

DrahtBot mentioned this pull request Nov 18, 2021

scripted-diff: Use clang-tidy syntax for C++ named arguments #23545

Closed

luke-jr suggested changes Nov 30, 2021

View reviewed changes

ajtowns force-pushed the 202111-getforkinfo branch from 684821c to 797b853 Compare December 2, 2021 05:29

DrahtBot mentioned this pull request Dec 8, 2021

scripted-diff: Use named args in RPC docs #23703

Merged

fanquake reviewed Dec 9, 2021

View reviewed changes

src/rpc/blockchain.cpp Outdated Show resolved Hide resolved

DrahtBot added the Needs rebase label Dec 9, 2021

ajtowns force-pushed the 202111-getforkinfo branch from 797b853 to 4662cf3 Compare December 9, 2021 12:24

DrahtBot removed the Needs rebase label Dec 9, 2021

laanwj added the Needs release note label Dec 9, 2021

laanwj reviewed Dec 9, 2021

View reviewed changes

src/versionbits.h Outdated Show resolved Hide resolved

Release notes for getdeploymentinfo rpc

a380922

ajtowns force-pushed the 202111-getforkinfo branch from bf61392 to a380922 Compare January 14, 2022 18:39

Sjors approved these changes Jan 14, 2022

View reviewed changes

maflcko removed the Needs release note label Jan 20, 2022

maflcko reviewed Jan 20, 2022

View reviewed changes

src/rpc/blockchain.cpp Show resolved Hide resolved

fjahr reviewed Jan 21, 2022

View reviewed changes

src/versionbits.cpp Show resolved Hide resolved

src/rpc/blockchain.cpp Show resolved Hide resolved

jonatack reviewed Jan 27, 2022

View reviewed changes

This was referenced Jan 28, 2022

refactor: use braced init for integer literals instead of c style casts #23829

Merged

Followups for getdeploymentinfo #24187

Merged

maflcko merged commit d4e92d8 into bitcoin:master Jan 28, 2022

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jan 28, 2022

Merge bitcoin#23508: Add getdeploymentinfo RPC

bedd40f

theStack mentioned this pull request May 12, 2022

rpc: remove deprecated "softforks" field from getblockchaininfo #25114

Merged

brunoerg mentioned this pull request Jun 18, 2022

rest: add /deploymentinfo endpoint #25412

Merged

Roasbeef mentioned this pull request Aug 5, 2022

chainreg: shutdown if backend node doesn't support taproot lightningnetwork/lnd#6798

Merged

bitcoin locked and limited conversation to collaborators Jan 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add getdeploymentinfo RPC #23508

Add getdeploymentinfo RPC #23508

ajtowns commented Nov 14, 2021 •

edited

Loading

ajtowns commented Nov 14, 2021 •

edited

Loading

DrahtBot commented Nov 14, 2021 •

edited

Loading

maflcko commented Nov 14, 2021

ajtowns commented Nov 14, 2021

benthecarman commented Nov 14, 2021

brunoerg left a comment

w0xlt left a comment

luke-jr left a comment

ajtowns commented Dec 2, 2021

laanwj commented Dec 8, 2021

ajtowns commented Dec 9, 2021

laanwj commented Dec 9, 2021

ajtowns commented Jan 14, 2022

Sjors left a comment •

edited

Loading

Sjors Jan 14, 2022

ajtowns Jan 20, 2022

fjahr left a comment

laanwj commented Jan 27, 2022

jonatack left a comment

jonatack Jan 27, 2022

ajtowns Jan 28, 2022

jonatack Jan 27, 2022 •

edited

Loading

Sjors Jan 27, 2022 •

edited

Loading

jonatack Jan 27, 2022 •

edited

Loading

ajtowns Jan 28, 2022

ajtowns commented Jan 28, 2022

	{"blockhash", RPCArg::Type::STR_HEX, RPCArg::Default{"chain tip"}, "The block hash at which to query fork state"},
	{"block_hash", RPCArg::Type::STR_HEX, RPCArg::Default{"value of chain tip"}, "The block hash at which to query fork state"},

Add getdeploymentinfo RPC #23508

Add getdeploymentinfo RPC #23508

Conversation

ajtowns commented Nov 14, 2021 • edited Loading

ajtowns commented Nov 14, 2021 • edited Loading

DrahtBot commented Nov 14, 2021 • edited Loading

Conflicts

maflcko commented Nov 14, 2021

ajtowns commented Nov 14, 2021

benthecarman commented Nov 14, 2021

brunoerg left a comment

Choose a reason for hiding this comment

w0xlt left a comment

Choose a reason for hiding this comment

luke-jr left a comment

Choose a reason for hiding this comment

ajtowns commented Dec 2, 2021

laanwj commented Dec 8, 2021

ajtowns commented Dec 9, 2021

laanwj commented Dec 9, 2021

ajtowns commented Jan 14, 2022

Sjors left a comment • edited Loading

Choose a reason for hiding this comment

Sjors Jan 14, 2022

Choose a reason for hiding this comment

ajtowns Jan 20, 2022

Choose a reason for hiding this comment

fjahr left a comment

Choose a reason for hiding this comment

laanwj commented Jan 27, 2022

jonatack left a comment

Choose a reason for hiding this comment

jonatack Jan 27, 2022

Choose a reason for hiding this comment

ajtowns Jan 28, 2022

Choose a reason for hiding this comment

jonatack Jan 27, 2022 • edited Loading

Choose a reason for hiding this comment

Sjors Jan 27, 2022 • edited Loading

Choose a reason for hiding this comment

jonatack Jan 27, 2022 • edited Loading

Choose a reason for hiding this comment

ajtowns Jan 28, 2022

Choose a reason for hiding this comment

ajtowns commented Jan 28, 2022

ajtowns commented Nov 14, 2021 •

edited

Loading

ajtowns commented Nov 14, 2021 •

edited

Loading

DrahtBot commented Nov 14, 2021 •

edited

Loading

Sjors left a comment •

edited

Loading

jonatack Jan 27, 2022 •

edited

Loading

Sjors Jan 27, 2022 •

edited

Loading

jonatack Jan 27, 2022 •

edited

Loading