Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Clean up font size in main window for observed inconsistency in Mac OS #2361

Merged
merged 1 commit into from

4 participants

@L2G

This just changes the font size of the word "Wallet" from 11 to 13 points.

@BitcoinPullTester

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/1b7c9b064d97eedde4dc49c7380546a6a05e0e9c for binaries and test log.

@Diapolo

With fontsize 13 it is consistent with what other elemts? Sorry I don't get it ^^.

@L2G

"Wallet" at 11 points was smaller than "Recent transactions" at 13 points. It seemed like a typo, and when I changed it to 13 points, it looked nicer to me. I can post some before-and-after screenshots. (Not sure why I didn't, to be frank and honest.)

@Diapolo

Would be nice to see your screenies, as I seem to see something different :).

@laanwj
Owner

I think the problem is that "Wallet" has a fixed font size, whereas "Recent Transactions" has not. So, depending on your system font size, it may be either larger or smaller. Hardwiring it to 13 is not a general solution either. Maybe remove the font size override for wallet completely?

@Diapolo

I'm also for removing that special casing there. Perhaps it's sufficient to leave it just bold then.

@laanwj
Owner

Fine with me too. Or maybe a relative font size that is specified in em will work, like in CSS? Ie being able to say "I want this 1.2 times bigger than normal letters" would be nice.

@L2G

I'm happy with all of these ideas. I didn't realize "Wallet" was being set to an absolute size while other text was being set to a relative size. As the ticket title indicates, "consistency" is the key! :smile_cat:

@L2G

Here's the problem I was originally trying to fix. Note how "Wallet" on the left is smaller than "Recent transactions" on the right.

Screen shot demonstrating the original problem on Mac OS

@L2G

By the way, @laanwj, I'm looking at this in the design window in Qt Creator 2.6.2, and it looks like both labels specify a fixed point size. Moreover, I don't see how it's possible to define relative sizes.

I'm still very much a rookie with this Qt stuff, so your patience and understanding is appreciated. :grin: I'm just trying to help out from the Mac side.

@laanwj
Owner

If there is no way to set relative sizes (I don't know of one, either) I recommend removing all explicit font sizes from the xml. Setting absolute sizes is a bad idea these days.

@L2G

Sounds like there is a bigger discussion to be had here, with a broader scope than what this ticket covers.

@Diapolo

@L2G IMHO we can pull this if you just remove <pointsize>11</pointsize> from the .UI file instead of changing it to 13 :).

@L2G

OK, or I could create a new branch so you don't have an extra, vestigial commit in there.

@L2G

Here's how it looks on Mac without a font size specified for the "Wallet" label:

No font size for "Wallet"

@Diapolo

You can squash the 2 commits into one, so that you don't need to create a new branch.
Use git rebase origin -i when you are on this branch. You will then see the 2 commits an can replace pick for the first with reword and pick for the second with squash... just save then and edit the commit-msg and do an git push origin YourBranchName -f.

Edit: Is there no text on that progressbar on Mac? Never or just in your screenshot?

@Diapolo

If it is easier for you to create a new branch just do that and reference this old pull in the Github description of the new pull :).

@L2G

@Diapolo, are you talking about the progress message that says "Processed X blocks of transaction history"? That doesn't show up for me unless I hover over the sync status indicator in the lower-right corner; then it shows up as a tool tip.

@Diapolo

I was talking about the text on the blueish progressbar, which should read something like "x blocks remaining". Is that uncommon on Mac to have text on progressbars?

@Diapolo

ACK

@L2G

I think it's pretty uncommon. I don't know whether it's failing to show up because Qt won't do it or because someone just commented it out with #ifndef Q_OS_MAC like they did with the system tray icon ("status menu icon" in Apple parlance). I'd have to do some digging.

I have another idea for something to do with the progress bar anyway, so we could continue that discussion in that future ticket where it'll be more on topic.

UPDATE: See my new comment under #2103.

@BitcoinPullTester

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/15e9739f3b0c93ed7b9f076873a1c4b112f41894 for binaries and test log.
This is an automated test script which runs test cases on each commit every time is updated.
It, however, dies sometimes and fails to test properly, if you are waiting on a test, please check timestamps and if the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
and contact BlueMatt on freenode if something looks broken.

@laanwj laanwj merged commit a7cbb34 into bitcoin:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 28, 2013
  1. @L2G
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 1 deletion.
  1. +0 −1  src/qt/forms/overviewpage.ui
View
1  src/qt/forms/overviewpage.ui
@@ -49,7 +49,6 @@
<widget class="QLabel" name="label_5">
<property name="font">
<font>
- <pointsize>11</pointsize>
<weight>75</weight>
<bold>true</bold>
</font>
Something went wrong with that request. Please try again.