Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib: add achow101 to trusted keys #23798

Merged
merged 1 commit into from Dec 20, 2021

Conversation

achow101
Copy link
Member

For maintaining the wallet and psbt things

For maintaining the wallet and psbt things
@laanwj laanwj added the Tests label Dec 16, 2021
@jonatack
Copy link
Member

Concept/approach ACK

@laanwj
Copy link
Member

laanwj commented Dec 16, 2021

Concept ACK. Matches the key I have:

pub   rsa4096/0x17565732E08E5E41 2015-03-05 [SC] [expires: 2022-03-05]
      152812300785C96444D3334D17565732E08E5E41

ghost
ghost approved these changes Dec 16, 2021
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 33b5112

Verified the key with https://achow101.com/contact/

@0xB10C
Copy link
Contributor

0xB10C commented Dec 16, 2021

ACK on having achow101 as wallet maintainer.

Copy link
Contributor

@meshcollider meshcollider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 33b5112

I've verified this key in person at previous coredevs, and achow101 is a very logical replacement in the role, now I no longer have time. Thanks for volunteering Andrew!

@luke-jr
Copy link
Member

luke-jr commented Dec 17, 2021

Concept ACK (but please don't remove BDB support any time soon :p)

@MarcoFalke MarcoFalke removed the Tests label Dec 17, 2021
@S3RK
Copy link
Contributor

S3RK commented Dec 17, 2021

ACK on achow101 being wallet maintainer

@MarcoFalke
Copy link
Member

ACK (but please remove BDB asap, thx)

@ajtowns
Copy link
Contributor

ajtowns commented Dec 17, 2021

Concept ACK.

Key matches key in contrib/builder-keys/keys.txt. I don't expect achow to treat BDB removal particularly differently to any other (wallet-related) PR...

Copy link
Member

@darosior darosior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK 33b5112

Copy link
Contributor

@shaavan shaavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 33b5112

Verified the key with: https://achow101.com/contact/

@glozow
Copy link
Member

glozow commented Dec 17, 2021

concept ACK 33b5112

@michaelfolkson
Copy link
Contributor

ACK 33b5112

(conditional on bringing BDB back as a first class citizen)

(Joke. Congrats, well deserved)

@kiminuo
Copy link
Contributor

kiminuo commented Dec 17, 2021

ACK 33b5112

Congratulations.

Copy link
Member

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Contributor

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 33b5112

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 33b5112

$ gpg --refresh-keys
$ gpg --list-keys 152812300785C96444D3334D17565732E08E5E41
pub   rsa4096 2015-03-05 [SC] [expires: 2022-03-05]
      152812300785C96444D3334D17565732E08E5E41
uid           [ unknown] Andrew Chow (Official New Key) <achow101@gmail.com>
uid           [ unknown] Andrew Chow <achow101@yahoo.com>
uid           [ unknown] Andrew Chow <andrew@achow101.com>
uid           [ unknown] Andrew Chow <achow101-lists@achow101.com>
uid           [ unknown] Andrew Chow <achow101-github@achow101.com>
uid           [ unknown] Andrew Chow <achow101@pm.me>
uid           [ unknown] Andrew Chow <achow101@protonmail.com>
sub   rsa4096 2015-03-05 [E] [expires: 2022-03-05]

Copy link
Contributor

@Zero-1729 Zero-1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 33b5112

Agree on having achow101 as wallet maintainer.

Verified:

$ gpg --list-keys 152812300785C96444D3334D17565732E08E5E41
pub   rsa4096 2015-03-05 [SC] [expires: 2022-03-05]
      152812300785C96444D3334D17565732E08E5E41
uid           [ unknown] Andrew Chow (Official New Key) <achow101@gmail.com>
uid           [ unknown] Andrew Chow <achow101-github@achow101.com>
uid           [ unknown] Andrew Chow <achow101-lists@achow101.com>
uid           [ unknown] Andrew Chow <andrew@achow101.com>
uid           [ unknown] Andrew Chow <achow101@yahoo.com>
uid           [ unknown] Andrew Chow <achow101@pm.me>
uid           [ unknown] Andrew Chow <achow101@protonmail.com>
sub   rsa4096 2015-03-05 [E] [expires: 2022-03-05]

@jb55
Copy link
Contributor

jb55 commented Dec 17, 2021

ACK 33b5112

@gruve-p
Copy link
Contributor

gruve-p commented Dec 19, 2021

ACK 33b5112

@fanquake fanquake merged commit 8eeb4e9 into bitcoin:master Dec 20, 2021
14 of 15 checks passed
@meshcollider
Copy link
Contributor

Congratulations @achow101 🎉

@sipa
Copy link
Member

sipa commented Dec 20, 2021

Posthumous ACK 33b5112. The key matches the one I have in my keyring.

@bitcoin bitcoin locked and limited conversation to collaborators Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet