New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib: add achow101 to trusted keys #23798
Conversation
For maintaining the wallet and psbt things
|
Concept/approach ACK |
|
Concept ACK. Matches the key I have: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 33b5112
Verified the key with https://achow101.com/contact/
|
ACK on having achow101 as wallet maintainer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 33b5112
I've verified this key in person at previous coredevs, and achow101 is a very logical replacement in the role, now I no longer have time. Thanks for volunteering Andrew!
|
Concept ACK (but please don't remove BDB support any time soon :p) |
|
ACK on achow101 being wallet maintainer |
|
ACK (but please remove BDB asap, thx) |
|
Concept ACK. Key matches key in contrib/builder-keys/keys.txt. I don't expect achow to treat BDB removal particularly differently to any other (wallet-related) PR... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK 33b5112
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 33b5112
Verified the key with: https://achow101.com/contact/
|
concept ACK 33b5112 |
|
ACK 33b5112 (conditional on bringing BDB back as a first class citizen) (Joke. Congrats, well deserved) |
|
ACK 33b5112 Congratulations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 33b5112
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 33b5112
$ gpg --refresh-keys
$ gpg --list-keys 152812300785C96444D3334D17565732E08E5E41
pub rsa4096 2015-03-05 [SC] [expires: 2022-03-05]
152812300785C96444D3334D17565732E08E5E41
uid [ unknown] Andrew Chow (Official New Key) <achow101@gmail.com>
uid [ unknown] Andrew Chow <achow101@yahoo.com>
uid [ unknown] Andrew Chow <andrew@achow101.com>
uid [ unknown] Andrew Chow <achow101-lists@achow101.com>
uid [ unknown] Andrew Chow <achow101-github@achow101.com>
uid [ unknown] Andrew Chow <achow101@pm.me>
uid [ unknown] Andrew Chow <achow101@protonmail.com>
sub rsa4096 2015-03-05 [E] [expires: 2022-03-05]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 33b5112
Agree on having achow101 as wallet maintainer.
Verified:
$ gpg --list-keys 152812300785C96444D3334D17565732E08E5E41
pub rsa4096 2015-03-05 [SC] [expires: 2022-03-05]
152812300785C96444D3334D17565732E08E5E41
uid [ unknown] Andrew Chow (Official New Key) <achow101@gmail.com>
uid [ unknown] Andrew Chow <achow101-github@achow101.com>
uid [ unknown] Andrew Chow <achow101-lists@achow101.com>
uid [ unknown] Andrew Chow <andrew@achow101.com>
uid [ unknown] Andrew Chow <achow101@yahoo.com>
uid [ unknown] Andrew Chow <achow101@pm.me>
uid [ unknown] Andrew Chow <achow101@protonmail.com>
sub rsa4096 2015-03-05 [E] [expires: 2022-03-05]
|
ACK 33b5112 |
|
ACK 33b5112 |
|
Congratulations @achow101 |
|
Posthumous ACK 33b5112. The key matches the one I have in my keyring. |
For maintaining the wallet and psbt things