Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: testnet3 was not reset and is doing BIP30 checks again #23882

Merged
merged 1 commit into from
Jan 2, 2022

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Dec 27, 2021

No description provided.

@shaavan
Copy link
Contributor

shaavan commented Dec 28, 2021

@MarcoFalke

It would be of great help if you could provide some reference, through which we can verify this statement:

testnet3 was not reset and is doing BIP30 checks again

Thank You.

@maflcko
Copy link
Member Author

maflcko commented Dec 28, 2021

You can check that testnet3 was not reset by the mentioned block count by running getblockcount and then comparing the block height. Alternatively you can insert std::cout << ( pindex->nHeight >= BIP34_IMPLIES_BIP30_LIMIT ) << std::endl; and see what is printed for the tip.

Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa1a51c

Verified that the testnet3 chain has a height of >= 1983702 (as of writing this, the height is 2134101) and thus was not reset. On this chain, the BIP30 check is now always executed due to the second condition on this line being true:

if (fEnforceBIP30 || pindex->nHeight >= BIP34_IMPLIES_BIP30_LIMIT) {

@fanquake fanquake merged commit 6535772 into bitcoin:master Jan 2, 2022
@maflcko maflcko deleted the 2112-docBip30Testnet3 branch February 20, 2022 12:39
@bitcoin bitcoin locked and limited conversation to collaborators Feb 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants