Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p2p, contrib: add cjdns hardcoded seeds and update the i2p seeds #24166

Merged
merged 2 commits into from Feb 2, 2022
Merged

p2p, contrib: add cjdns hardcoded seeds and update the i2p seeds #24166

merged 2 commits into from Feb 2, 2022

Conversation

jonatack
Copy link
Contributor

@jonatack jonatack commented Jan 26, 2022 •
edited

This update targets the v23 release. Additional reliable CJDNS seeds, and feedback on the I2P seeds, is welcome. To verify src/chainparamsseeds.h locally, run:

contrib/seeds/generate-seeds.py contrib/seeds > src/chainparamsseeds.h

@jonatack
p2p, contrib: add cjdns hardcoded seeds
e533242
@jonatack
p2p, contrib: update i2p hardcoded seeds
bcc5676 
Remove unresponsive seeds, and add one that has been up for the past half year.
@laanwj
Copy link
Member

laanwj commented Jan 26, 2022

Code review ACK bcc5676
I've verified that the new I2P node is connectable, and that the generate-seeds output matches. Also, the new entries for CJDNS have the correct BIP155 network type (6). I did not try to connect to CJDNS nodes.

lsilva01
lsilva01 approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@lsilva01 lsilva01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK bcc5676

I successfully connected to the I2P address added in nodes_main.txt.
I also successfully connected to CJDNS node [fcc7:be49:ccd1:dc91:3125:f0da:457d:8ce]:8333, but not to [fc32:17ea:e415:c3bf:9808:149d:b5a2:c9aa]:8333.

@jonatack
Copy link
Contributor Author

jonatack commented Jan 27, 2022 •
edited

but not to [fc32:17ea:e415:c3bf:9808:149d:b5a2:c9aa]:8333

Thank you @lsilva01 -- can you please re-try connecting? I think I've fixed the issue.

@lsilva01
Copy link
Contributor

Sure. I am still getting the error connect() to [fc32:17ea:e415:c3bf:9808:149d:b5a2:c9aa]:8333 failed after wait: Permission denied (13).

@jonatack
Copy link
Contributor Author

Ok, resolved (thanks @vasild and @lsilva01 for testing), I have inbound CJDNS connections now.

@lsilva01
Copy link
Contributor

reACK. I confirm that I have successfully connected to all seeds added in this PR.

@laanwj laanwj merged commit df66923 into bitcoin:master Feb 2, 2022
@jonatack jonatack deleted the update-hardcoded-seeds branch February 2, 2022 18:43
@bitcoin bitcoin locked and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lsilva01 lsilva01 lsilva01 approved these changes

Assignees
No one assigned
Labels
Scripts and tools Validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonatack @laanwj @lsilva01 @DrahtBot