Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Simplify titles of tabs in main window #2428

Merged
merged 1 commit into from

5 participants

@r000n

Words in English language are more short than in other langs usually.
Tabs don't fits in line in Spanish/German/Russian when they has two words.
Wallet has limited functionality. It can send & receive coins. So we can
safely rename "Send coins" to "Send" and "Receive coins" to "Receive".
Address book is just user contacts.

This change is affects a translations.
Ported from Freicoin

src/qt/bitcoingui.cpp
@@ -188,7 +188,7 @@ void BitcoinGUI::createActions()
historyAction->setShortcut(QKeySequence(Qt::ALT + Qt::Key_4));
tabGroup->addAction(historyAction);
- addressBookAction = new QAction(QIcon(":/icons/address-book"), tr("&Address Book"), this);
+ addressBookAction = new QAction(QIcon(":/icons/address-book"), tr("&Contacts"), this);
@Diapolo
Diapolo added a note

IMHO Contacts is not what the Address Book really IS, so NACK to this one, I'm fine with the others though.

@burger2
burger2 added a note

I agree with Diapolo with Address Book it's a keeper!

@laanwj Owner
laanwj added a note

Agree with Diapolo. "Coins" is indeed unnecessary and ACK on removing it.

"Contacts" doesn't really make sense to me for financial sw. What it really is, is a list of past (or stored for future usage) recipient addresses. So "address book" is a pretty nice analogy. Then again there may be wisdom in completely moving it to the background as it encourages re-use, see also @gmaxwell's point in #2429 but that's for future discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@BitcoinPullTester

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/9940db0794c9a6acdb76406569ba6668ff732dde for binaries and test log.
This is an automated test script which runs test cases on each commit every time is updated.
It, however, dies sometimes and fails to test properly, if you are waiting on a test, please check timestamps and if the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
and contact BlueMatt on freenode if something looks broken.

@r000n

Probably, rename it to "Addresses"? If it's not a real address book :)

@r000n r000n Words in English language are more short than in other langs usually.
Tabs don't fits in line in Spanish/German/Russian when they has two words.
Wallet has limited functionality. It can send & receive coins. So we can
safely rename "Send coins" to "Send" and "Receive coins" to "Receive".
Address book is just stored addresses.
0de26d5
@laanwj
Owner

ACK

@Diapolo

ACK

@laanwj If you get this in today, I'll create another translations update for this. Also, I remember I asked about a better general translations process in line with release cycles and whether we should drop languages, that are below a certain percentage translated, what do you think?

@laanwj
Owner

@Diapolo yes I agree. Is 'updating translations' something that could be made part of the release process in doc/release-process.txt? I suppose so?

With regard to dropping translations, I don't know. I suppose below a certain % you could just as well have no translation. Do you know how other projects using transfex handle this, and if so what threshold they use?

@laanwj laanwj merged commit a977b8c into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 31, 2013
  1. @r000n

    Words in English language are more short than in other langs usually.

    r000n authored
    Tabs don't fits in line in Spanish/German/Russian when they has two words.
    Wallet has limited functionality. It can send & receive coins. So we can
    safely rename "Send coins" to "Send" and "Receive coins" to "Receive".
    Address book is just stored addresses.
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 3 deletions.
  1. +3 −3 src/qt/bitcoingui.cpp
View
6 src/qt/bitcoingui.cpp
@@ -167,14 +167,14 @@ void BitcoinGUI::createActions()
overviewAction->setShortcut(QKeySequence(Qt::ALT + Qt::Key_1));
tabGroup->addAction(overviewAction);
- sendCoinsAction = new QAction(QIcon(":/icons/send"), tr("&Send coins"), this);
+ sendCoinsAction = new QAction(QIcon(":/icons/send"), tr("&Send"), this);
sendCoinsAction->setStatusTip(tr("Send coins to a Bitcoin address"));
sendCoinsAction->setToolTip(sendCoinsAction->statusTip());
sendCoinsAction->setCheckable(true);
sendCoinsAction->setShortcut(QKeySequence(Qt::ALT + Qt::Key_2));
tabGroup->addAction(sendCoinsAction);
- receiveCoinsAction = new QAction(QIcon(":/icons/receiving_addresses"), tr("&Receive coins"), this);
+ receiveCoinsAction = new QAction(QIcon(":/icons/receiving_addresses"), tr("&Receive"), this);
receiveCoinsAction->setStatusTip(tr("Show the list of addresses for receiving payments"));
receiveCoinsAction->setToolTip(receiveCoinsAction->statusTip());
receiveCoinsAction->setCheckable(true);
@@ -188,7 +188,7 @@ void BitcoinGUI::createActions()
historyAction->setShortcut(QKeySequence(Qt::ALT + Qt::Key_4));
tabGroup->addAction(historyAction);
- addressBookAction = new QAction(QIcon(":/icons/address-book"), tr("&Address Book"), this);
+ addressBookAction = new QAction(QIcon(":/icons/address-book"), tr("&Addresses"), this);
addressBookAction->setStatusTip(tr("Edit the list of stored addresses and labels"));
addressBookAction->setToolTip(addressBookAction->statusTip());
addressBookAction->setCheckable(true);
Something went wrong with that request. Please try again.