Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add ci/scratch dir to .gitignore #24601

Merged
merged 1 commit into from Mar 21, 2022

Conversation

josibake
Copy link
Member

Not sure if I'm missing some context as to why this isn't already ignored?

@DrahtBot DrahtBot added the Tests label Mar 17, 2022
@hebasto
Copy link
Member

hebasto commented Mar 17, 2022

Not sure if I'm missing some context as to why this isn't already ignored?

Do you mean running ci/test_run_all.sh locally?

.gitignore Outdated Show resolved Hide resolved
@josibake
Copy link
Member Author

Not sure if I'm missing some context as to why this isn't already ignored?

Do you mean running ci/test_run_all.sh locally?

I am running ci/test_run_all.sh locally while working on a PR and was surprised that the scratch directory wasn't already ignored. Was wondering if there was a reason we need it to not be ignored, but seems like no.

@josibake
Copy link
Member Author

josibake commented Mar 18, 2022

force pushed to remove the comment per @MarcoFalke 's suggestion; git range-diff master edc8003 e10895d

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e10895d

.gitignore Outdated Show resolved Hide resolved
@josibake
Copy link
Member Author

josibake commented Mar 18, 2022

force pushed to add suggestion from @hebasto ; git range-diff master e10895d 7027595

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK 7027595, tested on Ubuntu 22.04.

@maflcko maflcko merged commit 75e34ed into bitcoin:master Mar 21, 2022
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 22, 2022
7027595 add ci/scratch dir to gitignore (josibake)

Pull request description:

  Not sure if I'm missing some context as to why this isn't already ignored?

ACKs for top commit:
  hebasto:
    re-ACK 7027595, tested on Ubuntu 22.04.

Tree-SHA512: 1f13041cb27cd3687619105ac1bb3af4c31d000fcd98e5f84160c34649de532fcd8b98cb8a5bed0ba68e25b3bb344f669ea3567b9c9d86cf73386ddf276f292e
@bitcoin bitcoin locked and limited conversation to collaborators Mar 21, 2023
@josibake josibake deleted the add-ci-scratch-gitignore branch January 26, 2024 10:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants