Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build, ci: add DEBUG_LOCKCONTENTION to --enable-debug and CI #24757

Merged

Conversation

jonatack
Copy link
Contributor

@jonatack jonatack commented Apr 4, 2022

  • Add DEBUG_LOCKCONTENTION flag to the --enable-debug configuration
  • Add DEBUG_LOCKCONTENTION to the native tsan CI task that contains DEBUG_LOCKORDER (verified that the CI has all logging categories enabled by default, except libevent and leveldb)
  • Update the developer notes that --enable-debug configures DEBUG_LOCKCONTENTION

Related to #24709.

@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 5, 2022

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@jonatack
Copy link
Contributor Author

Moving this out of draft.

@jonatack jonatack force-pushed the add-DEBUG_LOCKCONTENTION-to-enable-debug branch from 0bac4f9 to bd5dbc3 Compare May 20, 2022 10:49
@jonatack
Copy link
Contributor Author

Rebased.

Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fanquake fanquake merged commit bd57b4e into bitcoin:master May 25, 2022
@jonatack jonatack deleted the add-DEBUG_LOCKCONTENTION-to-enable-debug branch May 25, 2022 07:53
@laanwj laanwj removed this from Blockers in High-priority for review May 26, 2022
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 28, 2022
@bitcoin bitcoin locked and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants