Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove send to IP address and IP transactions support #253

Merged
merged 0 commits into from Sep 18, 2011

Conversation

Projects
None yet
4 participants
@laanwj
Copy link
Member

laanwj commented May 22, 2011

Remove send to IP transaction support, as it is insecure and would confuse users when used.

An IP is a terrible identifier as it does not identify a person or organization. Furthermore, man-in-the-middle attacks are trivial as the internet has no "proof that you have ip XXX" API. In the future address shortening services based on "user@domain" would be useful, but these will likely be based on third party APIs and not on this code.

  • Removes logic to accept transfers by IP
  • Removes UI logic to send transfers by IP (CSendingDialog). Entering an IP in the send box will always result in an error.

Discussion on forum: https://forum.bitcoin.org/index.php?topic=9334.0

@jgarzik

This comment has been minimized.

Copy link
Contributor

jgarzik commented Jun 14, 2011

ACK

and I think Gavin is in favor of this, too

@TheBlueMatt

This comment has been minimized.

Copy link
Contributor

TheBlueMatt commented Jul 2, 2011

NACK, it would appear code was ripped out of uibase.* without modifying the uiproject.fpb file meaning no one can edit the wxUI in the future.

@jgarzik

This comment has been minimized.

Copy link
Contributor

jgarzik commented Jul 13, 2011

Also, please update for latest changes (lots!). We wanted to pull wallet crypto first.

@laanwj

This comment has been minimized.

Copy link
Member Author

laanwj commented Jul 13, 2011

yeah I will, first have to get this wx dialog editor tooling

@gmaxwell

This comment has been minimized.

Copy link
Member

gmaxwell commented Jul 18, 2011

Aww. The removal of this would mean we can't run a lottery for nodes running the most recent version of bitcoin as an incentive to make people upgrade. :)

@laanwj

This comment has been minimized.

Copy link
Member Author

laanwj commented Jul 18, 2011

Wow, you probably hit upon the first actual useful application for send to
IP transactions. But watch out for people MITMing you to steal the
incentives :)

@gmaxwell

This comment has been minimized.

Copy link
Member

gmaxwell commented Jul 18, 2011

Well, if they are going to go through the trouble of setting up something that pretends to be a current node it would be easier to actually RUN a current node. The lottery could do some reasonable health checks too. :) Like make sure the winner can feed the block chain and forward a transaction.

@laanwj laanwj merged commit 7337b34 into bitcoin:master Sep 18, 2011

dexX7 added a commit to dexX7/bitcoin that referenced this pull request Sep 26, 2015

Merge pull request bitcoin#253
a4d3e9c Update unit test for crowdsale calculation (dexX7)
301b23e Bump DB version to 3, to trigger reparsing of transactions (dexX7)
575d4c7 Replace calculation for missing issuer bonus (dexX7)
1437b27 Add alternative format for calculateFractional (dexX7)
354b678 Move inflation of indivisible amounts into calculateFundraiser as uint256 (zathras-crypto)

deadalnix pushed a commit to deadalnix/bitcoin that referenced this pull request Jan 19, 2017

destenson pushed a commit to destenson/bitcoin--bitcoin that referenced this pull request Nov 18, 2017

Merge bitcoin#253: Backports for 2.3.1
9a23920 [Net] Update Checkpoints (Fuzzbawls)
dabec30 Add masternode network (ipv4/6 or Tor) to RPC (Fuzzbawls)
6fa6abf [RPC] Standardize RPC commands (Fuzzbawls)
6eb655a PR 241 correction (Mrs-X)
42f33a4 [core] fix payment disagreements, reduce log-verbosity (Mrs-X)
f6d26a7 Update money variables from int64_t to CAmount (amirabrams)
3f1165e Nullpointer reference fixed (Mrs-X)
2ab3bd0 [Debug Log] Increase verbosity of error-message (Mrs-X)
86bd1e7 [RPC] Make 'masternode status' more verbose (Mrs-X)

Tree-SHA512: d39a7adc9d7710fa519024c04a36fd2846319ed5b9f8c3ef6250d98db7ef58ae7d1654f55fb11038ec67a3b3ab25505f788fb97cc0003e7e697721cf1c512cb7

classesjack pushed a commit to classesjack/bitcoin that referenced this pull request Jan 2, 2018

Merge pull request bitcoin#253 from qtumproject/minsk-team/QTUMCORE-86
Change gas amounts to uint64_t. (Qtum Core / QTUMCORE-86)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.