Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove my key from trusted-keys #25568

Merged
merged 1 commit into from Jul 8, 2022
Merged

Remove my key from trusted-keys #25568

merged 1 commit into from Jul 8, 2022

Conversation

sipa
Copy link
Member

@sipa sipa commented Jul 7, 2022

No description provided.

@hebasto
Copy link
Member

hebasto commented Jul 7, 2022

Should the contrib/verify-commits/trusted-git-root be updated as well?

@instagibbs
Copy link
Member

verified that the key 133EAC179436F14A5CF1B794860FEB804E669320 is indeed the one I have in my keyring

@achow101
Copy link
Member

achow101 commented Jul 7, 2022

Should the contrib/verify-commits/trusted-git-root be updated as well?

I don't think so. @sipa's last merge predates the current trusted-git-root by more than a year.

@laanwj
Copy link
Member

laanwj commented Jul 7, 2022

Should the contrib/verify-commits/trusted-git-root be updated as well?

Let's see if the checks still pass.

Copy link
Contributor

@kristapsk kristapsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8cbeab4

@achow101
Copy link
Member

achow101 commented Jul 7, 2022

ACK 8cbeab4

The key removed is the same as the one in my keyring.

Let's see if the checks still pass.

We don't do verify-commits for PRs, so CI won't help here.

I've run verify-commits locally with the key removed and the current trusted-git-root and there were no issues.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8cbeab4

Verified the fingerprint from https://bitcoincore.org/en/contact/

Thank you for being a bitcoin core maintainer since May 2011. I have learn a lot of things reading your posts and will keep learning as you will still be active as a contributor.

An OP_RETURN tx for memories: https://mempool.space/tx/830e6cb9ae8a35efa23c1053db942db8abe7d3f362f6173638860ee7849507ae

@b3h3rkz
Copy link

b3h3rkz commented Jul 8, 2022

Thank you @sipa!

Beautiful OP_RETURN @1440000bytes 💯

@junderw
Copy link
Contributor

junderw commented Jul 8, 2022

ACK 8cbeab4

Thanks for everything @sipa and good luck on your future endeavors.

Copy link
Contributor

@Zero-1729 Zero-1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8cbeab4

Verified fingerprint matches the key in my keyring.

Thank you @sipa for all your work on core, and invaluable responses on bitcoin.stackexchange.

Best of wishes on your next chapter!

@maflcko maflcko merged commit 172823e into bitcoin:master Jul 8, 2022
@bitcoin bitcoin locked and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants