Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy: run clang-tidy in quiet mode #25713

Merged
merged 1 commit into from Jul 30, 2022
Merged

Conversation

fanquake
Copy link
Member

This should cut the amount of output by atleast half.

/opt/homebrew/opt/llvm/bin/clang-tidy --use-color -p=bitcoin bitcoin/src/wallet/test/fuzz/coinselection.cpp
278 warnings generated.
Suppressed 278 warnings (278 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

becomes

/opt/homebrew/opt/llvm/bin/clang-tidy --use-color -p=/bitcoin -quiet bitcoin/src/wallet/test/fuzz/coinselection.cpp
278 warnings generated.

See https://clang.llvm.org/extra/clang-tidy/.

--quiet
Run clang-tidy in quiet mode. This suppresses
printing statistics about ignored warnings and
warnings treated as errors if the respective
options are specified.

However the run-clang-tidy option is -quiet. See https://github.com/llvm/llvm-project/blob/f28c006a5895fc0e329fe15fead81e37457cb1d1/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py#L244.

ci/test/06_script_b.sh Outdated Show resolved Hide resolved
@jamesob
Copy link
Member

jamesob commented Jul 26, 2022

ACK be5f2ef

But I like Marco's suggestion as well.

@jamesob
Copy link
Member

jamesob commented Jul 29, 2022

Tidy failure with the new code looks good:
image

@fanquake
Copy link
Member Author

Tidy failure with the new code looks good:

Pushed to drop the failing commit.

@jamesob
Copy link
Member

jamesob commented Jul 29, 2022

ACK 3fe58a9

@@ -35,8 +35,9 @@ if [ "$RUN_FUNCTIONAL_TESTS" = "true" ]; then
fi

if [ "${RUN_TIDY}" = "true" ]; then
set -eo pipefail
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

time to rewrite this stuff to python? 🥲

@maflcko maflcko merged commit ab3db34 into bitcoin:master Jul 30, 2022
@fanquake fanquake deleted the shut_up_tidy branch July 30, 2022 07:29
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Aug 1, 2022
@bitcoin bitcoin locked and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants