p2p: update hardcoded mainnet seeds for 25.x #27488
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
jonatack
force-pushed
the
2023-04-hardcoded-seeds-update
branch
from
58279d0
to
feed529
Compare
|
cc @Emzy |
|
Bringing out of draft after finishing the manual seeds updates and taking review feedback. |
jonatack
changed the title
|
ACK feed529 |
|
What criteria is used to choose the manually selected nodes? |
Reachability, uptime, returned by getnodeaddresses (!IsTerrible), and service bit 1. Some are run by colleagues or known persons in the space, in some cases since a long time. |
|
sipa/bitcoin-seeder#92 and sipa/bitcoin-seeder#101 could simplify the process when done. |
That might be tangential to this pull but feel free to propose a concrete diff or a follow-up. |
|
cc @wiz |
jonatack
force-pushed
the
2023-04-hardcoded-seeds-update
branch
from
feed529
to
b330a66
Compare
|
Pushed an update that adds seeds from @wiz and colleagues. I was having issues connecting to some of them yesterday and got in touch. Infra on their end is being updated, and I was able to connect to all of them now. |
There was a problem hiding this comment.
ACK b330a66
Not 100% sure how to best test this, but I did the following:
I followed the steps described in contrib/seeds/README.md, the overall result is similar.
There are some differences (~60 in total) - I guess that's expected due to changed input data and asmap data from sipa's seeder.
$ python3 makeseeds.py -a asmap-filled.dat -s seeds_main.txt > nodes_main.txt
Loading asmap database "asmap-filled.dat"…Done.
Loading and parsing DNS seeds…Done.
IPv4 IPv6 Onion Pass
476234 75286 0 Initial
476234 75286 0 Skip entries with invalid address
476234 75286 0 After removing duplicates
11932 3808 0 Enforce minimal number of blocks
10003 2833 0 Require service bit 1
2922 833 0 Require minimum uptime
2873 815 0 Require a known and recent user agent
2847 809 0 Filter out hosts with multiple bitcoin ports
512 294 0 Look up ASNs and limit results per ASN and per net
I also made manual connections to some of the manually added tor, i2p and cjdns seeds, which worked well.
I think it's great that we now have a few more tor seeds than 11, which seemed rather low to me considering the large number of bitcoin nodes reachable via tor.
jonatack
force-pushed
the
2023-04-hardcoded-seeds-update
branch
from
b330a66
to
d8e3fcf
Compare
Credit to you, @mzumsande, for suggesting to me yesterday that we add more. I've repushed after pulling in 3cc989d from #26681 and re-running the steps in |
|
Needs rebase |
selected for reachability, uptime, and service bit 1
and make the steps in /contrib/seeds/README.md easier to copy-paste
Done. |
jonatack
force-pushed
the
2023-04-hardcoded-seeds-update
branch
from
d8e3fcf
to
31b1798
Compare
|
ACK 31b1798 I think we should reconsider how we do the tor, i2p, and cjdns seeds for the next release. |
|
reACK 31b1798 After running the (now bugfixed) script based on sipa's seeder data locally, I have fewer differences compared to my ACK from yesterday for IPv4/6. |
Update the hardcoded P2P network seeds for 25.x after updating the manual seeds and the generation script as necessary. Previous update was #25911.
The manual seeds are selected for reachability, uptime and service bit 1 and/or curated trusted peers. We need more Tor and CJDNS seeds and some of the current Tor and I2P seeds are no longer reachable.
Can be tested by following the steps in
contrib/seeds/README.mdand verifying the manual seeds by checking their presence and services in getnodeaddresses and/or connecting to them and checking their services with getpeerinfo and behavior with -netinfo.Tool output: