Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use docker image cache for "Win64 native [vs2022]" task #27771

Closed
wants to merge 1 commit into from

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented May 28, 2023

This PR aims to avoid intermittent network issues and speed up the "Win64 native [vs2022]" CI task by caching related to chocolately and vcpkg steps in the docker image cache.

@hebasto hebasto added the Tests label May 28, 2023
@DrahtBot
Copy link
Contributor

DrahtBot commented May 28, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK sipsorcery

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

No conflicts as of last run.

@hebasto hebasto marked this pull request as ready for review May 28, 2023 19:26
@DrahtBot DrahtBot mentioned this pull request May 29, 2023
16 tasks
@hebasto
Copy link
Member Author

hebasto commented Jun 13, 2023

Friendly ping @MarcoFalke and @sipsorcery :)

@maflcko
Copy link
Member

maflcko commented Jun 13, 2023

No objection to using the cache to avoid intermittent network issues. But the speedup was only ~2 minutes on a total runtime of 1 hour?

@hebasto
Copy link
Member Author

hebasto commented Jun 13, 2023

No objection to using the cache to avoid intermittent network issues. But the speedup was only ~2 minutes on a total runtime of 1 hour?

You're right. I've added "avoid intermittent network issues" to the PR description.

@sipsorcery
Copy link
Member

ACK 77551bc.

Seems like a good idea to me.

Won't the ci/windows_test_imagefile image be stored somewhere on the CI server for subsequent runs? I would have thought that would save more than 2 mins.

@maflcko
Copy link
Member

maflcko commented Jun 17, 2023

According to https://cirrus-ci.com/task/6075873112096768 the build took 5 min, so that is roughly the time you save. But with unit tests running for 10 min and functional tests for 40 min, it is saving not too much.

Avoiding intermittent network issues seems more useful.

@hebasto
Copy link
Member Author

hebasto commented Jun 23, 2023

Won't the ci/windows_test_imagefile image be stored somewhere on the CI server for subsequent runs? I would have thought that would save more than 2 mins.

Subsequent runs will use the cached image the same way as other jobs use the cached ci/test_image image now.

@hebasto
Copy link
Member Author

hebasto commented Jul 27, 2023

Closing in the light of #28098.

@hebasto hebasto closed this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants