New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Use docker image cache for "Win64 native [vs2022]" task #27771
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsNo conflicts as of last run. |
5e549cd
to
afafafc
Compare
afafafc
to
77551bc
Compare
Friendly ping @MarcoFalke and @sipsorcery :) |
No objection to using the cache to avoid intermittent network issues. But the speedup was only ~2 minutes on a total runtime of 1 hour? |
You're right. I've added "avoid intermittent network issues" to the PR description. |
ACK 77551bc. Seems like a good idea to me. Won't the |
According to https://cirrus-ci.com/task/6075873112096768 the build took 5 min, so that is roughly the time you save. But with unit tests running for 10 min and functional tests for 40 min, it is saving not too much. Avoiding intermittent network issues seems more useful. |
Subsequent runs will use the cached image the same way as other jobs use the cached |
Closing in the light of #28098. |
This PR aims to avoid intermittent network issues and speed up the "Win64 native [vs2022]" CI task by caching related to chocolately and vcpkg steps in the docker image cache.