Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix keys_to_multisig_script (P2MS) helper for n/k > 16 #28312

Merged
merged 3 commits into from
Jun 17, 2024

Commits on Jun 5, 2024

  1. test: fix keys_to_multisig_script (P2MS) helper for n/k > 16

    The helper assumes that the n and k values have to be provided as a
    single byte push operation, which is only possible for values up to 16.
    Fix that by passing the numbers directly to the CScript list, where it's
    automatically converted to minimally-encoded pushes (see class
    method `CScript.__coerce_instance`, branch `isinstance(other, int)`).
    
    In case of 17..20, this means that the data-pushes are done with two
    bytes using OP_PUSH1 (0x01), e.g. for n=20: 0x01,0x14
    theStack committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    0c41fc3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0570d2c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5cf0a1f View commit details
    Browse the repository at this point in the history