GUI: Receive: Remove option to reuse a previous address

[luke-jr]

This was justified by the need to "resent" an invoice, but now that we have the request history, that need should be gone.

[BitcoinPullTester]

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/1b7f5112a53bd24709ed79bf239b5820c5488437 for binaries and test log.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/
Contact BlueMatt on freenode if something looks broken.

[laanwj]

I added this option on purpose because I don't want to lose the older functionality of generating a QR code for previous addresses (which are not longer in the recent history).

IMO removing it would be blunting a tool just to avoid people cutting themselves in the foot on purpose privacy-wise.

[luke-jr]

@laanwj How about importing all previous "address book" entries into the requested payments history?

[laanwj]

Meh, that would import all people's previous addresses (which can be a lot for old wallets) as ugly payment requests with missing fields.

[laanwj]

Closing this for now, could be reopened at some point when deterministic wallets are implemented (then there is no excuse left to reuse addresses).

[luke-jr]

We have HD wallets now. Should this be reopened?

[luke-jr]

Rebased

[da2ce7]

I don't think that the feature of [reusing previous address] is needed if you have a HD wallet. However, should we still provide this option for those who have old wallet?

[jonasschnelli]

IMO the address reuse function should only be removed then CWallet::IsHDEnabled().

[jonasschnelli]

Any plans to reduce the feature to HD wallets only?

[TheBlueMatt]

Agree with @jonasschnelli, though I'm happy to do this anyway if we add an -upgradewallet for HD wallets and wait a release or two.