New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unused code #4183
remove unused code #4183
Conversation
Did some digging using git's pickaxe... ACK on removing:
NACK on removing:
Not sure:
|
Dropped the removal of functions under "NACK on removing" and "Not sure". Rebased against master. |
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/f40dbeedde3a6a73c13b0241258cf23248db1de1 for binaries and test log. |
f40dbee remove CPubKey::VerifyCompact( ) which is never used (Kamil Domanski) 28b6c1d remove GetMedianTime( ) which is never used (Kamil Domanski) 5bd4adc remove LookupHostNumeric( ) which is never used (Kamil Domanski) 595f691 remove LogException( ) which is never used (Kamil Domanski) f4057cb remove CTransaction::IsNewerThan which is never used (Kamil Domanski) 0e31e56 remove CWallet::AddReserveKey which is never used (Kamil Domanski)
The title is self-explanatory,
Obviously, you might want to keep some of those, so I'm waiting for feedback.