Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BIP62 rule 6 #5143

Merged
merged 3 commits into from Jan 8, 2015

Conversation

@sipa
Copy link
Member

commented Oct 25, 2014

No description provided.

@sipa sipa force-pushed the sipa:bip62c branch Oct 25, 2014

@laanwj

This comment has been minimized.

Copy link
Member

commented Oct 29, 2014

All but two of these commits were merged as part of #5065, rebase would be useful to limit review scope

@laanwj laanwj added the Validation label Oct 29, 2014

@sipa sipa force-pushed the sipa:bip62c branch Oct 29, 2014

@sipa

This comment has been minimized.

Copy link
Member Author

commented Oct 29, 2014

Rebased.

@TheBlueMatt

This comment has been minimized.

Copy link
Contributor

commented Oct 30, 2014

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

ACK commithash cb485502b7b7122a0bf1ff5b00541f4b4b6a164c
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJUUcJ4AAoJEIm7uGY+LmXOBQIQAIvVnIo0YyHqrnmjEJ/o1mYQ
0PeJtqB0fDm5WtUds7wzQSXR4ZmmdO1DYdxskDxuG+Y8E70uILCQKcq5bNY9C3ZO
PRd0rFHTRjdREkDURQOxFeSyFoiS+bgDi0Kki7o5RJaQXjvLwmPn8S1ChhWnpoAw
5SNhUrhY3e2W9uQ4US+HBu7NAWuBiLiUdYHrLF9F9F3TFZs3IvYZm7sKY4GI/9R1
HgPrfokilwjC5TFFgZc5kYw+5uSJzBFnlRDc38Vrt7VI0lQtdduUwaUfd/Y7hUju
nvsRfhsfvCaaxMNRQ0Dvaby+8wIIZ9L2AGq36aLGdXTD/Ij9H0TDlFOAOEXnsTll
hvd5MT5EjvAdPxVPPcYGMt2vPoYejXxYvZ4XG1zm0S2VvpHxgaT/lqNPYKsmtsSP
nOAFDgdEQrOduAE0VfQ1JeGdfARJkMLAA3llPnSnH8/vFTItouyjdu9CK0FjzUSA
XkXvgzOiAjREjtZ0Ea4N1HC1lG0XuMSiynPLcwai76qsesz2oB4NE7RNM9N1btij
b/Fv4XSFqELanZwhX5u5nh+Yzdk4Iuvspsaj8o/sugqTzsG0V4eR4HspZYhux/wi
Buey50WP09hPjXhgd5yuyME7VsaLvFkc/HJLSXNYYWPWydQBZwWtb8sc4axNoHym
dxiEy8cqfvRMqSYbfwVW
=ZYU1
-----END PGP SIGNATURE-----
@petertodd

This comment has been minimized.

Copy link
Contributor

commented Nov 10, 2014

ACK

Are we're not adding CLEANSTACK to the standard flags because of the pull-tester?

@sipa sipa force-pushed the sipa:bip62c branch Nov 19, 2014

@sipa

This comment has been minimized.

Copy link
Member Author

commented Nov 19, 2014

Rebased + added a commit to enforce it as standardness rule.

@petertodd

This comment has been minimized.

Copy link
Contributor

commented Nov 20, 2014

ACK, including making it standard.

@sipa sipa force-pushed the sipa:bip62c branch Nov 24, 2014

@sipa

This comment has been minimized.

Copy link
Member Author

commented Nov 24, 2014

Rebased.

sipa added 3 commits Oct 25, 2014
Add SCRIPT_VERIFY_CLEANSTACK (BIP62 rule 6)
Based on an earlier patch by Peter Todd, though the rules here are different
(P2SH scripts should not have a CLEANSTACK check before the P2SH evaluation).

@sipa sipa force-pushed the sipa:bip62c branch to da918ac Nov 25, 2014

@laanwj laanwj merged commit da918ac into bitcoin:master Jan 8, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Jan 8, 2015
Merge pull request #5143
da918ac Make SCRIPT_VERIFY_CLEANSTACK a standardness requirement (Pieter Wuille)
b6e03cc Add SCRIPT_VERIFY_CLEANSTACK (BIP62 rule 6) (Pieter Wuille)
ae4151b No semantic change: reuse stack variable in P2SH evaluation (Pieter Wuille)
@sipa sipa referenced this pull request Jan 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.