Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time offset into getpeerinfo output #5476

Merged
merged 2 commits into from Jan 2, 2015

Conversation

@paveljanik
Copy link
Contributor

commented Dec 15, 2014

This code extends getpeerinfo output with time offset of the node. The getpeerinfo help text is extended to describe the new variable.
Second commit brings this new info to the UI. The Debug window/Peers tab then looks like this (the new part is marked with purple arrow):
q
This helps to debug the nodes in the network and their time.

@paveljanik

This comment has been minimized.

Copy link
Contributor Author

commented Dec 15, 2014

When the time offset is 0, UI contains "0" now. It should be "0 s". Or "-"?

@paveljanik paveljanik force-pushed the paveljanik:timeoffset branch to 73caf47 Dec 15, 2014

@gmaxwell

This comment has been minimized.

Copy link
Contributor

commented Dec 15, 2014

I think it should be zero. Idea ACK.

@laanwj

This comment has been minimized.

Copy link
Member

commented Dec 16, 2014

Yes for zero it should be 0 s, for the sake of sanity let's report zero like all other values :)

I like the concept as well.

@paveljanik

This comment has been minimized.

Copy link
Contributor Author

commented Dec 16, 2014

It is "0 s" now. I do not like "0" because the typical usage (for me) is to scroll down the list of peers and watch their time offset and "0" distracts me, because the "s" letter disappeared. But this is minor nit...

@paveljanik

This comment has been minimized.

Copy link
Contributor Author

commented Dec 30, 2014

Anyone else?

@luke-jr

This comment has been minimized.

Copy link
Member

commented Jan 2, 2015

ACK, reviewed code and tested. Looks good.

@jgarzik

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2015

tested ACK

@sipa

This comment has been minimized.

Copy link
Member

commented Jan 2, 2015

Untested ACK

@laanwj laanwj merged commit 73caf47 into bitcoin:master Jan 2, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Jan 2, 2015
Merge pull request #5476
73caf47 Display time offset in the debug window's Peers tab (Pavel Janík)
26a6bae Add time offset to getpeerinfo output (Pavel Janík)

@paveljanik paveljanik deleted the paveljanik:timeoffset branch Jan 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.