New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore ability to display addresses in GUI #5861

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@luke-jr
Member

luke-jr commented Mar 6, 2015

This reverts commit bdba2dd (PR #4610). I don't understand why it was removed in the first place, and didn't get an answer on IRC when I inquired a week ago. But since the commit message states "no-one cares about" the option, it seems reasonable to restore it so long as it is cared about.

Note: This needs adapting if #5833 gets merged first. git will NOT detect the conflict.

@luke-jr luke-jr referenced this pull request Mar 6, 2015

Merged

GUI: Label fixups #5833

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 6, 2015

Member

NACK. See #4580 for rationale on removing this feature. Apart from you, I've heard no one complain about this.

Member

laanwj commented Mar 6, 2015

NACK. See #4580 for rationale on removing this feature. Apart from you, I've heard no one complain about this.

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Mar 6, 2015

Member

#4580 does not make sense. It states that "addresses are always displayed", but they aren't... right now there is no way to get them displayed.

Member

luke-jr commented Mar 6, 2015

#4580 does not make sense. It states that "addresses are always displayed", but they aren't... right now there is no way to get them displayed.

@fsb4000

This comment has been minimized.

Show comment
Hide comment
@fsb4000

fsb4000 Mar 8, 2015

Contributor

ACK

Contributor

fsb4000 commented Mar 8, 2015

ACK

@dgenr8

This comment has been minimized.

Show comment
Hide comment
@dgenr8

dgenr8 Mar 9, 2015

Contributor

@luke-jr On recent master, I see addresses in the transaction list. Have you tried a fresh wallet.dat?

Contributor

dgenr8 commented Mar 9, 2015

@luke-jr On recent master, I see addresses in the transaction list. Have you tried a fresh wallet.dat?

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Mar 9, 2015

Member

@dgenr8 No, I've read the code, and it does not show addresses in normal circumstances (ie, labels set).

Member

luke-jr commented Mar 9, 2015

@dgenr8 No, I've read the code, and it does not show addresses in normal circumstances (ie, labels set).

@fsb4000

This comment has been minimized.

Show comment
Hide comment
@fsb4000

fsb4000 Mar 9, 2015

Contributor

@dgenr8
there are no addresses, only labels...
addresses

Contributor

fsb4000 commented Mar 9, 2015

@dgenr8
there are no addresses, only labels...
addresses

@dgenr8

This comment has been minimized.

Show comment
Hide comment
@dgenr8

dgenr8 Mar 9, 2015

Contributor

@luke-jr I wonder if, like me, @kazcw has no labels, so he thought the option was broken. The property and tooltip text should read "Always display addresses in transaction list"

Contributor

dgenr8 commented Mar 9, 2015

@luke-jr I wonder if, like me, @kazcw has no labels, so he thought the option was broken. The property and tooltip text should read "Always display addresses in transaction list"

@laanwj laanwj added the GUI label Mar 9, 2015

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 9, 2015

Member

So from a UI perspective why would you want to see addresses in this list? Do they convey any meaning to you? It's like having a 'SHA256 hash' column in your mail client.

Member

laanwj commented Mar 9, 2015

So from a UI perspective why would you want to see addresses in this list? Do they convey any meaning to you? It's like having a 'SHA256 hash' column in your mail client.

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Mar 9, 2015

Member

@laanwj It occurs to me I have no good use case for it (I was trying to get a list of used addresses matching a given label term, which is something better done via RPC anyway and has no GUI value except when addresses have been reused). Leaving this open for now in case @fsb4000 has some better reason for it.

Member

luke-jr commented Mar 9, 2015

@laanwj It occurs to me I have no good use case for it (I was trying to get a list of used addresses matching a given label term, which is something better done via RPC anyway and has no GUI value except when addresses have been reused). Leaving this open for now in case @fsb4000 has some better reason for it.

@dgenr8

This comment has been minimized.

Show comment
Hide comment
@dgenr8

dgenr8 Mar 9, 2015

Contributor

Of course addresses convey meaning. They are the actual ID that is exchanged OOB between parties. I'm not going to read my private label to somebody when he claims he didn't receive payment.

Contributor

dgenr8 commented Mar 9, 2015

Of course addresses convey meaning. They are the actual ID that is exchanged OOB between parties. I'm not going to read my private label to somebody when he claims he didn't receive payment.

@fsb4000

This comment has been minimized.

Show comment
Hide comment
@fsb4000

fsb4000 Mar 10, 2015

Contributor

Another reason: If you have multiple addresses under one label. For example: donations. Different addresses for different projects, but one label. Of course, you can make a longer labels include a fuller description, but I do not really like long labels...

Contributor

fsb4000 commented Mar 10, 2015

Another reason: If you have multiple addresses under one label. For example: donations. Different addresses for different projects, but one label. Of course, you can make a longer labels include a fuller description, but I do not really like long labels...

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 10, 2015

Member

A while ago there was extensive discussion on the mailing list, that it was bad idea to expose addresses to the end user. This is in line with increasing usage of payment requests, and other innovation.

Of course there are some edge cases where you do want the address, but in that case you can click on the transaction to get full information (or even hover?). It seems pointless to show the address for every single transaction. So I'm closing this.

Member

laanwj commented Mar 10, 2015

A while ago there was extensive discussion on the mailing list, that it was bad idea to expose addresses to the end user. This is in line with increasing usage of payment requests, and other innovation.

Of course there are some edge cases where you do want the address, but in that case you can click on the transaction to get full information (or even hover?). It seems pointless to show the address for every single transaction. So I'm closing this.

@laanwj laanwj closed this Mar 10, 2015

@rebroad

This comment has been minimized.

Show comment
Hide comment
@rebroad

rebroad Mar 1, 2016

Contributor

utACK

Contributor

rebroad commented Mar 1, 2016

utACK

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Jun 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment