Restore ability to display addresses in GUI

[luke-jr]

This reverts commit bdba2dd (PR #4610). I don't understand why it was removed in the first place, and didn't get an answer on IRC when I inquired a week ago. But since the commit message states "no-one cares about" the option, it seems reasonable to restore it so long as it is cared about.

Note: This needs adapting if #5833 gets merged first. git will NOT detect the conflict.

[laanwj]

NACK. See #4580 for rationale on removing this feature. Apart from you, I've heard no one complain about this.

[luke-jr]

#4580 does not make sense. It states that "addresses are always displayed", but they aren't... right now there is no way to get them displayed.

[fsb4000]

ACK

[dgenr8]

@luke-jr On recent master, I see addresses in the transaction list. Have you tried a fresh wallet.dat?

[luke-jr]

@dgenr8 No, I've read the code, and it does not show addresses in normal circumstances (ie, labels set).

[fsb4000]

@dgenr8
there are no addresses, only labels...

[dgenr8]

@luke-jr I wonder if, like me, @kazcw has no labels, so he thought the option was broken. The property and tooltip text should read "Always display addresses in transaction list"

[laanwj]

So from a UI perspective why would you want to see addresses in this list? Do they convey any meaning to you? It's like having a 'SHA256 hash' column in your mail client.

[luke-jr]

@laanwj It occurs to me I have no good use case for it (I was trying to get a list of used addresses matching a given label term, which is something better done via RPC anyway and has no GUI value except when addresses have been reused). Leaving this open for now in case @fsb4000 has some better reason for it.

[dgenr8]

Of course addresses convey meaning. They are the actual ID that is exchanged OOB between parties. I'm not going to read my private label to somebody when he claims he didn't receive payment.

[fsb4000]

Another reason: If you have multiple addresses under one label. For example: donations. Different addresses for different projects, but one label. Of course, you can make a longer labels include a fuller description, but I do not really like long labels...

[laanwj]

A while ago there was extensive discussion on the mailing list, that it was bad idea to expose addresses to the end user. This is in line with increasing usage of payment requests, and other innovation.

Of course there are some edge cases where you do want the address, but in that case you can click on the transaction to get full information (or even hover?). It seems pointless to show the address for every single transaction. So I'm closing this.

[rebroad]

utACK