New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qt] support for persisted rpc console history #5891

Closed
wants to merge 2 commits into
base: master
from
Jump to file or symbol
Failed to load files and symbols.
+4 −4
Diff settings

Always

Just for now

Viewing a subset of changes. View all
Prev

[Qt] RPC console history: rename blacklist to filter

  • Loading branch information...
jonasschnelli committed Mar 14, 2015
commit d8a8f1b09d064304bc63014b347587a09695f0df
View
@@ -54,7 +54,7 @@ const struct {
};
//don't add private key handling cmd's to the history
const QStringList RPCConsole::historyBlacklist = QStringList() << "importprivkey" << "signrawtransaction" << "walletpassphrase" << "walletpassphrasechange" << "encryptwallet";
const QStringList RPCConsole::historyFilter = QStringList() << "importprivkey" << "signrawtransaction" << "walletpassphrase" << "walletpassphrasechange" << "encryptwallet";
/* Object for executing console RPC commands in a separate thread.
*/
@@ -447,9 +447,9 @@ void RPCConsole::on_lineEdit_returnPressed()
emit cmdRequest(cmd);
bool storeHistory = true;
foreach(QString blacklistedCmd, historyBlacklist)
foreach(QString unallowedCmd, historyFilter)
{
if(cmd.trimmed().startsWith(blacklistedCmd))
if(cmd.trimmed().startsWith(unallowedCmd))
storeHistory = false; break;
}
View
@@ -97,7 +97,7 @@ public slots:
ClientModel *clientModel;
QStringList history;
int historyPtr;
const static QStringList historyBlacklist;
const static QStringList historyFilter;
QString cmdBeforeBrowsing;
NodeId cachedNodeid;
};
ProTip! Use n and p to navigate between commits in a pull request.