Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
add key generation type #5916
A encrypted wallet can still hold keys which where created when the wallet was unencrypted.
This PR will add a 8bit-flags-int to the CKeyMetadata class.
If this gets conceptual ACKs id like to extend this to the UI level.
It's backward and forward compatible.
The 1byte flag added at the end of the CKeyMetadata serialization stream will be ignored when running (old) master-branch. Using a "new" wallet on a "old" bitcoind will still keep the key generation data because Metadata is somehow immutable (will only be created/changes when a key gets generated).
@jonasschnelli I'd go so far to say that this could be user defined, as even a
I don't really have a strong opinion either way on this, did you have a use case in mind?
edit: in terms of #3314, a bit flag would make sense.
added a commit
this pull request
Jun 27, 2016
Do we really need a minVersionBump for this change?
What about just detecting the change in the deserialization code?
But this would make the upgraded wallet no longer work with older versions of bitcoin-core (<0.13 if we would merge this for 0.13) even with the fact that older version are capable of handling the changed/new CKeyMetadata format. This sounds inefficient to me.