Clean up change computation in CreateTransaction.#5924
Merged
laanwj merged 1 commit intobitcoin:masterfrom Oct 1, 2015
Merged
Conversation
Contributor
|
How did you test this? |
Contributor
Author
|
Unit tests and |
domob1812
force-pushed
the
change-cleanup
branch
from
8f1c7b5 to
e9713e9
Compare
Compute the change directly as difference between the "requested" and the actual value returned by SelectCoins. This removes a duplication of the fee logic code.
Member
There was a problem hiding this comment.
Before
nChange = nValueIn - nValue - nSubtractFeeFromAmount?0:nFeeRet
After:
nChange = nValueIn - nValueToSelect
= nValueIn - (nValue + nSubtractFeeFromAmount?0:nFeeRet)
= nValueIn - nValue - nSubtractFeeFromAmount?0:nFeeRet
Looks good to me!
Member
|
ut/code review ACK |
laanwj
added a commit
that referenced
this pull request
Oct 1, 2015
835c122 Clean up change computation in CreateTransaction. (Daniel Kraft)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compute the change directly as difference between the "requested" and the actual value returned by
SelectCoins. This removes a duplication of the fee logic code.