Alter assumptions in CCoinsViewCache::BatchWrite #5967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // would have pulled it in at first GetCoins). | ||
| assert(it->second.flags & CCoinsCacheEntry::FRESH); | ||
| // The parent cache does not have an entry, while the child does | ||
| // We can ignore it if its both FRESH and pruned in the child |
|
Untested ACK, but the unit test should cover it. |
morcos
force-pushed
the
AllowIntermediateFlushes
branch
2 times, most recently
from
66a0d4f to
2f74184
Compare
|
Needed rebase (nit fixed) |
|
@morcos This needs an update/rebase? |
morcos
force-pushed
the
AllowIntermediateFlushes
branch
from
2f74184 to
143f846
Compare
|
rebased |
|
Code review & lightly tested ACK. |
Previously it would break if you flushed a parent cache while there was a child cache referring to it. This change will allow the flushing of parent caches.
morcos
force-pushed
the
AllowIntermediateFlushes
branch
from
143f846 to
072e2f8
Compare
|
This was rebased to modify the new unit test added from #6932 as well. |
Merged
laanwj
added a commit
that referenced
this pull request
Nov 27, 2015
072e2f8 Alter assumptions in CCoinsViewCache::BatchWrite (Alex Morcos)
random-zebra
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Aug 8, 2020
8025a2b Alter assumptions in CCoinsViewCache::BatchWrite (Alex Morcos) Pull request description: backports bitcoin#5967 > Previously it would break if you flushed a parent cache while there was a child cache referring to it. This change will allow the flushing of parent caches. > > It also modifies the unit test to include flushing of intermediate caches. ACKs for top commit: furszy: Tested with and without the fix, ACK 8025a2b Fuzzbawls: ACK 8025a2b Tree-SHA512: 101325b04a410916dac9ad32f490232ac935cd9cdabfad00606ac7875e53a4e22f5416d9807df29e5bc748891370a45c9a2e3aa2cef8e113a43e3f8e7fe8c275
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it would break if you flushed a parent cache while there was a child cache referring to it. This change will allow the flushing of parent caches.
It also modifies the unit test to include flushing of intermediate caches.