Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Alter assumptions in CCoinsViewCache::BatchWrite #5967
random-zebra added a commit to PIVX-Project/PIVX that referenced this pull request
Aug 8, 2020
8025a2b Alter assumptions in CCoinsViewCache::BatchWrite (Alex Morcos) Pull request description: backports bitcoin#5967 > Previously it would break if you flushed a parent cache while there was a child cache referring to it. This change will allow the flushing of parent caches. > > It also modifies the unit test to include flushing of intermediate caches. ACKs for top commit: furszy: Tested with and without the fix, ACK 8025a2b Fuzzbawls: ACK 8025a2b Tree-SHA512: 101325b04a410916dac9ad32f490232ac935cd9cdabfad00606ac7875e53a4e22f5416d9807df29e5bc748891370a45c9a2e3aa2cef8e113a43e3f8e7fe8c275
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.