re-enable wallet in autoprune #6057
Conversation
|
Nice! I'm glad you looked at this. The way you checked |
|
Right. I did ignore the fact that blocks are not fly in in order. Will change it to your proposed way of scanning backwards.
|
| else | ||
| return InitError(_("Can't run with a wallet in prune mode.")); | ||
| if (GetBoolArg("-rescan", false)) { | ||
| return InitError(_("Rescans are not possible in pruned mode. You might use -reindex which then download the whole blockchain again.")); |
There was a problem hiding this comment.
This message is unclear to me. Do you mean:
"Rescans are not possible in pruned mode. You will need to use -reindex which will download the whole blockchain again."?
There was a problem hiding this comment.
Thanks!
English is not my mother language and I always struggle with it.
Feel free to also correct/rewrite the other warnings and errors (as well as the code comments).
jonasschnelli
force-pushed
the
2015/04/autoprune_wallet
branch
from
37cf0f4
to
9c28a03
Compare
|
Fixed |
jonasschnelli
force-pushed
the
2015/04/autoprune_wallet
branch
2 times, most recently
from
81cfaf6
to
35d22de
Compare
|
Concept & code review ACK, but this definitely needs testing. |
|
Also applied an additional test during wallet catchup-rescan if the previous block has TXs but no data to be sure we have pruned this block. |
jonasschnelli
force-pushed
the
2015/04/autoprune_wallet
branch
2 times, most recently
from
3942591
to
3774c90
Compare
jonasschnelli
force-pushed
the
2015/04/autoprune_wallet
branch
from
3774c90
to
d36bee5
Compare
import functions could lead to a rescan beyond prune level
jonasschnelli
force-pushed
the
2015/04/autoprune_wallet
branch
from
d36bee5
to
7e6569e
Compare
|
Rebased. |
| else | ||
| return InitError(_("Can't run with a wallet in prune mode.")); | ||
| if (GetBoolArg("-rescan", false)) { | ||
| return InitError(_("Rescans are not possible in pruned mode. You will need to use -reindex which will download the whole blockchain again.")); |
There was a problem hiding this comment.
What prevents this error if the user has passed -reindex? In particular, a pruned node may not have the space for the whole blockchain, and may need to redownload it with pruning enabled.
(... btw, does -reindex actually work correctly with pruned data? I think last time I tried, it ignored blocks after the first missing one, and redownloaded/reappended them...)
|
utACK. |
7e6569e [squashme] improve/corrects prune mode detection test for required wallet rescans (Jonas Schnelli) 7a12119 [RPC] disable import functions in pruned mode (Jonas Schnelli) 3201035 [autoprune] allow wallet in pruned mode (Jonas Schnelli)
7e6569e [squashme] improve/corrects prune mode detection test for required wallet rescans (Jonas Schnelli) 7a12119 [RPC] disable import functions in pruned mode (Jonas Schnelli) 3201035 [autoprune] allow wallet in pruned mode (Jonas Schnelli)
Bitcoin 0.12 wallet PRs 1 Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6057 - bitcoin/bitcoin#6415 Part of #2074. Closes #3700.
No description provided.