Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
referenced this pull request
Apr 30, 2015
@sipa: Right. I would do so. To make use of sipa@134090b it would need some adaptation and some changes within
But the current solution (as it is in this PR) without a DummySignatorCreator class works well and basically adds only 8 lines of code.
The dummy sig business may be ugly, but it was introduced to avoid even uglier solutions to compute signature sizes: either having parallel byte accounting functioning (lots of duplicate hard-to-crosscheck code), or doing real signing then throwing away the result (requires wallet to be unlocked and is just wrong).