fundrawtransaction #6088

TheBlueMatt · 2015-04-30T20:54:24Z

This superceedes #5503 and #5524. I rewrote chunks of the first and largely rewrote the second, stealing test cases almost verbatim from both.

sipa · 2015-05-01T12:45:32Z

Could we have a DummySignatureCreator, instead of passing a dummy boolean to TransactionSignatureCreator?

sipa · 2015-05-01T12:50:28Z

I had to read the source code to guess what 'fAllowOtherInputs' means. Can you add a comment?

jonasschnelli · 2015-05-01T12:52:36Z

@sipa: I tried this ("DummySignatorCreator"). But somehow i stopped it because it was getting a inheritance mess. I can't actually remember why exactly.

sipa · 2015-05-01T12:55:38Z

@jonasschnelli Let me hack something up.

sipa · 2015-05-01T13:24:09Z

See https://github.com/sipa/bitcoin/commits/dummysig

jonasschnelli · 2015-05-01T14:11:22Z

@sipa: are you sure this would work also for P2SH Multisig inputs?

sipa · 2015-05-01T14:19:43Z

@jonasschnelli pretty sure, it should.

BaseSignatureCreator is about creating individual (DER+nHashType) signatures, and is called by ProduceSignature wherever necessary. For multisig/P2SH, it will be called multiple times as necessary.

jonasschnelli · 2015-05-01T17:05:51Z

@sipa: Right. I would do so. To make use of sipa@134090b it would need some adaptation and some changes within SignSignature(). I just tried but had some compiling/casting issues with the DummySignatureChecker class.

But the current solution (as it is in this PR) without a DummySignatorCreator class works well and basically adds only 8 lines of code.
But indeed its not that elegant as sipas proposal.

sipa · 2015-05-01T17:18:35Z

I'm fine with fixing it up afterwards.

jgarzik · 2015-05-02T16:02:35Z

Concept ACK - the dummy sig stuff is ugly and poops all over several function/method sigs

laanwj · 2015-05-06T08:07:26Z

The dummy sig business may be ugly, but it was introduced to avoid even uglier solutions to compute signature sizes: either having parallel byte accounting functioning (lots of duplicate hard-to-crosscheck code), or doing real signing then throwing away the result (requires wallet to be unlocked and is just wrong).

jonasschnelli · 2015-05-18T13:45:22Z

Needs rebase.

luke-jr · 2015-06-02T03:15:05Z

Dummy sign may be ugly, but it also would enable prompting the user with fee etc prior to passphrase being entered...

luke-jr · 2015-06-02T03:16:39Z

src/wallet/rpcdump.cpp

            "\nAdds an address or script (in hex) that can be watched as if it were in your wallet but cannot be used to spend.\n"
            "\nArguments:\n"
            "1. \"address\"          (string, required) The address\n"
            "2. \"label\"            (string, optional, default=\"\") An optional label\n"
            "3. rescan               (boolean, optional, default=true) Rescan the wallet for transactions\n"
+            "4. p2sh                 (boolean, optional, default=false) Add the P2SH version of the script as well\n"


This seems nonsensical. What is the use case?

TheBlueMatt · 2015-06-11T06:58:12Z

So it turns out the watch-only signing never worked anyway (it used the constant "0" for the public key when calculating size of pay-to-pubkey-hash txn), so I walked that back and watchonly-supporting fundrawtransaction will be a separate pull.

Some code stolen from Jonas Schnelli <jonas.schnelli@include7.ch>

2085895 fundrawtransaction tests (Jonas Schnelli) 21bbd92 Add fundrawtransaction RPC method (Matt Corallo) 1e0d1a2 Add FundTransaction method to wallet (Matt Corallo) 2d84e22 Small tweaks to CCoinControl for fundrawtransaction (Matt Corallo) 9b4e7d9 Add DummySignatureCreator which just creates zeroed sigs (Pieter Wuille)

btcdrak · 2015-06-23T22:57:03Z

ACK

laanwj · 2015-06-24T05:14:52Z

Tested ACK (which I forgot to post)

jonasschnelli · 2015-06-24T06:39:20Z

Post merge ACK

sipa · 2015-06-24T20:34:02Z

src/wallet/wallet.cpp

+    if (!CreateTransaction(vecSend, wtx, reservekey, nFeeRet, nChangePosRet, strFailReason, &coinControl, false))
+        return false;
+
+    if (nChangePosRet != -1)


Any reason for trying to guess the changes made by CreateTransaction, and applying those on the original, rather than just using the constructed result?

sipa · 2015-06-24T21:03:24Z

Posthumous untested ACK.

fc81158 [QA] Add test_change_position case to rpc_fundrawtransaction.py (random-zebra) dd35760 [QA] Add test_option_feerate to rpc_fundrawtransaction functional test (random-zebra) 5bca4f4 Add more clear interface for CoinControl.h regarding individual feerate (random-zebra) 169bc3b [RPC] add feerate option to fundrawtransaction (random-zebra) 87dbdf8 [QA] Test new options in rpc_fundrawtransaction functional test (random-zebra) bc9dc67 Add lockUnspents option to fundrawtransaction (random-zebra) a3ac191 Add change options to fundrawtransaction (random-zebra) 0c1f7ba Add strict flag to RPCTypeCheckObj (random-zebra) d655b42 Use CCoinControl selection in CWallet::FundTransaction (random-zebra) 76c8d54 [QA] Test watchonly addrs in fundrawtransaction tests (random-zebra) 134c5d2 Implement watchonly support in fundrawtransaction (random-zebra) 1b153e5 Update importaddress help to push its use to script-only (random-zebra) 7b4eb6d Add importpubkey method to import a watch-only pubkey (random-zebra) 816dabb Add p2sh option to importaddress to import redeemScripts (random-zebra) 60a20a4 Split up importaddress into helper functions (random-zebra) cbffa80 Add logic to track pubkeys as watch-only, not just scripts (random-zebra) 12b38b0 Add have-pubkey distinction to ISMINE flags (random-zebra) fab6556 Exempt unspendable transaction outputs from dust checks (random-zebra) ab407ff [Tests] Fix and enable fundrawtransaction functional tests (random-zebra) bc44ba0 [wallet] allow transaction without change if keypool is empty (random-zebra) a2f8071 [wallet] CreateTransaction: simplify change address check (random-zebra) 761e60e Add fundrawtransaction RPC method (random-zebra) ccb18dd Add FundTransaction method to wallet (random-zebra) 692b827 Add DummySignatureCreator which just creates zeroed sigs (random-zebra) Pull request description: based on top of - [x] #1662 This introduces a new wallet function, `CWallet::FundTransaction()` (and exposes it via RPC with `fundrawtransaction`), to fill a tx containing only vouts (or not enough vins to cover the vouts) with unspent coins from the wallet. `fundrawtransaction` will not modify existing inputs, and will add one change output (if needed) to the outputs. It will not sign the inputs (so can include also watch-only or multi-sig inputs, if enabled). backported from: - bitcoin#6088 - bitcoin#17219 [`*`] - bitcoin#6417 - bitcoin#6444 - bitcoin#6415 - bitcoin#6828 - bitcoin#7296 (only bebe58b) - bitcoin#7506 - bitcoin#7518 - bitcoin#7967 adapting the tests for the (more recent) framework. [`*`] Note: this has been included to be able to call `fundrawtransaction` without the need for an unencrypted wallet (for the change address key) ACKs for top commit: furszy: re ACK fc81158 . Fuzzbawls: ACK fc81158 Tree-SHA512: 10235ce6e672a1cfd4ae2cad9312864c82971f6a4aa1a8ed9489d85156f5c4126c293180a7f1b86b7c65d07caab484e9a6d7a87ebf032bee55adb98d3e08e7b9

d1d15c8 Fix missing sigverion in main_test.cpp CreateDummyScriptSigWithKey. (furszy) a034daf Rename to PrecomputedTransactionData (furszy) b4b181b Unit test for sighash caching (furszy) 2ef3872 Report non-mandatory script failures correctly. (furszy) 446d340 Precompute sighashes (furszy) dfd24eb Update wallet_txn_close.py test: (furszy) a5170f0 BIP143: Signing logic. (furszy) d2dd547 BIP143: Verification logic. (furszy) dccc3c6 Refactor script validation to observe amounts (furszy) daf044a Reduce unnecessary hashing in signrawtransaction (furszy) Pull request description: Base work for the new transaction digest algorithm for signature verification on PIVX Sapling transactions. Essentially, an implementation of BIP143 + few more good commits that found down the rabbit hole. Back ports: * bitcoin#7276 * bitcoin#7976 * bitcoin#8118 * bitcoin#8149 (only amount validation and SignatureHash commits). * bitcoin#6088 (only the dummy signature one - will be removed once #1663 get merged -). * bitcoin#6379 * bitcoin#8524 Next step over this area (need 1553 merged to be able to push it) is the further specialization of BIP143 into our custom implementation of ZIP143 (with a different digest algorithm definition using our tx data and hash personalization). ACKs for top commit: Fuzzbawls: utACK d1d15c8 random-zebra: ACK d1d15c8 and merging... Tree-SHA512: 7665cccf095c5bce0b18ef7ab8fcf7bede9304993b48f1af9c352c568861dec728d1d68671aab857b73d46567678492c4b97c24644a15f3f29fc4d723b183522

jonasschnelli mentioned this pull request Apr 30, 2015

[RPC] fundrawtransaction #5503

Closed

kanzure mentioned this pull request Apr 30, 2015

Implement watchonly for fundrawtransaction #5524

Closed

laanwj added Wallet RPC/REST/ZMQ labels May 1, 2015

laanwj added this to the 0.11.0 milestone May 1, 2015

laanwj removed this from the 0.11.0 milestone May 18, 2015

luke-jr reviewed Jun 2, 2015
View reviewed changes

TheBlueMatt force-pushed the frt2 branch 3 times, most recently from b96fcf6 to 3025e0d Compare June 11, 2015 07:31

sipa and others added 5 commits June 11, 2015 01:03

Add DummySignatureCreator which just creates zeroed sigs

9b4e7d9

Small tweaks to CCoinControl for fundrawtransaction

2d84e22

Add FundTransaction method to wallet

1e0d1a2

Some code stolen from Jonas Schnelli <jonas.schnelli@include7.ch>

Add fundrawtransaction RPC method

21bbd92

fundrawtransaction tests

2085895

TheBlueMatt force-pushed the frt2 branch from 3025e0d to 2085895 Compare June 11, 2015 08:03

laanwj merged commit 2085895 into bitcoin:master Jun 23, 2015

sipa reviewed Jun 24, 2015
View reviewed changes

TheBlueMatt mentioned this pull request Jul 10, 2015

Implement watchonly support in fundrawtransaction #6415

Merged

laanwj mentioned this pull request Feb 10, 2016

Add createtransaction #7498

Closed

str4d mentioned this pull request Feb 14, 2017

Bitcoin 0.12 RPC PRs 1 zcash/zcash#2100

Merged

dagurval mentioned this pull request Dec 27, 2017

Add fundrawtransaction bitcoinxt/bitcoinxt#288

Merged

random-zebra mentioned this pull request Jun 4, 2020

[Wallet][RPC] FundTransaction - fundrawtransaction PIVX-Project/PIVX#1663

Merged

1 task

furszy mentioned this pull request Jun 6, 2020

Base work for the Sapling signatureHash PIVX-Project/PIVX#1666

Merged

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fundrawtransaction #6088

fundrawtransaction #6088

TheBlueMatt commented Apr 30, 2015

sipa commented May 1, 2015

sipa commented May 1, 2015

jonasschnelli commented May 1, 2015

sipa commented May 1, 2015

sipa commented May 1, 2015

jonasschnelli commented May 1, 2015

sipa commented May 1, 2015

jonasschnelli commented May 1, 2015

sipa commented May 1, 2015 via email

jgarzik commented May 2, 2015

laanwj commented May 6, 2015

jonasschnelli commented May 18, 2015

luke-jr commented Jun 2, 2015

luke-jr Jun 2, 2015

TheBlueMatt commented Jun 11, 2015

btcdrak commented Jun 23, 2015

laanwj commented Jun 24, 2015

jonasschnelli commented Jun 24, 2015

sipa Jun 24, 2015

sipa commented Jun 24, 2015

fundrawtransaction #6088

fundrawtransaction #6088

Conversation

TheBlueMatt commented Apr 30, 2015

sipa commented May 1, 2015

sipa commented May 1, 2015

jonasschnelli commented May 1, 2015

sipa commented May 1, 2015

sipa commented May 1, 2015

jonasschnelli commented May 1, 2015

sipa commented May 1, 2015

jonasschnelli commented May 1, 2015

sipa commented May 1, 2015 via email

jgarzik commented May 2, 2015

laanwj commented May 6, 2015

jonasschnelli commented May 18, 2015

luke-jr commented Jun 2, 2015

luke-jr Jun 2, 2015

Choose a reason for hiding this comment

TheBlueMatt commented Jun 11, 2015

btcdrak commented Jun 23, 2015

laanwj commented Jun 24, 2015

jonasschnelli commented Jun 24, 2015

sipa Jun 24, 2015

Choose a reason for hiding this comment

sipa commented Jun 24, 2015