build: disable optional use of gmp in internal secp256k1 build#6210
Merged
laanwj merged 1 commit intobitcoin:masterfrom Jun 2, 2015
Merged
build: disable optional use of gmp in internal secp256k1 build#6210laanwj merged 1 commit intobitcoin:masterfrom
laanwj merged 1 commit intobitcoin:masterfrom
Conversation
Until secp256k1 is used for verification there is no reason for Bitcoin Core's secp256k1 to link against gmp, even if available. Pass a flag to configure to override the bignum implementation. This fixes a crash at runtime on ppc64 reported by @gmaxwell.
Member
Author
|
Needs to go into 0.11 branch as well |
Member
|
Nit: --without-bignum would be slightly nicer IMO |
Member
Author
|
@luke-jr No opinion on that, but I'm just following secp256k1's |
laanwj
added a commit
that referenced
this pull request
Jun 2, 2015
7fd5b80 build: disable optional use of gmp in internal secp256k1 build (Wladimir J. van der Laan)
Member
|
post-merge ack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until secp256k1 is used for verification there is no reason for Bitcoin Core's secp256k1 to link against gmp, even if available. Pass a flag to configure to override the bignum implementation.
This fixes a crash at runtime on ppc64 reported by @gmaxwell.
Edit: tested and appears to work, after autogen and reconfigure,
src/secp256k1/config.logcontains... whereas it was using gmp before.