Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: disable optional use of gmp in internal secp256k1 build #6210

Merged
merged 1 commit into from Jun 2, 2015

Conversation

@laanwj
Copy link
Member

@laanwj laanwj commented Jun 1, 2015

Until secp256k1 is used for verification there is no reason for Bitcoin Core's secp256k1 to link against gmp, even if available. Pass a flag to configure to override the bignum implementation.

This fixes a crash at runtime on ppc64 reported by @gmaxwell.

Edit: tested and appears to work, after autogen and reconfigure, src/secp256k1/config.log contains

configure:13140: Using bignum implementation: no

... whereas it was using gmp before.

Until secp256k1 is used for verification there is no reason for Bitcoin
Core's secp256k1 to link against gmp, even if available. Pass a flag to
configure to override the bignum implementation.

This fixes a crash at runtime on ppc64 reported by @gmaxwell.
@laanwj laanwj added the Build system label Jun 1, 2015
@laanwj
Copy link
Member Author

@laanwj laanwj commented Jun 1, 2015

Needs to go into 0.11 branch as well

@luke-jr
Copy link
Member

@luke-jr luke-jr commented Jun 1, 2015

Nit: --without-bignum would be slightly nicer IMO

@laanwj
Copy link
Member Author

@laanwj laanwj commented Jun 1, 2015

@luke-jr No opinion on that, but I'm just following secp256k1's configure --help

@laanwj laanwj merged commit 7fd5b80 into bitcoin:master Jun 2, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Jun 2, 2015
7fd5b80 build: disable optional use of gmp in internal secp256k1 build (Wladimir J. van der Laan)
laanwj added a commit that referenced this pull request Jun 2, 2015
Until secp256k1 is used for verification there is no reason for Bitcoin
Core's secp256k1 to link against gmp, even if available. Pass a flag to
configure to override the bignum implementation.

This fixes a crash at runtime on ppc64 reported by @gmaxwell.

Github-Pull: #6210
Rebased-From: 7fd5b80
@theuni
Copy link
Member

@theuni theuni commented Jun 2, 2015

post-merge ack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.