build: disable optional use of gmp in internal secp256k1 build #6210

Merged
merged 1 commit into from Jun 2, 2015

Conversation

Projects
None yet
3 participants
@laanwj
Member

laanwj commented Jun 1, 2015

Until secp256k1 is used for verification there is no reason for Bitcoin Core's secp256k1 to link against gmp, even if available. Pass a flag to configure to override the bignum implementation.

This fixes a crash at runtime on ppc64 reported by @gmaxwell.

Edit: tested and appears to work, after autogen and reconfigure, src/secp256k1/config.log contains

configure:13140: Using bignum implementation: no

... whereas it was using gmp before.

build: disable optional use of gmp in internal secp256k1 build
Until secp256k1 is used for verification there is no reason for Bitcoin
Core's secp256k1 to link against gmp, even if available. Pass a flag to
configure to override the bignum implementation.

This fixes a crash at runtime on ppc64 reported by @gmaxwell.

@laanwj laanwj added the Build system label Jun 1, 2015

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 1, 2015

Member

Needs to go into 0.11 branch as well

Member

laanwj commented Jun 1, 2015

Needs to go into 0.11 branch as well

@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Jun 1, 2015

Member

Nit: --without-bignum would be slightly nicer IMO

Member

luke-jr commented Jun 1, 2015

Nit: --without-bignum would be slightly nicer IMO

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 1, 2015

Member

@luke-jr No opinion on that, but I'm just following secp256k1's configure --help

Member

laanwj commented Jun 1, 2015

@luke-jr No opinion on that, but I'm just following secp256k1's configure --help

@laanwj laanwj merged commit 7fd5b80 into bitcoin:master Jun 2, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jun 2, 2015

Merge pull request #6210
7fd5b80 build: disable optional use of gmp in internal secp256k1 build (Wladimir J. van der Laan)

laanwj added a commit that referenced this pull request Jun 2, 2015

build: disable optional use of gmp in internal secp256k1 build
Until secp256k1 is used for verification there is no reason for Bitcoin
Core's secp256k1 to link against gmp, even if available. Pass a flag to
configure to override the bignum implementation.

This fixes a crash at runtime on ppc64 reported by @gmaxwell.

Github-Pull: #6210
Rebased-From: 7fd5b80
@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni Jun 2, 2015

Member

post-merge ack.

Member

theuni commented Jun 2, 2015

post-merge ack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment