Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
[OSX] revert renaming of Bitcoin-Qt.app and use CFBundleDisplayName (partial revert of #6116) #6214
Glad this actually worked!
What's the reason for not just adding Base.lproj/InfoPlist.strings in git, though? Looks like we were faking it before with Resources/empty.lproj, but now that we actually have something to put in there, may as well just commit the files and copy them into the bundle during creation.
The nice thing with faking the file during the make process is that we not add another file containing a static string for the application name. But I agree it's a bit of a hack.
There is also a problem with .DS_Store (positioning) I'd like to fix.
This is PR final now
Application name shows "Bitcoin Core" but the application bundles name is still "Bitcoin-Qt.app". If you drag "Bitcoin Core" to your /Applications dir, it will ask you if you like to overwrite "Bitcoin-Qt.app".