[OSX] revert renaming of Bitcoin-Qt.app and use CFBundleDisplayName (partial revert of #6116) #6214

Merged
merged 2 commits into from Jun 3, 2015

Conversation

Projects
None yet
5 participants
@jonasschnelli
Member

jonasschnelli commented Jun 1, 2015

Reverts the renaming of the app bundle, uses "Bitcoin Core" as CFBundleDisplayName and keeps "Bitcoin-Core" as disk image name and title.

@Diapolo

This comment has been minimized.

Show comment
Hide comment
@Diapolo

Diapolo Jun 1, 2015

Were there problems with the new name?

Diapolo commented Jun 1, 2015

Were there problems with the new name?

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
Member

jonasschnelli commented Jun 1, 2015

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 1, 2015

Member

@Diapolo the problem seems to be that there is no upgrade path for applications that change name. People will end up with two versions installed, which can be problematic.It's kind of unfortunate.

Member

laanwj commented Jun 1, 2015

@Diapolo the problem seems to be that there is no upgrade path for applications that change name. People will end up with two versions installed, which can be problematic.It's kind of unfortunate.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 2, 2015

Member

@jonasschnelli had any luck with the CFBundleDisplayName?

Member

laanwj commented Jun 2, 2015

@jonasschnelli had any luck with the CFBundleDisplayName?

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jun 2, 2015

Member

Start working on it in about 4h.

Member

jonasschnelli commented Jun 2, 2015

Start working on it in about 4h.

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jun 2, 2015

Member

Found a solution to keep the application bundle name "Bitcoin-Qt.app" while using "Bitcoin Core" as display name. I'm now forming a proper commit and test it over gitian.

Member

jonasschnelli commented Jun 2, 2015

Found a solution to keep the application bundle name "Bitcoin-Qt.app" while using "Bitcoin Core" as display name. I'm now forming a proper commit and test it over gitian.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 2, 2015

Member

Very nice!

Member

laanwj commented Jun 2, 2015

Very nice!

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jun 2, 2015

Member

Credits goes to @theuni for sketching this approach. Thanks.

Member

jonasschnelli commented Jun 2, 2015

Credits goes to @theuni for sketching this approach. Thanks.

@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni Jun 2, 2015

Member

Glad this actually worked!

What's the reason for not just adding Base.lproj/InfoPlist.strings in git, though? Looks like we were faking it before with Resources/empty.lproj, but now that we actually have something to put in there, may as well just commit the files and copy them into the bundle during creation.

Member

theuni commented Jun 2, 2015

Glad this actually worked!

What's the reason for not just adding Base.lproj/InfoPlist.strings in git, though? Looks like we were faking it before with Resources/empty.lproj, but now that we actually have something to put in there, may as well just commit the files and copy them into the bundle during creation.

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jun 2, 2015

Member

The nice thing with faking the file during the make process is that we not add another file containing a static string for the application name. But I agree it's a bit of a hack.

There is also a problem with .DS_Store (positioning) I'd like to fix.
I think this PR is ready by tmr.

Member

jonasschnelli commented Jun 2, 2015

The nice thing with faking the file during the make process is that we not add another file containing a static string for the application name. But I agree it's a bit of a hack.

There is also a problem with .DS_Store (positioning) I'd like to fix.
I think this PR is ready by tmr.

@jonasschnelli jonasschnelli changed the title from [OSX] revert renaming of Bitcoin-Qt.app (partial revert of #6116) to [OSX] revert renaming of Bitcoin-Qt.app and use CFBundleDisplayName (partial revert of #6116) Jun 2, 2015

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jun 3, 2015

Member

This is PR final now
Test dmg: https://builds.jonasschnelli.ch/pulls/6214/

Application name shows "Bitcoin Core" but the application bundles name is still "Bitcoin-Qt.app". If you drag "Bitcoin Core" to your /Applications dir, it will ask you if you like to overwrite "Bitcoin-Qt.app".

Prove screens:
OSX10.10
bildschirmfoto 2015-06-03 um 09 38 51

OSX10.7
bildschirmfoto 2015-06-03 um 09 39 54

Member

jonasschnelli commented Jun 3, 2015

This is PR final now
Test dmg: https://builds.jonasschnelli.ch/pulls/6214/

Application name shows "Bitcoin Core" but the application bundles name is still "Bitcoin-Qt.app". If you drag "Bitcoin Core" to your /Applications dir, it will ask you if you like to overwrite "Bitcoin-Qt.app".

Prove screens:
OSX10.10
bildschirmfoto 2015-06-03 um 09 38 51

OSX10.7
bildschirmfoto 2015-06-03 um 09 39 54

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake Jun 3, 2015

Member

@theuni @jonasschnelli awesome work, will test shortly.

Member

fanquake commented Jun 3, 2015

@theuni @jonasschnelli awesome work, will test shortly.

@@ -30,6 +30,12 @@
<key>CFBundleExecutable</key>
<string>Bitcoin-Qt</string>
+
+ <key>CFBundleName</key>
+ <string>Bitcoin-Qt</string>

This comment has been minimized.

@jonasschnelli

jonasschnelli Jun 3, 2015

Member

For the records: this is required so that the OS can detect a manual rename of the application. If current (manually renamed) application name is != CFBundleName, it won't use localization over Base.lproj to rename the application display name.

@jonasschnelli

jonasschnelli Jun 3, 2015

Member

For the records: this is required so that the OS can detect a manual rename of the application. If current (manually renamed) application name is != CFBundleName, it won't use localization over Base.lproj to rename the application display name.

@laanwj laanwj added the macOS label Jun 3, 2015

@laanwj laanwj merged commit 0a32a93 into bitcoin:master Jun 3, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jun 3, 2015

Merge pull request #6214
0a32a93 OSX: use "Bitcoin Core" as Bundle Display Name (Jonas Schnelli)
a2241ea [OSX] revert renaming of Bitcoin-Qt.app (Jonas Schnelli)
@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 3, 2015

Member

Backported to 0.11 via 4d435d1 6145fdf .

Member

laanwj commented Jun 3, 2015

Backported to 0.11 via 4d435d1 6145fdf .

laanwj added a commit that referenced this pull request Jun 3, 2015

[OSX] revert renaming of Bitcoin-Qt.app
Github-Pull: #6214
Rebased-From: a2241ea

laanwj added a commit that referenced this pull request Jun 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment