Explicitly set tx.nVersion for the genesis block and mining tests #6222

Merged
merged 1 commit into from Jun 10, 2015

Conversation

Projects
None yet
5 participants
@maaku
Contributor

maaku commented Jun 2, 2015

If/when CTransaction::CURRENT_VERSION is incremented, this will break CChainParams and the miner tests. This fix sets the transaction version explicitly where we depend on the hash value (genesis block, proof of work checks).

Explicitly set tx.nVersion for the genesis block and mining tests
If/when CTransaction::CURRENT_VERSION is incremented, this will break CChainParams and the miner tests. This fix sets the transaction version explicitly where we depend on the hash value (genesis block, proof of work checks).
@luke-jr

This comment has been minimized.

Show comment
Hide comment
@luke-jr

luke-jr Jun 3, 2015

Member

utACK

Member

luke-jr commented Jun 3, 2015

utACK

@maaku

This comment has been minimized.

Show comment
Hide comment
@maaku

maaku Jun 3, 2015

Contributor

Btw, note for future reference that actually changing CURRENT_VERSION breaks some of the hex test data, but that's not easy to future proof now.

Contributor

maaku commented Jun 3, 2015

Btw, note for future reference that actually changing CURRENT_VERSION breaks some of the hex test data, but that's not easy to future proof now.

@laanwj laanwj added the Tests label Jun 3, 2015

@jgarzik

This comment has been minimized.

Show comment
Hide comment
@jgarzik

jgarzik Jun 7, 2015

Contributor

ut ACK

Contributor

jgarzik commented Jun 7, 2015

ut ACK

@petertodd

This comment has been minimized.

Show comment
Hide comment
@petertodd

petertodd Jun 7, 2015

Contributor

utACK

Contributor

petertodd commented Jun 7, 2015

utACK

@laanwj laanwj merged commit efd4444 into bitcoin:master Jun 10, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jun 10, 2015

Merge pull request #6222
efd4444 Explicitly set tx.nVersion for the genesis block and mining tests (Mark Friedenbach)

@dagurval dagurval referenced this pull request in bitcoinxt/bitcoinxt Mar 14, 2017

Merged

Chainparams backports #189

@str4d str4d referenced this pull request in zcash/zcash Mar 28, 2017

Merged

Bitcoin 0.12 chainparams cleanups #2217

zkbot added a commit to zcash/zcash that referenced this pull request Jan 19, 2018

Auto merge of #2217 - str4d:2074-chainparams, r=str4d
Bitcoin 0.12 chainparams cleanups

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6222
- bitcoin/bitcoin#6381
- bitcoin/bitcoin#6473
- bitcoin/bitcoin#6242

Part of #2074.

zkbot added a commit to zcash/zcash that referenced this pull request Jan 22, 2018

Auto merge of #2217 - str4d:2074-chainparams, r=str4d
Bitcoin 0.12 chainparams cleanups

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6222
- bitcoin/bitcoin#6381
- bitcoin/bitcoin#6473
- bitcoin/bitcoin#6242

Part of #2074.

zkbot added a commit to zcash/zcash that referenced this pull request Jan 22, 2018

Auto merge of #2217 - str4d:2074-chainparams, r=str4d
Bitcoin 0.12 chainparams cleanups

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6222
- bitcoin/bitcoin#6381
- bitcoin/bitcoin#6473
- bitcoin/bitcoin#6242

Part of #2074.

zkbot added a commit to zcash/zcash that referenced this pull request Jan 22, 2018

Auto merge of #2217 - str4d:2074-chainparams, r=str4d
Bitcoin 0.12 chainparams cleanups

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6222
- bitcoin/bitcoin#6381
- bitcoin/bitcoin#6473
- bitcoin/bitcoin#6242

Part of #2074.

zkbot added a commit to zcash/zcash that referenced this pull request Jan 22, 2018

Auto merge of #2217 - str4d:2074-chainparams, r=str4d
Bitcoin 0.12 chainparams cleanups

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6222
- bitcoin/bitcoin#6381
- bitcoin/bitcoin#6473
- bitcoin/bitcoin#6242

Part of #2074.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment