Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set tx.nVersion for the genesis block and mining tests #6222

Merged
merged 1 commit into from Jun 10, 2015

Conversation

@maaku
Copy link
Contributor

maaku commented Jun 2, 2015

If/when CTransaction::CURRENT_VERSION is incremented, this will break CChainParams and the miner tests. This fix sets the transaction version explicitly where we depend on the hash value (genesis block, proof of work checks).

If/when CTransaction::CURRENT_VERSION is incremented, this will break CChainParams and the miner tests. This fix sets the transaction version explicitly where we depend on the hash value (genesis block, proof of work checks).
@luke-jr
Copy link
Member

luke-jr commented Jun 3, 2015

utACK

@maaku
Copy link
Contributor Author

maaku commented Jun 3, 2015

Btw, note for future reference that actually changing CURRENT_VERSION breaks some of the hex test data, but that's not easy to future proof now.

@laanwj laanwj added the Tests label Jun 3, 2015
@jgarzik
Copy link
Contributor

jgarzik commented Jun 7, 2015

ut ACK

@petertodd
Copy link
Contributor

petertodd commented Jun 7, 2015

utACK

@laanwj laanwj merged commit efd4444 into bitcoin:master Jun 10, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Jun 10, 2015
efd4444 Explicitly set tx.nVersion for the genesis block and mining tests (Mark Friedenbach)
@dagurval dagurval mentioned this pull request Mar 14, 2017
zkbot added a commit to zcash/zcash that referenced this pull request Jan 19, 2018
Bitcoin 0.12 chainparams cleanups

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6222
- bitcoin/bitcoin#6381
- bitcoin/bitcoin#6473
- bitcoin/bitcoin#6242

Part of #2074.
zkbot added a commit to zcash/zcash that referenced this pull request Jan 22, 2018
Bitcoin 0.12 chainparams cleanups

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6222
- bitcoin/bitcoin#6381
- bitcoin/bitcoin#6473
- bitcoin/bitcoin#6242

Part of #2074.
zkbot added a commit to zcash/zcash that referenced this pull request Jan 22, 2018
Bitcoin 0.12 chainparams cleanups

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6222
- bitcoin/bitcoin#6381
- bitcoin/bitcoin#6473
- bitcoin/bitcoin#6242

Part of #2074.
zkbot added a commit to zcash/zcash that referenced this pull request Jan 22, 2018
Bitcoin 0.12 chainparams cleanups

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6222
- bitcoin/bitcoin#6381
- bitcoin/bitcoin#6473
- bitcoin/bitcoin#6242

Part of #2074.
zkbot added a commit to zcash/zcash that referenced this pull request Jan 22, 2018
Bitcoin 0.12 chainparams cleanups

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6222
- bitcoin/bitcoin#6381
- bitcoin/bitcoin#6473
- bitcoin/bitcoin#6242

Part of #2074.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.