Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rpcmining/getblocktemplate univalue transition logic error #6234

Merged
merged 1 commit into from Jun 5, 2015

Conversation

jonasschnelli
Copy link
Contributor

@jonasschnelli jonasschnelli commented Jun 4, 2015

Reported by @sdaftuar (Thanks!).

This fixes a bug that was included in #6121 during the transition from Json Spirit to UniValue.

@sdaftuar
Copy link
Member

sdaftuar commented Jun 4, 2015

Verified this fixes getblocktemplate_proposals.py, looks good to me.

@jonasschnelli
Copy link
Contributor Author

jonasschnelli commented Jun 4, 2015

Here is the code line before the transition (before #6121) to verify the change: https://github.com/bitcoin/bitcoin/blob/0.11/src/rpcmining.cpp#L403

@jgarzik
Copy link
Contributor

jgarzik commented Jun 4, 2015

ACK

@fanquake
Copy link
Member

fanquake commented Jun 5, 2015

utACK

@laanwj laanwj merged commit ef5fca8 into bitcoin:master Jun 5, 2015
laanwj added a commit that referenced this pull request Jun 5, 2015
ef5fca8 fix rpcmining/getblocktemplate univalue transition logic error (Jonas Schnelli)
@laanwj
Copy link
Member

laanwj commented Jun 5, 2015

Thanks

zkbot added a commit to zcash/zcash that referenced this pull request Feb 5, 2017
…=<try>

Convert entire source tree from json_spirit to UniValue

This PR cherry-picks bitcoin/bitcoin#6121 and then migrates the Zcash-specific code to UniValue.

Also cherry-picks:
- bitcoin/bitcoin#6241
- bitcoin/bitcoin#6234

Closes #1985.
zkbot added a commit to zcash/zcash that referenced this pull request Feb 7, 2017
…=<try>

Convert entire source tree from json_spirit to UniValue

This PR cherry-picks bitcoin/bitcoin#6121 and then migrates the Zcash-specific code to UniValue.

Also cherry-picks:
- bitcoin/bitcoin#6241
- bitcoin/bitcoin#6234

Closes #1985.
zkbot added a commit to zcash/zcash that referenced this pull request Feb 10, 2017
…=bitcartel

Convert entire source tree from json_spirit to UniValue

This PR cherry-picks bitcoin/bitcoin#6121 and then migrates the Zcash-specific code to UniValue.

Also cherry-picks:
- bitcoin/bitcoin#6241
- bitcoin/bitcoin#6234

Closes #1985.
zkbot added a commit to zcash/zcash that referenced this pull request Feb 10, 2017
…=str4d

Convert entire source tree from json_spirit to UniValue

This PR cherry-picks bitcoin/bitcoin#6121 and then migrates the Zcash-specific code to UniValue.

Also cherry-picks:
- bitcoin/bitcoin#6241
- bitcoin/bitcoin#6234

Closes #1985.
zkbot added a commit to zcash/zcash that referenced this pull request Feb 10, 2017
…=str4d

Convert entire source tree from json_spirit to UniValue

This PR cherry-picks bitcoin/bitcoin#6121 and then migrates the Zcash-specific code to UniValue.

Also cherry-picks:
- bitcoin/bitcoin#6241
- bitcoin/bitcoin#6234

Closes #1985.
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants