fix rpcmining/getblocktemplate univalue transition logic error #6234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified this fixes |
|
Here is the code line before the transition (before #6121) to verify the change: https://github.com/bitcoin/bitcoin/blob/0.11/src/rpcmining.cpp#L403 |
|
ACK |
|
utACK |
laanwj
added a commit
that referenced
this pull request
Jun 5, 2015
ef5fca8 fix rpcmining/getblocktemplate univalue transition logic error (Jonas Schnelli)
|
Thanks |
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Feb 5, 2017
…=<try> Convert entire source tree from json_spirit to UniValue This PR cherry-picks bitcoin/bitcoin#6121 and then migrates the Zcash-specific code to UniValue. Also cherry-picks: - bitcoin/bitcoin#6241 - bitcoin/bitcoin#6234 Closes #1985.
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Feb 10, 2017
…=str4d Convert entire source tree from json_spirit to UniValue This PR cherry-picks bitcoin/bitcoin#6121 and then migrates the Zcash-specific code to UniValue. Also cherry-picks: - bitcoin/bitcoin#6241 - bitcoin/bitcoin#6234 Closes #1985.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by @sdaftuar (Thanks!).
This fixes a bug that was included in #6121 during the transition from Json Spirit to UniValue.