Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd getblockheader RPC call #6247
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
laanwj
Jun 7, 2015
Member
Not against this, but you can get already get block headers using REST /rest/headers/<count>/<hash>.<ext>.
|
Not against this, but you can get already get block headers using REST |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jonasschnelli
Jun 7, 2015
Member
Also not against this, but i think public blockchain data like blocks (headers), transactions or UTXO queries should go over REST instead over an authenticated RPC call. This would follow a more logical design.
Nevertheless, this can be useful because we never merge JSON support for REST Headers (https://github.com/bitcoin/bitcoin/pull/5486/files).
What about getting more in line with REST and also support requesting more than one header (/rest/headers/***<count>***/<hash>.<ext>.)?
|
Also not against this, but i think public blockchain data like blocks (headers), transactions or UTXO queries should go over REST instead over an authenticated RPC call. This would follow a more logical design. Nevertheless, this can be useful because we never merge JSON support for REST Headers (https://github.com/bitcoin/bitcoin/pull/5486/files). What about getting more in line with REST and also support requesting more than one header |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jgarzik
Jun 7, 2015
Contributor
That's the general goal of REST - querying public, unauthenticated blockchain data from the blockchain engine. Seems better placed there, than RPC.
|
That's the general goal of REST - querying public, unauthenticated blockchain data from the blockchain engine. Seems better placed there, than RPC. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
paveljanik
Jun 8, 2015
Contributor
This allows you to get the needed information directly from the Debug window/Console without the needed hackery around the -rest cmdline etc. Very useful! Thanks Peter.
utACK
|
This allows you to get the needed information directly from the Debug window/Console without the needed hackery around the utACK |
laanwj
added
the
RPC/REST/ZMQ
label
Jun 9, 2015
laanwj
reviewed
Jun 12, 2015
| @@ -51,6 +51,32 @@ double GetDifficulty(const CBlockIndex* blockindex) | ||
| return dDiff; | ||
| } | ||
| +UniValue blockheaderToJSON(const CBlockIndex* blockindex) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
laanwj
Jun 12, 2015
Member
There's a strong overlap with #5486 here - even the function is called the same. This does expose a few more values, also derived ones like confirmation and chainwork.
laanwj
Jun 12, 2015
Member
There's a strong overlap with #5486 here - even the function is called the same. This does expose a few more values, also derived ones like confirmation and chainwork.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Tested ACK |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
petertodd
Jun 30, 2015
Contributor
@jgarzik Re: "unauthenticated" data, remember that this is trusted data in the sense that the client would be trusting the full node's opinion on what the valid chain is; I'm not sure I'd use the term "unauthenticated" in describing that, rather, public and trusted.
|
@jgarzik Re: "unauthenticated" data, remember that this is trusted data in the sense that the client would be trusting the full node's opinion on what the valid chain is; I'm not sure I'd use the term "unauthenticated" in describing that, rather, public and trusted. |
laanwj
merged commit 076badb
into
bitcoin:master
Jul 2, 2015
1 check passed
added a commit
that referenced
this pull request
Jul 2, 2015
petertodd
referenced this pull request
in petertodd/python-bitcoinlib
Nov 11, 2015
Closed
Add getblockheader RPC call #95
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Needs to be updated in the docs? |
added a commit
to zcash/zcash
that referenced
this pull request
Feb 15, 2017
added a commit
to zcash/zcash
that referenced
this pull request
Mar 4, 2017
petertodd commentedJun 7, 2015
Alternative to getblock that works even when the block itself has been pruned, returning all available information. Right now the fact that you can't get this information in pruned mode makes pruned nodes quite a bit less useful for some applications.