Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove proxy initialization (continues #4871) #6272
Conversation
laanwj
added
the
P2P
label
Jun 12, 2015
laanwj
referenced this pull request
Jun 12, 2015
Closed
extend core proxy options and handling #4871
Diapolo
reviewed
Jun 12, 2015
View changes
| + if (onionArg == "0") { // Handle -noonion/-onion=0 | ||
| + SetReachable(NET_TOR, false); // set onions as unreachable | ||
| + } else { | ||
| + proxyType addrOnion; |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Diapolo
Jun 12, 2015
Nit: Above you did this as one-liner, so I suggest proxyType addrOnion = proxyType(CService(onionArg, 9050), proxyRandomize);
Diapolo
Jun 12, 2015
Nit: Above you did this as one-liner, so I suggest proxyType addrOnion = proxyType(CService(onionArg, 9050), proxyRandomize);
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Diapolo
Jun 12, 2015
This is a different, but better apporach than what I tried to do. Flow is straight forward, which I really like. I didn't yet test the code by myself, but from review this is (after fixing the nit) an utACK for now. I'm going to test this now.
Diapolo
commented
Jun 12, 2015
|
This is a different, but better apporach than what I tried to do. Flow is straight forward, which I really like. I didn't yet test the code by myself, but from review this is (after fixing the nit) an utACK for now. I'm going to test this now. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Diapolo
Jun 12, 2015
My node connects normally via proxy, the pull compiles without problems, so this has my ACK.
Diapolo
commented
Jun 12, 2015
|
My node connects normally via proxy, the pull compiles without problems, so this has my ACK. |
This was referenced Jun 15, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Added more proxy tests (these test the output of |
laanwj
merged commit edbdf88
into
bitcoin:master
Jun 18, 2015
1 check passed
added a commit
that referenced
this pull request
Jun 18, 2015
added a commit
to zcash/zcash
that referenced
this pull request
Feb 15, 2017
added a commit
to zcash/zcash
that referenced
this pull request
Mar 3, 2017
added a commit
to zcash/zcash
that referenced
this pull request
Mar 3, 2017
added a commit
to zcash/zcash
that referenced
this pull request
Mar 3, 2017
laanwj commentedJun 12, 2015
Make the proxy initialization code in
AppInit2more clear. This provides a straightforward flow, gets rid of .count() (which made it impossible to override an earlier provided proxy option to nothing), as well as comments the different cases.This continues the work in #4871. Ping @Diapolo.