Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getbalance * 0 #6276

Merged
merged 1 commit into from Jun 15, 2015
Merged

Fix getbalance * 0 #6276

merged 1 commit into from Jun 15, 2015

Conversation

@dgenr8
Copy link
Contributor

dgenr8 commented Jun 12, 2015

Change "getbalance *" not to use IsTrusted. The method and result now match the "getbalance <specific-account>" behavior. In particular, "getbalance * 0" now works.

Ping @jonasschnelli, @wtogami

@wtogami
Copy link
Contributor

wtogami commented Jun 12, 2015

Tag for 0.10 and 0.11 branches please.

@dgenr8 dgenr8 force-pushed the dgenr8:getbalance_fix branch 2 times, most recently Jun 12, 2015
Chance "getbalance *" not to use IsTrusted.  The method and result
now match the "getbalance <specific-account>" behavior. In
particular, "getbalance * 0" now works.

Also fixed a comment -- GetGalance has required 1 confirmation
for many years, and the default "getbalance *" behavior matches
that.
@dgenr8 dgenr8 force-pushed the dgenr8:getbalance_fix branch to 7d6a85a Jun 12, 2015
@jonasschnelli
Copy link
Member

jonasschnelli commented Jun 13, 2015

utACK.
Also utACK backport to 0.10 and 0.11.
Because the accounting system has been marked for deprecation, we should slowly start to think about how the deprecation could lead/turn to a removal (or transformation to labels).

@thrasher-
Copy link

thrasher- commented Jun 13, 2015

Tested and works as expected, backporting to 0.10 requires renaming CheckFinalTx to IsFinalTx.

@laanwj
Copy link
Member

laanwj commented Jun 15, 2015

utACK

@laanwj laanwj merged commit 7d6a85a into bitcoin:master Jun 15, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Jun 15, 2015
7d6a85a Fix getbalance * (Tom Harding)
laanwj added a commit that referenced this pull request Jun 15, 2015
Chance "getbalance *" not to use IsTrusted.  The method and result
now match the "getbalance <specific-account>" behavior. In
particular, "getbalance * 0" now works.

Also fixed a comment -- GetGalance has required 1 confirmation
for many years, and the default "getbalance *" behavior matches
that.

Github-Pull: #6276
Rebased-From: 7d6a85a
@laanwj
Copy link
Member

laanwj commented Jun 15, 2015

Cherry-picked to 0.11 as c9fd907, to 0.10 as (thanks @thrasher-) c7d28ce12af216a691f7aac1ae48f11c979d604f

laanwj added a commit that referenced this pull request Jun 15, 2015
Chance "getbalance *" not to use IsTrusted.  The method and result
now match the "getbalance <specific-account>" behavior. In
particular, "getbalance * 0" now works.

Also fixed a comment -- GetGalance has required 1 confirmation
for many years, and the default "getbalance *" behavior matches
that.

Github-Pull: #6276
Rebased-From: 7d6a85a
Rebased-By: @trasher-
@dgenr8 dgenr8 deleted the dgenr8:getbalance_fix branch Sep 19, 2018
reddink added a commit to reddcoin-project/reddcoin that referenced this pull request May 27, 2020
Chance "getbalance *" not to use IsTrusted.  The method and result
now match the "getbalance <specific-account>" behavior. In
particular, "getbalance * 0" now works.

Also fixed a comment -- GetGalance has required 1 confirmation
for many years, and the default "getbalance *" behavior matches
that.

Github-Pull: bitcoin#6276
Rebased-From: 7d6a85a
Rebased-By: @trasher-
(cherry picked from commit 0fd8464)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.