Fix getbalance * 0 #6276

Merged
merged 1 commit into from Jun 15, 2015

Conversation

Projects
None yet
5 participants
@dgenr8
Contributor

dgenr8 commented Jun 12, 2015

Change "getbalance *" not to use IsTrusted. The method and result now match the "getbalance <specific-account>" behavior. In particular, "getbalance * 0" now works.

Ping @jonasschnelli, @wtogami

@wtogami

This comment has been minimized.

Show comment
Hide comment
@wtogami

wtogami Jun 12, 2015

Contributor

Tag for 0.10 and 0.11 branches please.

Contributor

wtogami commented Jun 12, 2015

Tag for 0.10 and 0.11 branches please.

@wtogami wtogami referenced this pull request in litecoin-project/litecoin Jun 12, 2015

Closed

Zero conf getbalance regression in Bitcoin 0.10 #201

Fix getbalance *
Chance "getbalance *" not to use IsTrusted.  The method and result
now match the "getbalance <specific-account>" behavior. In
particular, "getbalance * 0" now works.

Also fixed a comment -- GetGalance has required 1 confirmation
for many years, and the default "getbalance *" behavior matches
that.
@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jun 13, 2015

Member

utACK.
Also utACK backport to 0.10 and 0.11.
Because the accounting system has been marked for deprecation, we should slowly start to think about how the deprecation could lead/turn to a removal (or transformation to labels).

Member

jonasschnelli commented Jun 13, 2015

utACK.
Also utACK backport to 0.10 and 0.11.
Because the accounting system has been marked for deprecation, we should slowly start to think about how the deprecation could lead/turn to a removal (or transformation to labels).

@thrasher-

This comment has been minimized.

Show comment
Hide comment
@thrasher-

thrasher- Jun 13, 2015

Tested and works as expected, backporting to 0.10 requires renaming CheckFinalTx to IsFinalTx.

Tested and works as expected, backporting to 0.10 requires renaming CheckFinalTx to IsFinalTx.

@thrasher- thrasher- referenced this pull request in litecoin-project/litecoin Jun 14, 2015

Closed

Fixed getbalance command #202

@laanwj laanwj added the Wallet label Jun 15, 2015

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 15, 2015

Member

utACK

Member

laanwj commented Jun 15, 2015

utACK

@laanwj laanwj merged commit 7d6a85a into bitcoin:master Jun 15, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jun 15, 2015

Merge pull request #6276
7d6a85a Fix getbalance * (Tom Harding)

laanwj added a commit that referenced this pull request Jun 15, 2015

Fix getbalance *
Chance "getbalance *" not to use IsTrusted.  The method and result
now match the "getbalance <specific-account>" behavior. In
particular, "getbalance * 0" now works.

Also fixed a comment -- GetGalance has required 1 confirmation
for many years, and the default "getbalance *" behavior matches
that.

Github-Pull: #6276
Rebased-From: 7d6a85a
@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 15, 2015

Member

Cherry-picked to 0.11 as c9fd907, to 0.10 as (thanks @thrasher-) c7d28ce12af216a691f7aac1ae48f11c979d604f

Member

laanwj commented Jun 15, 2015

Cherry-picked to 0.11 as c9fd907, to 0.10 as (thanks @thrasher-) c7d28ce12af216a691f7aac1ae48f11c979d604f

laanwj added a commit that referenced this pull request Jun 15, 2015

Fix getbalance *
Chance "getbalance *" not to use IsTrusted.  The method and result
now match the "getbalance <specific-account>" behavior. In
particular, "getbalance * 0" now works.

Also fixed a comment -- GetGalance has required 1 confirmation
for many years, and the default "getbalance *" behavior matches
that.

Github-Pull: #6276
Rebased-From: 7d6a85a
Rebased-By: @trasher-
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment