[Qt] allow banning and unbanning over UI->peers table #6315

jonasschnelli · 2015-06-20T19:59:58Z

This adds 4 ban options to the peers tables context menu (1h, 24h, 7d, 365d). If there are active bans, a table with banned subnets will be shown.
Sync between the rpc bans and the ui bans are guaranteed over a new uiInterface signal.

Screenshots:

jonasschnelli · 2015-06-20T20:01:10Z

src/rpcnet.cpp

@@ -527,6 +528,7 @@ UniValue setban(const UniValue& params, bool fHelp)
            throw JSONRPCError(RPC_MISC_ERROR, "Error: Unban failed");
    }

+    uiInterface.BannedListChanged();


I'm not sure if the locking of a signal emit is done within boost::signal of if this needs explicit locking of uiInterface?

Perhaps @laanwj can comment on this?

jonasschnelli · 2015-06-20T20:03:07Z

src/qt/bantablemodel.cpp

+        case Bantime:
+            //show time in users local timezone, not 64bit compatible!
+            //TODO find a way to support 64bit timestamps
+            boost::posix_time::ptime pt1 = boost::posix_time::from_time_t(rec->bantil);


i recognized that boost::posix_time::from_time_t is not 64bit capable. Maybe someone has a idea how to fix this.

What about QDateTime::fromTime_t()?

QDateTime::fromTime_t(rec->bantil).toString() didn't test it...

I think this won't work either. The docs are saying: QDateTime QDateTime::fromTime_t(uint seconds) (uint!).

Found a fix! Pushed.

Diapolo · 2015-06-20T22:49:19Z

Great pull IMHO, sorry for hitting you hard with that bunch of comments...

jonasschnelli · 2015-06-21T06:57:36Z

Thanks @Diapolo for the review. Appricate detailed feedback.
Will fix all your points (especially the miss transaction to fDisconnect!).

jonasschnelli · 2015-06-21T10:45:52Z

Prebuilt binaries: https://builds.jonasschnelli.ch/pulls/6315/

Diapolo · 2015-06-21T11:02:01Z

src/qt/bantablemodel.cpp

+        }
+    } else if (role == Qt::TextAlignmentRole) {
+        if (index.column() == Bantime)
+            return (int)(Qt::AlignRight | Qt::AlignVCenter);


Still the question: Is int the right type here? I tried (QVariant) which also works and is more the Qt style?

Right. This is also the same as we have it in PeersTableModel, it works, but i agree that it should be QVariant (as the method definition says).

I opened #6317 and will try to keep that in sync with what we are doing here :).

Diapolo · 2015-06-21T11:31:04Z

Currently integrating this into my build to test, will report back :).

Diapolo · 2015-06-21T11:54:32Z

Observations:

Banning a node, selecting a new node (from connected peers) and then selecting a banned node leaves the details of the previous (not banned) node visible in the right area.
Banning a node selects the first cell in the banlist table without selecting the whole line and without a focus (cell is not marked active). I'd suggest the banned node should be selected and active entirely.
I'm using Tor and hidden-service addresses + netmask + banned until are that large that I'm unable to view the whole values with the default sizes.
The banned peers list has a heading Banned peers, perhaps the connected peers also should get a heading? I'd vote for a much smaller font size, the current one looks rather too big.

Edit:

There is a serious issue with banning incomming connections via Tor, these are all shown as 127.0.0.1 and handling them seems broken.

Diapolo · 2015-06-21T12:57:24Z

There is also an issue with removing a peer from banned peers list when banned until is over:

The peer should be removed from the list, which is not working currently.

listbanned also still shows them:
[
{
"address": "127.0.0.1/255.255.255.255",
"banned_untill": 1434891295
},
{
"address": "nkf5e6b7pl4jfd4a.onion/ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff",
"banned_untill": 1434891291
},
{
"address": "t6xj6wilh4ytvcs7.onion/ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff",
"banned_untill": 1434891400
}
]

jonasschnelli · 2015-06-21T13:14:58Z

@Diapolo: for autocleaning then ban list see PR #6310

I think you point 1) is not a problem. The peer is still selected (gray) when you interact with the bantable. Point 2) and 3) are cosmetics and should not hold this PR back. Point 4) agreed.

Banning tor nodes needs testing (best first over RPC) and maybe needs more implementation. Would be good if you could see what's missing there.

jonasschnelli · 2015-06-21T14:02:00Z

Tested also with Tor nodes. Works fine. @Diapolo: what issues did you encounter with tor nodes?

Diapolo · 2015-06-22T14:18:02Z

@jonasschnelli The problem are incoming Tor nodes with 127.0.0.1 blocking one connected node blocks any other incoming 127.0.0.1 node. Other connected 127.0.0.1 are not affected.

Also I'd suggest splitting of the autocleaning pull from the disk-store-pull as autocleaning is uncontroversial and also needed by this one.

I also disagree on ignoring UI or UX issues for now as often such "small" or "minor" things are just forgotton or I pick them up. I'd vote for making this pull good and not just "working okay" :).

- add missing NULL pointer checks - add better comments and reorder some code in rpcconsole.cpp - remove unneeded leftovers in bantable.cpp - update bantable column sizes to prevent cutting of banned until

- 1 (h)our - 1 (d)ay - 1 (w)eek - 1 (y)ear

- this matches RPC call behaviour

jonasschnelli · 2015-09-16T16:32:32Z

Rebased. Travis is happy now.

jtimon · 2015-09-17T17:00:21Z

Concept ACK

luke-jr · 2015-09-20T00:12:00Z

Why does 7f90ea7 remove the DumpBanlist calls?

jonasschnelli · 2015-09-20T08:43:51Z

Thank @luke-jr for the precise review.
I think this sneaked in over a rebase because this PR started before the banlist was persisted to disk.

Just added a commit that re-implenents the DumpBanlist() calls in case of banning/unbanning over QT.

luke-jr · 2015-09-20T14:04:30Z

Note I did not do a precise review for this (yet?), just noticed those disappear from the previous version. ;)

7aac6db [QT] dump banlist to disk in case of ban/unban over QT (Jonas Schnelli) 7f90ea7 [QA] adabt QT_NO_KEYWORDS for QT ban implementation (Jonas Schnelli) 07f70b2 [QA] fix netbase tests because of new CSubNet::ToString() output (Jonas Schnelli) 4ed0510 [Qt] call DumpBanlist() when baning unbaning nodes (Philip Kaufmann) be89292 [Qt] reenabling hotkeys for ban context menu, use different words (Jonas Schnelli) b1189cf [Qt] adapt QT ban option to banlist.dat changes (Jonas Schnelli) 65abe91 [Qt] add sorting for bantable (Philip Kaufmann) 51654de [Qt] bantable polish (Philip Kaufmann) cdd72cd [Qt] simplify ban list signal handling (Philip Kaufmann) 43c1f5b [Qt] remove unused timer-code from banlistmodel.cpp (Jonas Schnelli) e2b8028 net: Fix CIDR notation in ToString() (Wladimir J. van der Laan) 9e521c1 [Qt] polish ban table (Philip Kaufmann) 607809f net: use CIDR notation in CSubNet::ToString() (Jonas Schnelli) 53caec6 [Qt] bantable overhaul (Jonas Schnelli) f0bcbc4 [Qt] bantable fix timestamp 64bit issue (Jonas Schnelli) 6135309 [Qt] banlist, UI optimizing and better signal handling (Jonas Schnelli) 770ca79 [Qt] add context menu with unban option to ban table (Jonas Schnelli) 5f42132 [Qt] add ui signal for banlist changes (Jonas Schnelli) ad204df [Qt] add banlist table below peers table (Jonas Schnelli) 50f0908 [Qt] add ban functions to peers window (Jonas Schnelli)

Diapolo · 2015-09-22T12:01:25Z

@laanwj Now if #6371 could be merged, I'd be happy!

banlist.dat: store banlist on disk Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6310 - bitcoin/bitcoin#6315 - Only the new signal and net changes, no QT - bitcoin/bitcoin#7350 - bitcoin/bitcoin#7458 Part of #2074.

banlist.dat: store banlist on disk Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6310 - bitcoin/bitcoin#6315 - Only the new signal and net changes, no QT. - bitcoin/bitcoin#7350 - bitcoin/bitcoin#7458 - bitcoin/bitcoin#7696 - bitcoin/bitcoin#7959 - bitcoin/bitcoin#7906 - Only the ban-related commits. - bitcoin/bitcoin#8392 - Only the second commit. - bitcoin/bitcoin#8085 - Only the second commit. - bitcoin/bitcoin#10564 Part of #2074.

banlist.dat: store banlist on disk Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6310 - bitcoin/bitcoin#6315 - Only the new signal and net changes, no QT. - bitcoin/bitcoin#7350 - bitcoin/bitcoin#7458 - bitcoin/bitcoin#7696 - bitcoin/bitcoin#7959 - bitcoin/bitcoin#7906 - Only the ban-related commits. - bitcoin/bitcoin#8392 - Only the second commit. - bitcoin/bitcoin#8085 - Only the second commit. - bitcoin/bitcoin#10564 - bitcoin/bitcoin#13061 - Wasn't needed when I first made this backport in 2017, but it is now! Part of #2074.

jonasschnelli reviewed Jun 20, 2015
View reviewed changes

jonasschnelli force-pushed the 2015/06/qt_ban branch from 2233f12 to b5621fa Compare June 20, 2015 20:02

jonasschnelli reviewed Jun 20, 2015
View reviewed changes

Diapolo reviewed Jun 21, 2015
View reviewed changes

laanwj added the GUI label Jun 22, 2015

jonasschnelli force-pushed the 2015/06/qt_ban branch from 114c722 to f75b590 Compare June 22, 2015 15:17

Philip Kaufmann and others added 7 commits September 16, 2015 16:50

[Qt] bantable polish

51654de

- add missing NULL pointer checks - add better comments and reorder some code in rpcconsole.cpp - remove unneeded leftovers in bantable.cpp - update bantable column sizes to prevent cutting of banned until

[Qt] add sorting for bantable

65abe91

[Qt] adapt QT ban option to banlist.dat changes

b1189cf

[Qt] reenabling hotkeys for ban context menu, use different words

be89292

- 1 (h)our - 1 (d)ay - 1 (w)eek - 1 (y)ear

[Qt] call DumpBanlist() when baning unbaning nodes

4ed0510

- this matches RPC call behaviour

[QA] fix netbase tests because of new CSubNet::ToString() output

07f70b2

[QA] adabt QT_NO_KEYWORDS for QT ban implementation

7f90ea7

jonasschnelli force-pushed the 2015/06/qt_ban branch from 897ff84 to 7f90ea7 Compare September 16, 2015 14:50

[QT] dump banlist to disk in case of ban/unban over QT

7aac6db

laanwj merged commit 7aac6db into bitcoin:master Sep 22, 2015

maflcko mentioned this pull request Oct 16, 2015

clang-format: Recently added files #6839

Closed

jonasschnelli mentioned this pull request Nov 27, 2015

Ability to disconnect/ban peers from the GUI #5866

Closed

str4d mentioned this pull request Jul 14, 2017

Bitcoin 0.12 P2P/Net PRs 1 zcash/zcash#2534

Draft

str4d mentioned this pull request Dec 19, 2017

banlist.dat: store banlist on disk zcash/zcash#2812

Merged

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Qt] allow banning and unbanning over UI->peers table #6315

[Qt] allow banning and unbanning over UI->peers table #6315

jonasschnelli commented Jun 20, 2015

jonasschnelli Jun 20, 2015

Diapolo Jun 23, 2015

jonasschnelli Jun 20, 2015

Diapolo Jun 20, 2015

jonasschnelli Jun 21, 2015

jonasschnelli Jun 21, 2015

Diapolo commented Jun 20, 2015

jonasschnelli commented Jun 21, 2015

jonasschnelli commented Jun 21, 2015

Diapolo Jun 21, 2015

jonasschnelli Jun 21, 2015

Diapolo Jun 21, 2015

Diapolo commented Jun 21, 2015

Diapolo commented Jun 21, 2015

Diapolo commented Jun 21, 2015

jonasschnelli commented Jun 21, 2015

jonasschnelli commented Jun 21, 2015

Diapolo commented Jun 22, 2015

jonasschnelli commented Sep 16, 2015

jtimon commented Sep 17, 2015

luke-jr commented Sep 20, 2015

jonasschnelli commented Sep 20, 2015

luke-jr commented Sep 20, 2015

Diapolo commented Sep 22, 2015

[Qt] allow banning and unbanning over UI->peers table #6315

[Qt] allow banning and unbanning over UI->peers table #6315

Conversation

jonasschnelli commented Jun 20, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Diapolo commented Jun 20, 2015

jonasschnelli commented Jun 21, 2015

jonasschnelli commented Jun 21, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Diapolo commented Jun 21, 2015

Diapolo commented Jun 21, 2015

Diapolo commented Jun 21, 2015

jonasschnelli commented Jun 21, 2015

jonasschnelli commented Jun 21, 2015

Diapolo commented Jun 22, 2015

jonasschnelli commented Sep 16, 2015

jtimon commented Sep 17, 2015

luke-jr commented Sep 20, 2015

jonasschnelli commented Sep 20, 2015

luke-jr commented Sep 20, 2015

Diapolo commented Sep 22, 2015