[Qt] minor optimisations in peertablemodel #6317

Merged
merged 1 commit into from Sep 16, 2015

Conversation

Projects
None yet
6 participants
@Diapolo

Diapolo commented Jun 21, 2015

  • remove an unneeded include of net.h in peertablemodel.cpp
  • add const after size() in PeerTablePriv
  • remove 2x unneeded else in functions
  • replace a (int) typecast by (QVariant) to use Qt style
@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jun 22, 2015

Contributor

Can you please remove { and } in a one-line ifs?
utACK

Contributor

paveljanik commented Jun 22, 2015

Can you please remove { and } in a one-line ifs?
utACK

@Diapolo

This comment has been minimized.

Show comment
Hide comment
@Diapolo

Diapolo Jun 22, 2015

@paveljanik @laanwj most of the time prefers { and } even for one-line ifs :).

Diapolo commented Jun 22, 2015

@paveljanik @laanwj most of the time prefers { and } even for one-line ifs :).

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jun 23, 2015

Member

I agree with @paveljanik: most one line ifs are without brackets and i think this is according to our code style / clang style.

Member

jonasschnelli commented Jun 23, 2015

I agree with @paveljanik: most one line ifs are without brackets and i think this is according to our code style / clang style.

@Diapolo

This comment has been minimized.

Show comment
Hide comment
@Diapolo

Diapolo Jun 23, 2015

@paveljanik @jonasschnelli Changed into one-line ifs :).

Diapolo commented Jun 23, 2015

@paveljanik @jonasschnelli Changed into one-line ifs :).

@laanwj laanwj added the GUI label Jul 2, 2015

@Diapolo

This comment has been minimized.

Show comment
Hide comment
@Diapolo

Diapolo Jul 6, 2015

@paveljanik @jonasschnelli @laanwj Do I get some ACKs, this should be easy to merge :).

Diapolo commented Jul 6, 2015

@paveljanik @jonasschnelli @laanwj Do I get some ACKs, this should be easy to merge :).

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jul 6, 2015

Contributor

utACK
I think such changes should go to trivial...

Contributor

paveljanik commented Jul 6, 2015

utACK
I think such changes should go to trivial...

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jul 6, 2015

Member

utACK

Member

jonasschnelli commented Jul 6, 2015

utACK

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
Member

jonasschnelli commented Jul 14, 2015

ACK

@Diapolo

This comment has been minimized.

Show comment
Hide comment
@Diapolo

Diapolo Jul 29, 2015

@laanwj Can you please merge this trivial stuff :)?

Diapolo commented Jul 29, 2015

@laanwj Can you please merge this trivial stuff :)?

Philip Kaufmann
[Qt] minor optimisations in peertablemodel
- remove an unneeded include of net.h in peertablemodel.cpp
- add const after size() in PeerTablePriv
- remove 2x unneeded else in functions
- replace a (int) typecast by (QVariant) to use Qt style
- remove unneeded include of peertablemodel.h from rpcconsole.cpp
@Diapolo

This comment has been minimized.

Show comment
Hide comment
@Diapolo

Diapolo Aug 10, 2015

@laanwj Ping once more.

Diapolo commented Aug 10, 2015

@laanwj Ping once more.

@Diapolo

This comment has been minimized.

Show comment
Hide comment
@Diapolo

Diapolo Sep 9, 2015

@jonasschnelli IMHO, if we still support the GUI, we need another person wo is willing or able to merge GUI pulls... it's currently frustrating!

Diapolo commented Sep 9, 2015

@jonasschnelli IMHO, if we still support the GUI, we need another person wo is willing or able to merge GUI pulls... it's currently frustrating!

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Sep 10, 2015

Member

merge GUI pulls

It seems cosmetic-only changes to the source code usually get rejected? (#6511)

Still, utACK from me.

Member

MarcoFalke commented Sep 10, 2015

merge GUI pulls

It seems cosmetic-only changes to the source code usually get rejected? (#6511)

Still, utACK from me.

@jgarzik jgarzik merged commit 92684bb into bitcoin:master Sep 16, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jgarzik pushed a commit that referenced this pull request Sep 16, 2015

Jeff Garzik

@Diapolo Diapolo deleted the Diapolo:peertablemodel branch Sep 16, 2015

str4d added a commit to str4d/zcash that referenced this pull request Jan 31, 2017

[Trivial] start the help texts with lowercase
Zcash: Also include AC_HELP_STRING -> AS_HELP_STRING (ostensibly from merging
bitcoin/bitcoin#6317 but the change only occurs in the merge commit
ca5e2a1, not the PR itself).

str4d added a commit to str4d/zcash that referenced this pull request Feb 8, 2017

[Trivial] start the help texts with lowercase
Zcash: Also include AC_HELP_STRING -> AS_HELP_STRING (ostensibly from merging
bitcoin/bitcoin#6317 but the change only occurs in the merge commit
ca5e2a1, not the PR itself).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment