Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Qt] minor optimisations in peertablemodel #6317

Merged
merged 1 commit into from
Sep 16, 2015
Merged

[Qt] minor optimisations in peertablemodel #6317

merged 1 commit into from
Sep 16, 2015

Conversation

Diapolo
Copy link

@Diapolo Diapolo commented Jun 21, 2015

  • remove an unneeded include of net.h in peertablemodel.cpp
  • add const after size() in PeerTablePriv
  • remove 2x unneeded else in functions
  • replace a (int) typecast by (QVariant) to use Qt style

@Diapolo Diapolo mentioned this pull request Jun 21, 2015
Merged
@paveljanik
Copy link
Contributor

Can you please remove { and } in a one-line ifs?
utACK

@Diapolo
Copy link
Author

Diapolo commented Jun 22, 2015

@paveljanik @laanwj most of the time prefers { and } even for one-line ifs :).

@jonasschnelli
Copy link
Contributor

I agree with @paveljanik: most one line ifs are without brackets and i think this is according to our code style / clang style.

@Diapolo
Copy link
Author

Diapolo commented Jun 23, 2015

@paveljanik @jonasschnelli Changed into one-line ifs :).

@laanwj laanwj added the GUI label Jul 2, 2015
@Diapolo
Copy link
Author

Diapolo commented Jul 6, 2015

@paveljanik @jonasschnelli @laanwj Do I get some ACKs, this should be easy to merge :).

@paveljanik
Copy link
Contributor

utACK
I think such changes should go to trivial...

@jonasschnelli
Copy link
Contributor

utACK

@jonasschnelli
Copy link
Contributor

ACK

@Diapolo
Copy link
Author

Diapolo commented Jul 29, 2015

@laanwj Can you please merge this trivial stuff :)?

[Qt] minor optimisations in peertablemodel
92684bb 
- remove an unneeded include of net.h in peertablemodel.cpp
- add const after size() in PeerTablePriv
- remove 2x unneeded else in functions
- replace a (int) typecast by (QVariant) to use Qt style
- remove unneeded include of peertablemodel.h from rpcconsole.cpp
@Diapolo
Copy link
Author

Diapolo commented Aug 10, 2015

@laanwj Ping once more.

@Diapolo
Copy link
Author

Diapolo commented Sep 9, 2015

@jonasschnelli IMHO, if we still support the GUI, we need another person wo is willing or able to merge GUI pulls... it's currently frustrating!

@maflcko
Copy link
Member

maflcko commented Sep 10, 2015

merge GUI pulls

It seems cosmetic-only changes to the source code usually get rejected? (#6511)

Still, utACK from me.

@jgarzik jgarzik merged commit 92684bb into bitcoin:master Sep 16, 2015
jgarzik pushed a commit that referenced this pull request Sep 16, 2015
Merge pull request #6317
ca5e2a1
@Diapolo Diapolo deleted the peertablemodel branch September 16, 2015 13:56
str4d pushed a commit to str4d/zcash that referenced this pull request Feb 8, 2017
@paveljanik @str4d
[Trivial] start the help texts with lowercase
1afb843 
Zcash: Also include AC_HELP_STRING -> AS_HELP_STRING (ostensibly from merging
bitcoin/bitcoin#6317 but the change only occurs in the merge commit
ca5e2a1, not the PR itself).
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Diapolo @paveljanik @jonasschnelli @maflcko @laanwj @jgarzik