-
Notifications
You must be signed in to change notification settings - Fork 36.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UniValue: don't escape solidus, keep espacing of reverse solidus #6339
Conversation
utACK |
I believe univalue/gen.cpp needs to be updated and run to re-generate this, no? I assume you just hand-edited this, but we should still ensure that it's still producing correct output. |
Yes @theuni is correct. |
075a018
to
409291e
Compare
utACK |
@theuni: Meh. Thanks! Wasn't aware of that. Fixed the |
ut ACK |
Added covering for this escaping issue in |
409291e
to
77aeb7c
Compare
77aeb7c UniValue: don't escape solidus, keep espacing of reverse solidus (Jonas Schnelli)
Bitcoin 0.12 RPC PRs 1 Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6266 - bitcoin/bitcoin#6257 - bitcoin/bitcoin#6271 - bitcoin/bitcoin#6158 - bitcoin/bitcoin#6307 - bitcoin/bitcoin#6290 - bitcoin/bitcoin#6262 - bitcoin/bitcoin#6088 - bitcoin/bitcoin#6339 - bitcoin/bitcoin#6299 (partial, remainder in #2099) - bitcoin/bitcoin#6350 - bitcoin/bitcoin#6247 - bitcoin/bitcoin#6362 - bitcoin/bitcoin#5486 - bitcoin/bitcoin#6417 - bitcoin/bitcoin#6398 (partial, remainder was included in #1950) - bitcoin/bitcoin#6444 - bitcoin/bitcoin#6456 (partial, remainder was included in #2082) - bitcoin/bitcoin#6380 - bitcoin/bitcoin#6970 Part of #2074.
After the JSON RFC, solidus ('/') must not be escaped (https://www.ietf.org/rfc/rfc4627.txt see paragraph 2.5)
JSON spirit did not escape a solidus.
Escaping the solidus character made things look bad in bitcoin-cli (or possibly over other RPC clients).
Example:
Before this PR:
http:\/\/127.0.0.1:8332
After this PR:
http://127.0.0.1:8332