Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix null id in RPC response during startup #6362
When processing RPC commands during warmup phase, parse the
Prior to this commit, RPC commands sent during Bitcoin's
id: This member is REQUIRED. It MUST be the same as the value
@jonasschnelli the code is moved from HTTPReq_JSONRPC to CRPCTable::execute, both is downstream from REST/HTTP selection, so RESTS cannot be affected. REST should do its own check and raise its own error, which has nothing to do with JSONRPCError.
Here's the same check for REST: https://github.com/bitcoin/bitcoin/blob/master/src/rest.cpp#L556