Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depends: non-qt bumps for 0.12 #6373

Merged
merged 5 commits into from Jul 15, 2015
Merged

depends: non-qt bumps for 0.12 #6373

merged 5 commits into from Jul 15, 2015

Conversation

@theuni
Copy link
Member

theuni commented Jul 3, 2015

These are all of the possible bumps for 0.12, qt and openssl excluded. I'm not advocating taking all of these, just listing them all in one place for discussion. Each is a separate commit so that the undesired ones can be easily dropped.

  • boost 1.55.0 to 1.58.0: This one's been discussed and I think we're in favor of taking it.
  • qrencode 3.4.3 to 3.4.4: changelog - I can't find specifically what changed, need to compare the sources.
  • protobuf 2.5.0 to 2.6.1: changelog1, changelog2 - This one may be risky, might be better to just leave it alone
  • ccache to 3.1.9 to 3.2.2: changelog - Looks good
  • miniupnpc 1.9.20140701 to 1.9.20150609: changelog
@theuni theuni force-pushed the theuni:0.12bumps branch 2 times, most recently to eb4f35d Jul 3, 2015
@fanquake
Copy link
Member

fanquake commented Jul 4, 2015

This should show you the qrencode changes. fukuchi/libqrencode@055f441...3.4

@luke-jr
Copy link
Member

luke-jr commented Jul 4, 2015

Probably should wait until we're closer to rc1 before bumping, in case there's more fixes?

@laanwj
Copy link
Member

laanwj commented Jul 6, 2015

@luke-jr Bumping sooner has the advantage over doing it last-minute that at least the new versions can get some longer testing.

@laanwj
Copy link
Member

laanwj commented Jul 10, 2015

I'm fine with upgrading all of those.

Though I agree that libprotobuf is the most risky of the bunch.

@theuni
Copy link
Member Author

theuni commented Jul 10, 2015

@luke-jr Yes, I agree with @laanwj. Bumping these early means they get more testing. If obvious bugfixes come in closer to release, we can certainly still pull them in.

@jonasschnelli
Copy link
Member

jonasschnelli commented Jul 10, 2015

Also agreed with @laanwj to take this in as soon as possible.
Tried a gitian build with this PR: https://builds.jonasschnelli.ch/pulls/6373/

@laanwj laanwj added the Build system label Jul 15, 2015
@laanwj
Copy link
Member

laanwj commented Jul 15, 2015

ACK

@laanwj laanwj merged commit eb4f35d into bitcoin:master Jul 15, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Jul 15, 2015
eb4f35d depends: bump qrencode to 3.4.4 (Cory Fields)
142ee60 depends: bump protobuf to 2.6.1 (Cory Fields)
d5b1851 depends: bump ccache to 3.2.2 (Cory Fields)
00c5a73 depends: bump miniupnpc to 1.9.20150609 (Cory Fields)
4bdad99 depends: bump boost to 1.58.0 (Cory Fields)
@Diapolo
Copy link

Diapolo commented Jul 16, 2015

The protobuf update seems to cause warnings:

protobuf-2.6.1\dist\include\google\protobuf\wire_format_lite_inl.h:383: Warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     for (int i = 0; i < new_entries; ++i) {
                       ^
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.