depends: non-qt bumps for 0.12#6373
Merged
Merged
Conversation
Also change the download source from googlecode to github.
f267bc5 to
eb4f35d
Compare
Member
|
This should show you the qrencode changes. fukuchi/libqrencode@055f441...3.4 |
Member
|
Probably should wait until we're closer to rc1 before bumping, in case there's more fixes? |
Member
|
@luke-jr Bumping sooner has the advantage over doing it last-minute that at least the new versions can get some longer testing. |
Member
|
I'm fine with upgrading all of those. Though I agree that libprotobuf is the most risky of the bunch. |
Member
Author
Contributor
|
Also agreed with @laanwj to take this in as soon as possible. |
Member
|
ACK |
|
The protobuf update seems to cause warnings: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are all of the possible bumps for 0.12, qt and openssl excluded. I'm not advocating taking all of these, just listing them all in one place for discussion. Each is a separate commit so that the undesired ones can be easily dropped.