rpc: Remove chain-specific RequireRPCPassword #6398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK |
|
Tested above of #6388. ACK. |
|
ACK |
Yes. Thinking of it, it is kind of a lame check. Maybe better to just remove it. |
|
ACK |
I've never liked the chain-specific exception to having to set a password. It gives issues with bitcoin#6388 which makes it valid to set no password in every case (as it enables random cookie authentication). This pull removes the flag, so that all chains are regarded the same. It also removes the username==password test, which doesn't provide any substantial extra security.
laanwj
force-pushed
the
2015_07_remove_requirerpcpassword_flag
branch
from
e4cc3bf
to
85ee55b
Compare
laanwj
added a commit
that referenced
this pull request
Jul 13, 2015
85ee55b rpc: Remove chain-specific RequireRPCPassword (Wladimir J. van der Laan)
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Mar 4, 2017
Bitcoin 0.12 RPC PRs 1 Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6266 - bitcoin/bitcoin#6257 - bitcoin/bitcoin#6271 - bitcoin/bitcoin#6158 - bitcoin/bitcoin#6307 - bitcoin/bitcoin#6290 - bitcoin/bitcoin#6262 - bitcoin/bitcoin#6088 - bitcoin/bitcoin#6339 - bitcoin/bitcoin#6299 (partial, remainder in #2099) - bitcoin/bitcoin#6350 - bitcoin/bitcoin#6247 - bitcoin/bitcoin#6362 - bitcoin/bitcoin#5486 - bitcoin/bitcoin#6417 - bitcoin/bitcoin#6398 (partial, remainder was included in #1950) - bitcoin/bitcoin#6444 - bitcoin/bitcoin#6456 (partial, remainder was included in #2082) - bitcoin/bitcoin#6380 - bitcoin/bitcoin#6970 Part of #2074.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've never liked the chain-specific exception to having to set a password. Also it conflicts with #6388 which makes it generally valid to set no password (as it then enables random cookie authentication).
This pull removes the flag, so that all chains are regarded the same.
It also adapts the tests so that they no longer rely on the previous behavior.