New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Remove chain-specific RequireRPCPassword #6398

Merged
merged 1 commit into from Jul 13, 2015

Conversation

Projects
None yet
5 participants
@laanwj
Member

laanwj commented Jul 8, 2015

I've never liked the chain-specific exception to having to set a password. Also it conflicts with #6388 which makes it generally valid to set no password (as it then enables random cookie authentication).

This pull removes the flag, so that all chains are regarded the same.
It also adapts the tests so that they no longer rely on the previous behavior.

@laanwj laanwj added the RPC/REST/ZMQ label Jul 8, 2015

@Diapolo

This comment has been minimized.

Show comment
Hide comment
@Diapolo

Diapolo commented Jul 8, 2015

utACK

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jul 8, 2015

Member

Tested above of #6388.

ACK.

Member

jonasschnelli commented Jul 8, 2015

Tested above of #6388.

ACK.

@jgarzik

This comment has been minimized.

Show comment
Hide comment
@jgarzik

jgarzik Jul 8, 2015

Contributor

ACK

Contributor

jgarzik commented Jul 8, 2015

ACK

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jul 9, 2015

Member

Hmm, this username==password here is sub-optiomal

Yes. Thinking of it, it is kind of a lame check. Maybe better to just remove it.

Member

laanwj commented Jul 9, 2015

Hmm, this username==password here is sub-optiomal

Yes. Thinking of it, it is kind of a lame check. Maybe better to just remove it.

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Jul 9, 2015

Member

ACK

Member

sipa commented Jul 9, 2015

ACK

rpc: Remove chain-specific RequireRPCPassword
I've never liked the chain-specific exception to having to set a
password. It gives issues with #6388 which makes it valid to
set no password in every case (as it enables random cookie authentication).

This pull removes the flag, so that all chains are regarded the same.

It also removes the username==password test, which doesn't provide any
substantial extra security.

@laanwj laanwj merged commit 85ee55b into bitcoin:master Jul 13, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jul 13, 2015

Merge pull request #6398
85ee55b rpc: Remove chain-specific RequireRPCPassword (Wladimir J. van der Laan)

@str4d str4d referenced this pull request Feb 15, 2017

Merged

Bitcoin 0.12 RPC PRs 1 #2100

@dagurval dagurval referenced this pull request Mar 14, 2017

Merged

Chainparams backports #189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment